Edit

kc3-lang/angle/src/libANGLE/ProgramPipeline.h

Branch :

  • Show log

    Commit

  • Author : Jamie Madill
    Date : 2017-11-21 19:22:44
    Hash : acf2f3ad
    Message : Apply Chromium style fixes. This addresses several minor code quality issues that are validated in Chromium, but not yet applied to ANGLE: * constructors and destructors must be defined out-of-line * auto is not allowed for simple pointer types * use override everywhere instead of virtual * virtual functions must also be defined out-of-line Slightly reduces binary size for me (~2k on Win, 150k on Linux). Bug: angleproject:1569 Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6 Reviewed-on: https://chromium-review.googlesource.com/779959 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

  • src/libANGLE/ProgramPipeline.h
  • //
    // Copyright (c) 2017 The ANGLE Project Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    //
    
    // ProgramPipeline.h: Defines the gl::ProgramPipeline class.
    // Implements GL program pipeline objects and related functionality.
    // [OpenGL ES 3.1] section 7.4 page 105.
    
    #ifndef LIBANGLE_PROGRAMPIPELINE_H_
    #define LIBANGLE_PROGRAMPIPELINE_H_
    
    #include <memory>
    
    #include "common/angleutils.h"
    #include "libANGLE/Debug.h"
    #include "libANGLE/RefCountObject.h"
    
    namespace rx
    {
    class GLImplFactory;
    class ProgramPipelineImpl;
    };
    
    namespace gl
    {
    class Context;
    class ProgramPipeline;
    
    class ProgramPipelineState final : angle::NonCopyable
    {
      public:
        ProgramPipelineState();
        ~ProgramPipelineState();
    
        const std::string &getLabel() const;
    
      private:
        friend class ProgramPipeline;
    
        std::string mLabel;
    };
    
    class ProgramPipeline final : public RefCountObject, public LabeledObject
    {
      public:
        ProgramPipeline(rx::GLImplFactory *factory, GLuint handle);
        ~ProgramPipeline() override;
    
        Error onDestroy(const Context *context) override;
    
        void setLabel(const std::string &label) override;
        const std::string &getLabel() const override;
    
        rx::ProgramPipelineImpl *getImplementation() const;
    
      private:
        std::unique_ptr<rx::ProgramPipelineImpl> mProgramPipeline;
    
        ProgramPipelineState mState;
    };
    }
    
    #endif  // LIBANGLE_PROGRAMPIPELINE_H_