Edit

kc3-lang/angle/src/libANGLE/renderer/gl/SurfaceGL.cpp

Branch :

  • Show log

    Commit

  • Author : Geoff Lang
    Date : 2018-05-01 16:48:21
    Hash : bf7b95db
    Message : Create a default framebuffer per surface/context pair on MakeCurrent. Sharing a gl::Framebuffer object between multiple contexts causes problems if contexts are not virtualized because the native framebuffer objects are not shared between these contexts. The FramebufferImpl created should be the glue that binds a specific context to a specific surface. Update the SurfaceImpl implementations to re-create the framebuffer object before passing it to FramebufferGL. No backing resources will be re-created. BUG=angleproject:2464 Change-Id: Id0b13a221c22b71517b25cb5b1ef2392ad2ecdd6 Reviewed-on: https://chromium-review.googlesource.com/1039985 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

  • src/libANGLE/renderer/gl/SurfaceGL.cpp
  • //
    // Copyright (c) 2015 The ANGLE Project Authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.
    //
    
    // SurfaceGL.cpp: OpenGL implementation of egl::Surface
    
    #include "libANGLE/renderer/gl/SurfaceGL.h"
    
    #include "libANGLE/Context.h"
    #include "libANGLE/Surface.h"
    #include "libANGLE/renderer/gl/BlitGL.h"
    #include "libANGLE/renderer/gl/ContextGL.h"
    #include "libANGLE/renderer/gl/FramebufferGL.h"
    #include "libANGLE/renderer/gl/RendererGL.h"
    
    namespace rx
    {
    
    SurfaceGL::SurfaceGL(const egl::SurfaceState &state) : SurfaceImpl(state)
    {
    }
    
    SurfaceGL::~SurfaceGL()
    {
    }
    
    FramebufferImpl *SurfaceGL::createDefaultFramebuffer(const gl::Context *context,
                                                         const gl::FramebufferState &data)
    {
        return new FramebufferGL(data, 0, true);
    }
    
    egl::Error SurfaceGL::getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc)
    {
        UNREACHABLE();
        return egl::EglBadSurface();
    }
    
    egl::Error SurfaceGL::unMakeCurrent()
    {
        return egl::NoError();
    }
    
    gl::Error SurfaceGL::initializeContents(const gl::Context *context,
                                            const gl::ImageIndex &imageIndex)
    {
        FramebufferGL *framebufferGL = GetImplAs<FramebufferGL>(context->getFramebuffer(0));
        ASSERT(framebufferGL->isDefault());
    
        BlitGL *blitter = GetBlitGL(context);
        ANGLE_TRY(blitter->clearFramebuffer(framebufferGL));
    
        return gl::NoError();
    }
    
    }  // namespace rx