-
Show log
Commit
-
Hash : c9955641
Author :
Date : 2023-09-25T14:31:01
Avoid malloc in angle::Mat4 by using array instead of vector angle::Matrix<float>::inverse() showed up in cpu profile of "minetest" trace at ~10%. It's a gles1 trace. Multiple objects are constructed and require malloc due to the use of std::vector. Called here: https://crsrc.org/c/third_party/angle/src/libANGLE/GLES1Renderer.cpp;drc=eb0d59973d21f845b5785563f5d56b8ebb617478;l=371 This CL decouples Mat4 from angle::Matrix (some of the functionality had to be copied over) to switch from std::vector to std::array. Testing "minetest" on a phone I saw a ~20% cpu power improvement due to this CL. There is an existing unit test coverage: MatrixUtilsTest.Mat4InvTr Moved 4x4 cofactor matrix code to a helper with transposition included Bug: b/301977186 Change-Id: I1e4c2201d19759dd37c0fee44fb44f4d24a58a6b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4885501 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
-
Files
- BinaryStream.h
- BinaryStream_unittest.cpp
- CircularBuffer.h
- CircularBuffer_unittest.cpp
- Color.h
- Color.inc
- CompiledShaderState.cpp
- CompiledShaderState.h
- FastVector.h
- FastVector_unittest.cpp
- FixedQueue.h
- FixedQueue_unittest.cpp
- FixedVector.h
- FixedVector_unittest.cpp
- Float16ToFloat32.cpp
- Float16ToFloat32.py
- MemoryBuffer.cpp
- MemoryBuffer.h
- Optional.h
- Optional_unittest.cpp
- PackedCLEnums_autogen.cpp
- PackedCLEnums_autogen.h
- PackedEGLEnums_autogen.cpp
- PackedEGLEnums_autogen.h
- PackedEnums.cpp
- PackedEnums.h
- PackedGLEnums_autogen.cpp
- PackedGLEnums_autogen.h
- PoolAlloc.cpp
- PoolAlloc.h
- PoolAlloc_unittest.cpp
- RingBufferAllocator.cpp
- RingBufferAllocator.h
- Spinlock.h
- SynchronizedValue.h
- WorkerThread.cpp
- WorkerThread.h
- WorkerThread_unittest.cpp
- aligned_memory.cpp
- aligned_memory.h
- aligned_memory_unittest.cpp
- android_util.cpp
- android_util.h
- angle_version.h
- angle_version_info.cpp
- angle_version_info.h
- angleutils.cpp
- angleutils.h
- angleutils_unittest.cpp
- apple/
- apple_platform_utils.h
- apple_platform_utils.mm
- backtrace_utils.h
- backtrace_utils_android.cpp
- backtrace_utils_noop.cpp
- base/
- bitset_utils.h
- bitset_utils_unittest.cpp
- debug.cpp
- debug.h
- entry_points_enum_autogen.cpp
- entry_points_enum_autogen.h
- event_tracer.cpp
- event_tracer.h
- frame_capture_utils.cpp
- frame_capture_utils.h
- frame_capture_utils_autogen.cpp
- frame_capture_utils_autogen.h
- fuchsia_egl/
- gen_packed_gl_enums.py
- gen_uniform_type_table.py
- gl/
- gl_enum_utils.cpp
- gl_enum_utils.h
- gl_enum_utils_autogen.cpp
- gl_enum_utils_autogen.h
- hash_utils.h
- hash_utils_unittest.cpp
- linux/
- mathutil.cpp
- mathutil.h
- mathutil_unittest.cpp
- matrix_utils.cpp
- matrix_utils.h
- matrix_utils_unittest.cpp
- packed_cl_enums.json
- packed_egl_enums.json
- packed_gl_enums.json
- platform.h
- platform_helpers.cpp
- platform_helpers.h
- serializer/
- spirv/
- string_utils.cpp
- string_utils.h
- string_utils_unittest.cpp
- system_utils.cpp
- system_utils.h
- system_utils_apple.cpp
- system_utils_ios.cpp
- system_utils_ios.mm
- system_utils_linux.cpp
- system_utils_mac.cpp
- system_utils_posix.cpp
- system_utils_unittest.cpp
- system_utils_win.cpp
- system_utils_win32.cpp
- system_utils_winuwp.cpp
- third_party/
- tls.cpp
- tls.h
- uniform_type_info_autogen.cpp
- utilities.cpp
- utilities.h
- utilities_unittest.cpp
- vector_utils.h
- vector_utils_unittest.cpp
- vulkan/
