Hash :
716c5d00
Author :
Date :
2023-11-13T10:23:10
Vulkan: Add RGB8-to-RGBA8 ubyte loading function
Currently, to update RGB8 on desktop, ANGLE uses memcpy for each
pixel, which is suboptimal. This CL adds a loading function to improve
the copy time for RGB textures where RGBA is needed on the hardware.
* Added a specialization to LoadToNative3To4() for unsigned bytes
using 0xFF as the fourth component.
* It is optimized for unsigned bytes when converting an RGB format
to its corresponding RGBA format, e.g., RGB8 to RGBA8.
* It uses uint32_t operations to speed up the process.
* Added unit tests for the specialized LoadToNative3To4.
* LoadToNative_unittest.cpp
* Added perf test for RGB8 image allocation and loading.
* RGBImageAllocationBenchmark in RGBImageAllocation.cpp.
* RGBImageAllocationBenchmark shows some improvement in cpu_time
and wall_time on a Linux and a Windows device. (Results below using
aligned source pointer and texture size of 2048):
* On Windows: +~85% cpu_time, +~71% wall_time
* On Linux: +~26% cpu_time, +~27% wall_time
Bug: b/308177124
Change-Id: I421d83f75fdc513b0111dffb0a5d5e74682dd6fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4995489
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
# Copyright 2015 The ANGLE Project Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("../../gni/angle.gni")
angle_unittests_sources = [
"../../util/test_utils_unittest.cpp",
"../../util/test_utils_unittest_helper.h",
"../common/BinaryStream_unittest.cpp",
"../common/CircularBuffer_unittest.cpp",
"../common/FastVector_unittest.cpp",
"../common/FixedQueue_unittest.cpp",
"../common/FixedVector_unittest.cpp",
"../common/Optional_unittest.cpp",
"../common/PoolAlloc_unittest.cpp",
"../common/WorkerThread_unittest.cpp",
"../common/aligned_memory_unittest.cpp",
"../common/angleutils_unittest.cpp",
"../common/bitset_utils_unittest.cpp",
"../common/hash_utils_unittest.cpp",
"../common/mathutil_unittest.cpp",
"../common/matrix_utils_unittest.cpp",
"../common/string_utils_unittest.cpp",
"../common/system_utils_unittest.cpp",
"../common/utilities_unittest.cpp",
"../common/vector_utils_unittest.cpp",
"../compiler/translator/span_unittest.cpp",
"../feature_support_util/feature_support_util_unittest.cpp",
"../gpu_info_util/SystemInfo_unittest.cpp",
"../image_util/AstcDecompressorTestUtils.h",
"../image_util/AstcDecompressor_unittest.cpp",
"../image_util/LoadToNative_unittest.cpp",
"../libANGLE/BlendStateExt_unittest.cpp",
"../libANGLE/BlobCache_unittest.cpp",
"../libANGLE/Config_unittest.cpp",
"../libANGLE/ContextMutex_unittest.cpp",
"../libANGLE/Fence_unittest.cpp",
"../libANGLE/GlobalMutex_unittest.cpp",
"../libANGLE/HandleAllocator_unittest.cpp",
"../libANGLE/ImageIndexIterator_unittest.cpp",
"../libANGLE/Image_unittest.cpp",
"../libANGLE/Observer_unittest.cpp",
"../libANGLE/Program_unittest.cpp",
"../libANGLE/ResourceManager_unittest.cpp",
"../libANGLE/ResourceMap_unittest.cpp",
"../libANGLE/SizedMRUCache_unittest.cpp",
"../libANGLE/Surface_unittest.cpp",
"../libANGLE/TransformFeedback_unittest.cpp",
"../libANGLE/UnlockedTailCall_unittest.cpp",
"../libANGLE/VaryingPacking_unittest.cpp",
"../libANGLE/VertexArray_unittest.cpp",
"../libANGLE/renderer/BufferImpl_mock.h",
"../libANGLE/renderer/FramebufferImpl_mock.h",
"../libANGLE/renderer/ImageImpl_mock.h",
"../libANGLE/renderer/ProgramImpl_mock.h",
"../libANGLE/renderer/RenderbufferImpl_mock.h",
"../libANGLE/renderer/TextureImpl_mock.h",
"../libANGLE/renderer/TransformFeedbackImpl_mock.h",
"../libANGLE/renderer/serial_utils_unittest.cpp",
"angle_unittests_utils.h",
"preprocessor_tests/MockDiagnostics.h",
"preprocessor_tests/MockDirectiveHandler.h",
"preprocessor_tests/PreprocessorTest.cpp",
"preprocessor_tests/PreprocessorTest.h",
"preprocessor_tests/char_test.cpp",
"preprocessor_tests/comment_test.cpp",
"preprocessor_tests/define_test.cpp",
"preprocessor_tests/error_test.cpp",
"preprocessor_tests/extension_test.cpp",
"preprocessor_tests/identifier_test.cpp",
"preprocessor_tests/if_test.cpp",
"preprocessor_tests/input_test.cpp",
"preprocessor_tests/location_test.cpp",
"preprocessor_tests/number_test.cpp",
"preprocessor_tests/operator_test.cpp",
"preprocessor_tests/pragma_test.cpp",
"preprocessor_tests/space_test.cpp",
"preprocessor_tests/token_test.cpp",
"preprocessor_tests/version_test.cpp",
"test_expectations/GPUTestExpectationsParser_unittest.cpp",
"test_utils/ShaderExtensionTest.h",
"test_utils/angle_test_instantiate.h",
"test_utils/compiler_test.cpp",
"test_utils/compiler_test.h",
]
angle_unittests_compiler_tests_sources = [
"compiler_tests/API_test.cpp",
"compiler_tests/APPLE_clip_distance_test.cpp",
"compiler_tests/ARB_texture_rectangle_test.cpp",
"compiler_tests/AppendixALimitations_test.cpp",
"compiler_tests/AtomicCounter_test.cpp",
"compiler_tests/BufferVariables_test.cpp",
"compiler_tests/CollectVariables_test.cpp",
"compiler_tests/ConstantFoldingNaN_test.cpp",
"compiler_tests/ConstantFoldingOverflow_test.cpp",
"compiler_tests/ConstantFolding_test.cpp",
"compiler_tests/ConstructCompiler_test.cpp",
"compiler_tests/EXT_YUV_target_test.cpp",
"compiler_tests/EXT_blend_func_extended_test.cpp",
"compiler_tests/EXT_clip_cull_distance_test.cpp",
"compiler_tests/EXT_frag_depth_test.cpp",
"compiler_tests/EXT_shader_framebuffer_fetch_test.cpp",
"compiler_tests/EXT_shader_texture_lod_test.cpp",
"compiler_tests/EXT_shadow_samplers_test.cpp",
"compiler_tests/EmulateGLBaseVertexBaseInstance_test.cpp",
"compiler_tests/EmulateGLDrawID_test.cpp",
"compiler_tests/EmulateGLFragColorBroadcast_test.cpp",
"compiler_tests/ExpressionLimit_test.cpp",
"compiler_tests/ExtensionDirective_test.cpp",
"compiler_tests/FloatLex_test.cpp",
"compiler_tests/FragDepth_test.cpp",
"compiler_tests/GLSLCompatibilityOutput_test.cpp",
"compiler_tests/GeometryShader_test.cpp",
"compiler_tests/GlFragDataNotModified_test.cpp",
"compiler_tests/ImmutableString_test.cpp",
"compiler_tests/InitOutputVariables_test.cpp",
"compiler_tests/IntermNode_test.cpp",
"compiler_tests/KHR_blend_equation_advanced_test.cpp",
"compiler_tests/NV_draw_buffers_test.cpp",
"compiler_tests/OES_sample_variables_test.cpp",
"compiler_tests/OES_standard_derivatives_test.cpp",
"compiler_tests/OES_texture_cube_map_array_test.cpp",
"compiler_tests/OVR_multiview2_test.cpp",
"compiler_tests/OVR_multiview_test.cpp",
"compiler_tests/Pack_Unpack_test.cpp",
"compiler_tests/PruneEmptyCases_test.cpp",
"compiler_tests/PruneEmptyDeclarations_test.cpp",
"compiler_tests/PrunePureLiteralStatements_test.cpp",
"compiler_tests/PruneUnusedFunctions_test.cpp",
"compiler_tests/QualificationOrderESSL31_test.cpp",
"compiler_tests/QualificationOrder_test.cpp",
"compiler_tests/RecordConstantPrecision_test.cpp",
"compiler_tests/RegenerateStructNames_test.cpp",
"compiler_tests/RemoveUnreferencedVariables_test.cpp",
"compiler_tests/SamplerMultisample_test.cpp",
"compiler_tests/SamplerVideoWEBGL_test.cpp",
"compiler_tests/ShCompile_test.cpp",
"compiler_tests/ShaderImage_test.cpp",
"compiler_tests/ShaderValidation_test.cpp",
"compiler_tests/ShaderVariable_test.cpp",
"compiler_tests/TextureFunction_test.cpp",
"compiler_tests/TypeTracking_test.cpp",
"compiler_tests/Type_test.cpp",
"compiler_tests/VariablePacker_test.cpp",
"compiler_tests/WorkGroupSize_test.cpp",
"test_utils/ConstantFoldingTest.cpp",
"test_utils/ConstantFoldingTest.h",
"test_utils/ShaderCompileTreeTest.cpp",
"test_utils/ShaderCompileTreeTest.h",
]
angle_unittests_glsl_mac_sources = [
"compiler_tests/RewriteDoWhile_test.cpp",
"compiler_tests/UnfoldShortCircuitAST_test.cpp",
]
# TODO(jmadill): should probably call this windows sources
angle_unittests_hlsl_sources = [
"compiler_tests/HLSLOutput_test.cpp",
"compiler_tests/UnrollFlatten_test.cpp",
]
angle_unittests_gl_sources =
[ "../libANGLE/renderer/gl/DisplayGL_unittest.cpp" ]
angle_unittests_msl_sources = [ "../tests/compiler_tests/MSLOutput_test.cpp" ]
if (!angle_enable_desktop_glsl) {
angle_unittests_sources +=
[ "compiler_tests/ImmutableString_test_ESSL_autogen.cpp" ]
} else {
angle_unittests_sources +=
[ "compiler_tests/ImmutableString_test_autogen.cpp" ]
}
if (!is_android && !is_fuchsia && !is_ios) {
angle_unittests_sources += [ "test_utils/runner/TestSuite_unittest.cpp" ]
}