Hash :
382bf288
Author :
Date :
2020-12-24T23:56:39
Organize AST transforms per backend Most of the AST transforms are written as a workaround to an issue that affects a single backend. This change identifies such transforms and organizes them by backend. They are then only built if the respective backend is. Additionally, about half of the GL transforms are due to mac workarounds, including the large RewriteRowMajorMatrices transform. Mac-specific workarounds are additionally only built on said platform. This change reduces the ANGLE binary size: - 106KB in a Vulkan-only build on Linux - 27KB in a GL-only build on Android (60KB on Linux) Bug: chromium:1084580 Bug: chromium:1161513 Change-Id: I64b334332c0d4f848756c6538af0d8d96864c7e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601346 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Tim Van Patten <timvp@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97
//
// Copyright 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// RewriteRepeatedAssignToSwizzled.cpp: Rewrite expressions that assign an assignment to a swizzled
// vector, like:
// v.x = z = expression;
// to:
// z = expression;
// v.x = z;
//
// Note that this doesn't handle some corner cases: expressions nested inside other expressions,
// inside loop headers, or inside if conditions.
#include "compiler/translator/tree_ops/gl/RewriteRepeatedAssignToSwizzled.h"
#include "compiler/translator/tree_util/IntermNode_util.h"
#include "compiler/translator/tree_util/IntermTraverse.h"
namespace sh
{
namespace
{
class RewriteAssignToSwizzledTraverser : public TIntermTraverser
{
public:
ANGLE_NO_DISCARD static bool rewrite(TCompiler *compiler, TIntermBlock *root);
private:
RewriteAssignToSwizzledTraverser();
bool visitBinary(Visit, TIntermBinary *node) override;
void nextIteration();
bool didRewrite() { return mDidRewrite; }
bool mDidRewrite;
};
// static
bool RewriteAssignToSwizzledTraverser::rewrite(TCompiler *compiler, TIntermBlock *root)
{
RewriteAssignToSwizzledTraverser rewrite;
do
{
rewrite.nextIteration();
root->traverse(&rewrite);
if (!rewrite.updateTree(compiler, root))
{
return false;
}
} while (rewrite.didRewrite());
return true;
}
RewriteAssignToSwizzledTraverser::RewriteAssignToSwizzledTraverser()
: TIntermTraverser(true, false, false), mDidRewrite(false)
{}
void RewriteAssignToSwizzledTraverser::nextIteration()
{
mDidRewrite = false;
}
bool RewriteAssignToSwizzledTraverser::visitBinary(Visit, TIntermBinary *node)
{
TIntermBinary *rightBinary = node->getRight()->getAsBinaryNode();
TIntermBlock *parentBlock = getParentNode()->getAsBlock();
if (parentBlock && node->isAssignment() && node->getLeft()->getAsSwizzleNode() && rightBinary &&
rightBinary->isAssignment())
{
TIntermSequence replacements;
replacements.push_back(rightBinary);
TIntermTyped *rightAssignmentTargetCopy = rightBinary->getLeft()->deepCopy();
TIntermBinary *lastAssign =
new TIntermBinary(EOpAssign, node->getLeft(), rightAssignmentTargetCopy);
replacements.push_back(lastAssign);
mMultiReplacements.push_back(NodeReplaceWithMultipleEntry(parentBlock, node, replacements));
mDidRewrite = true;
return false;
}
return true;
}
} // anonymous namespace
bool RewriteRepeatedAssignToSwizzled(TCompiler *compiler, TIntermBlock *root)
{
return RewriteAssignToSwizzledTraverser::rewrite(compiler, root);
}
} // namespace sh