kc3-lang/angle/src/compiler/translator/tree_ops/vulkan/RemoveAtomicCounterBuiltins.cpp

• Show log

  Commit

• Hash : 382bf288
  Author :
  Date : 2020-12-24T23:56:39
  

  Organize AST transforms per backend
  
  Most of the AST transforms are written as a workaround to an issue that
  affects a single backend.  This change identifies such transforms and
  organizes them by backend.  They are then only built if the respective
  backend is.
  
  Additionally, about half of the GL transforms are due to mac
  workarounds, including the large RewriteRowMajorMatrices transform.
  Mac-specific workarounds are additionally only built on said platform.
  
  This change reduces the ANGLE binary size:
  
  - 106KB in a Vulkan-only build on Linux
  - 27KB in a GL-only build on Android (60KB on Linux)
  
  Bug: chromium:1084580
  Bug: chromium:1161513
  Change-Id: I64b334332c0d4f848756c6538af0d8d96864c7e9
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601346
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  

Download

• src/compiler/translator/tree_ops/vulkan/RemoveAtomicCounterBuiltins.cpp

• //
  // Copyright 2020 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // RemoveAtomicCounterBuiltins: Remove atomic counter builtins.
  //
  
  #include "compiler/translator/tree_ops/vulkan/RemoveAtomicCounterBuiltins.h"
  
  #include "compiler/translator/Compiler.h"
  #include "compiler/translator/tree_util/IntermTraverse.h"
  
  namespace sh
  {
  namespace
  {
  
  bool IsAtomicCounterDecl(const TIntermDeclaration *node)
  {
      const TIntermSequence &sequence = *(node->getSequence());
      TIntermTyped *variable          = sequence.front()->getAsTyped();
      const TType &type               = variable->getType();
      return type.getQualifier() == EvqUniform && type.isAtomicCounter();
  }
  
  // Traverser that removes all GLSL built-ins that use AtomicCounters
  // Only called when the builtins are in use, but no atomic counters have been declared
  class RemoveAtomicCounterBuiltinsTraverser : public TIntermTraverser
  {
    public:
      RemoveAtomicCounterBuiltinsTraverser() : TIntermTraverser(true, false, false) {}
  
      bool visitDeclaration(Visit visit, TIntermDeclaration *node) override
      {
          ASSERT(visit == PreVisit);
  
          // Active atomic counters should have been removed by RewriteAtomicCounters, and this
          // traversal should not have been invoked
          ASSERT(!IsAtomicCounterDecl(node));
          return false;
      }
  
      bool visitAggregate(Visit visit, TIntermAggregate *node) override
      {
          if (node->getOp() == EOpMemoryBarrierAtomicCounter)
          {
              // Vulkan does not support atomic counters, so if this builtin finds its way here,
              // we need to remove it.
              TIntermSequence emptySequence;
              mMultiReplacements.emplace_back(getParentNode()->getAsBlock(), node, emptySequence);
              return true;
          }
  
          // We shouldn't see any other builtins because they cannot be present without an active
          // atomic counter, and should have been removed by RewriteAtomicCounters. If this fires,
          // this traversal should not have been called.
          ASSERT(!(node->getOp() == EOpCallBuiltInFunction &&
                   node->getFunction()->isAtomicCounterFunction()));
  
          return false;
      }
  };
  
  }  // anonymous namespace
  
  bool RemoveAtomicCounterBuiltins(TCompiler *compiler, TIntermBlock *root)
  {
      RemoveAtomicCounterBuiltinsTraverser traverser;
      root->traverse(&traverser);
      return traverser.updateTree(compiler, root);
  }
  }  // namespace sh
  

Download