kc3-lang/angle/src/libANGLE/renderer/SurfaceImpl.cpp

• Show log

  Commit

• Hash : 926b43e7
  Author :
  Date : 2022-01-06T13:31:54
  

  Reland: Frontend: separate lock in swap prep
  
  Swapchain-based backends like Vulkan might block a lot in
  vkAcquireNextImageKHR, which is bad for overall fast progress if we also
  hold the global EGL lock there.
  
  This CL starts to split the global EGL lock. We release the EGL lock
  when performing vkAcquireNextImageKHR, and only maintain a lock for
  surfaces.
  
  This is done via a new custom entry point, EGL_PrepareSwapBuffers, so
  that we can control how the global lock is used throughout the entire
  call.
  
  Bug: angleproject:6851
  Change-Id: I095cd8b3bdbb13c842cab0a46148e2122582cdfd
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373426
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Lingfeng Yang <lfy@google.com>
  

Download

• src/libANGLE/renderer/SurfaceImpl.cpp

• //
  // Copyright 2002 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SurfaceImpl.cpp: Implementation of Surface stub method class
  
  #include "libANGLE/renderer/SurfaceImpl.h"
  
  namespace rx
  {
  
  SurfaceImpl::SurfaceImpl(const egl::SurfaceState &state) : mState(state) {}
  
  SurfaceImpl::~SurfaceImpl() {}
  
  egl::Error SurfaceImpl::makeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::unMakeCurrent(const gl::Context *context)
  {
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::prepareSwap(const gl::Context *)
  {
      return angle::ResultToEGL(angle::Result::Continue);
  }
  
  egl::Error SurfaceImpl::swapWithDamage(const gl::Context *context,
                                         const EGLint *rects,
                                         EGLint n_rects)
  {
      UNREACHABLE();
      return egl::EglBadSurface() << "swapWithDamage implementation missing.";
  }
  
  egl::Error SurfaceImpl::setPresentationTime(EGLnsecsANDROID time)
  {
      UNREACHABLE();
      return egl::EglBadSurface() << "setPresentationTime implementation missing.";
  }
  
  void SurfaceImpl::setFixedWidth(EGLint width)
  {
      UNREACHABLE();
  }
  
  void SurfaceImpl::setFixedHeight(EGLint height)
  {
      UNREACHABLE();
  }
  
  void SurfaceImpl::setTimestampsEnabled(bool enabled)
  {
      UNREACHABLE();
  }
  
  const angle::Format *SurfaceImpl::getD3DTextureColorFormat() const
  {
      UNREACHABLE();
      return nullptr;
  }
  
  egl::SupportedCompositorTimings SurfaceImpl::getSupportedCompositorTimings() const
  {
      UNREACHABLE();
      return egl::SupportedCompositorTimings();
  }
  
  egl::Error SurfaceImpl::getCompositorTiming(EGLint numTimestamps,
                                              const EGLint *names,
                                              EGLnsecsANDROID *values) const
  {
      UNREACHABLE();
      return egl::EglBadDisplay();
  }
  
  egl::Error SurfaceImpl::getNextFrameId(EGLuint64KHR *frameId) const
  {
      UNREACHABLE();
      return egl::EglBadDisplay();
  }
  
  egl::SupportedTimestamps SurfaceImpl::getSupportedTimestamps() const
  {
      UNREACHABLE();
      return egl::SupportedTimestamps();
  }
  
  egl::Error SurfaceImpl::getFrameTimestamps(EGLuint64KHR frameId,
                                             EGLint numTimestamps,
                                             const EGLint *timestamps,
                                             EGLnsecsANDROID *values) const
  {
      UNREACHABLE();
      return egl::EglBadDisplay();
  }
  
  egl::Error SurfaceImpl::swapWithFrameToken(const gl::Context *context,
                                             EGLFrameTokenANGLE frameToken)
  {
      UNREACHABLE();
      return egl::EglBadDisplay();
  }
  
  egl::Error SurfaceImpl::getUserWidth(const egl::Display *display, EGLint *value) const
  {
      *value = getWidth();
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::getUserHeight(const egl::Display *display, EGLint *value) const
  {
      *value = getHeight();
      return egl::NoError();
  }
  
  egl::Error SurfaceImpl::getBufferAge(const gl::Context *context, EGLint *age)
  {
      UNREACHABLE();
      return egl::EglBadMatch();
  }
  
  egl::Error SurfaceImpl::lockSurface(const egl::Display *display,
                                      EGLint usageHint,
                                      bool preservePixels,
                                      uint8_t **bufferPtrOut,
                                      EGLint *bufferPitchOut)
  {
      UNREACHABLE();
      return egl::EglBadMatch();
  }
  
  egl::Error SurfaceImpl::unlockSurface(const egl::Display *display, bool preservePixels)
  {
      UNREACHABLE();
      return egl::EglBadMatch();
  }
  
  EGLint SurfaceImpl::origin() const
  {
      return EGL_LOWER_LEFT_KHR;
  }
  
  egl::Error SurfaceImpl::setRenderBuffer(EGLint renderBuffer)
  {
      return egl::NoError();
  }
  }  // namespace rx
  

Download