kc3-lang/angle/src/libANGLE/renderer/SurfaceImpl.h

• Show log

  Commit

• Hash : 926b43e7
  Author :
  Date : 2022-01-06T13:31:54
  

  Reland: Frontend: separate lock in swap prep
  
  Swapchain-based backends like Vulkan might block a lot in
  vkAcquireNextImageKHR, which is bad for overall fast progress if we also
  hold the global EGL lock there.
  
  This CL starts to split the global EGL lock. We release the EGL lock
  when performing vkAcquireNextImageKHR, and only maintain a lock for
  surfaces.
  
  This is done via a new custom entry point, EGL_PrepareSwapBuffers, so
  that we can control how the global lock is used throughout the entire
  call.
  
  Bug: angleproject:6851
  Change-Id: I095cd8b3bdbb13c842cab0a46148e2122582cdfd
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373426
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Lingfeng Yang <lfy@google.com>
  

Download

• src/libANGLE/renderer/SurfaceImpl.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // SurfaceImpl.h: Implementation methods of egl::Surface
  
  #ifndef LIBANGLE_RENDERER_SURFACEIMPL_H_
  #define LIBANGLE_RENDERER_SURFACEIMPL_H_
  
  #include <EGL/egl.h>
  #include <EGL/eglext.h>
  
  #include "common/angleutils.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/FramebufferAttachment.h"
  #include "libANGLE/renderer/FramebufferAttachmentObjectImpl.h"
  
  namespace angle
  {
  struct Format;
  }
  
  namespace gl
  {
  class Context;
  class FramebufferState;
  }  // namespace gl
  
  namespace egl
  {
  class Display;
  struct Config;
  struct SurfaceState;
  class Thread;
  
  using SupportedTimestamps        = angle::PackedEnumBitSet<Timestamp>;
  using SupportedCompositorTimings = angle::PackedEnumBitSet<CompositorTiming>;
  }  // namespace egl
  
  namespace rx
  {
  class FramebufferImpl;
  
  class SurfaceImpl : public FramebufferAttachmentObjectImpl
  {
    public:
      SurfaceImpl(const egl::SurfaceState &surfaceState);
      ~SurfaceImpl() override;
      virtual void destroy(const egl::Display *display) {}
  
      virtual egl::Error initialize(const egl::Display *display)                           = 0;
      virtual FramebufferImpl *createDefaultFramebuffer(const gl::Context *context,
                                                        const gl::FramebufferState &state) = 0;
      virtual egl::Error makeCurrent(const gl::Context *context);
      virtual egl::Error unMakeCurrent(const gl::Context *context);
      virtual egl::Error prepareSwap(const gl::Context *);
      virtual egl::Error swap(const gl::Context *context) = 0;
      virtual egl::Error swapWithDamage(const gl::Context *context,
                                        const EGLint *rects,
                                        EGLint n_rects);
      virtual egl::Error swapWithFrameToken(const gl::Context *context,
                                            EGLFrameTokenANGLE frameToken);
      virtual egl::Error postSubBuffer(const gl::Context *context,
                                       EGLint x,
                                       EGLint y,
                                       EGLint width,
                                       EGLint height) = 0;
      virtual egl::Error setPresentationTime(EGLnsecsANDROID time);
      virtual egl::Error querySurfacePointerANGLE(EGLint attribute, void **value)               = 0;
      virtual egl::Error bindTexImage(const gl::Context *context,
                                      gl::Texture *texture,
                                      EGLint buffer)                                            = 0;
      virtual egl::Error releaseTexImage(const gl::Context *context, EGLint buffer)             = 0;
      virtual egl::Error getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc) = 0;
      virtual egl::Error getMscRate(EGLint *numerator, EGLint *denominator)                     = 0;
      virtual void setSwapInterval(EGLint interval)                                             = 0;
      virtual void setFixedWidth(EGLint width);
      virtual void setFixedHeight(EGLint height);
  
      // width and height can change with client window resizing
      virtual EGLint getWidth() const  = 0;
      virtual EGLint getHeight() const = 0;
      // Note: windows cannot be resized on Android.  The approach requires
      // calling vkGetPhysicalDeviceSurfaceCapabilitiesKHR.  However, that is
      // expensive; and there are troublesome timing issues for other parts of
      // ANGLE (which cause test failures and crashes).  Therefore, a
      // special-Android-only path is created just for the querying of EGL_WIDTH
      // and EGL_HEIGHT.
      // https://issuetracker.google.com/issues/153329980
      virtual egl::Error getUserWidth(const egl::Display *display, EGLint *value) const;
      virtual egl::Error getUserHeight(const egl::Display *display, EGLint *value) const;
  
      virtual EGLint isPostSubBufferSupported() const = 0;
      virtual EGLint getSwapBehavior() const          = 0;
  
      // Used to query color format from pbuffers created from D3D textures.
      virtual const angle::Format *getD3DTextureColorFormat() const;
  
      // EGL_ANDROID_get_frame_timestamps
      virtual void setTimestampsEnabled(bool enabled);
      virtual egl::SupportedCompositorTimings getSupportedCompositorTimings() const;
      virtual egl::Error getCompositorTiming(EGLint numTimestamps,
                                             const EGLint *names,
                                             EGLnsecsANDROID *values) const;
      virtual egl::Error getNextFrameId(EGLuint64KHR *frameId) const;
      virtual egl::SupportedTimestamps getSupportedTimestamps() const;
      virtual egl::Error getFrameTimestamps(EGLuint64KHR frameId,
                                            EGLint numTimestamps,
                                            const EGLint *timestamps,
                                            EGLnsecsANDROID *values) const;
      virtual egl::Error getBufferAge(const gl::Context *context, EGLint *age);
  
      // EGL_KHR_lock_surface3
      virtual egl::Error lockSurface(const egl::Display *display,
                                     EGLint usageHint,
                                     bool preservePixels,
                                     uint8_t **bufferPtrOut,
                                     EGLint *bufferPitchOut);
      virtual egl::Error unlockSurface(const egl::Display *display, bool preservePixels);
      virtual EGLint origin() const;
  
      virtual egl::Error setRenderBuffer(EGLint renderBuffer);
  
    protected:
      const egl::SurfaceState &mState;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_SURFACEIMPL_H_
  

Download