kc3-lang/angle/src/libANGLE/renderer/gl/glx/DisplayGLX.h

• Show log

  Commit

• Hash : e1ff28d4
  Author :
  Date : 2021-03-12T13:35:42
  

  GLX: Always call XSync on creation/destruction of WindowSurfaces
  
  ANGLE was checking that it had opened the connection  before calling
  XSync upon initialization. However, clients may pass in a connection
  and ANGLE must sync after creating a GLXWindow with the connection.
  This wasn't happening and was causing issues in Chrome.
  
  Bug: chromium:1172803
  Change-Id: Ieb2cbfaa226f6d066030f42d8e25b1d9c34779f7
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757507
  Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/renderer/gl/glx/DisplayGLX.h

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // DisplayGLX.h: GLX implementation of egl::Display
  
  #ifndef LIBANGLE_RENDERER_GL_GLX_DISPLAYGLX_H_
  #define LIBANGLE_RENDERER_GL_GLX_DISPLAYGLX_H_
  
  #include <string>
  #include <thread>
  #include <vector>
  
  #include "common/Optional.h"
  #include "libANGLE/renderer/gl/DisplayGL.h"
  #include "libANGLE/renderer/gl/RendererGL.h"
  #include "libANGLE/renderer/gl/glx/FunctionsGLX.h"
  
  namespace rx
  {
  
  class FunctionsGLX;
  class WorkerContext;
  
  struct SwapControlData;
  
  class DisplayGLX : public DisplayGL
  {
    public:
      DisplayGLX(const egl::DisplayState &state);
      ~DisplayGLX() override;
  
      egl::Error initialize(egl::Display *display) override;
      void terminate() override;
  
      egl::Error makeCurrent(egl::Display *display,
                             egl::Surface *drawSurface,
                             egl::Surface *readSurface,
                             gl::Context *context) override;
  
      SurfaceImpl *createWindowSurface(const egl::SurfaceState &state,
                                       EGLNativeWindowType window,
                                       const egl::AttributeMap &attribs) override;
      SurfaceImpl *createPbufferSurface(const egl::SurfaceState &state,
                                        const egl::AttributeMap &attribs) override;
      SurfaceImpl *createPbufferFromClientBuffer(const egl::SurfaceState &state,
                                                 EGLenum buftype,
                                                 EGLClientBuffer clientBuffer,
                                                 const egl::AttributeMap &attribs) override;
      SurfaceImpl *createPixmapSurface(const egl::SurfaceState &state,
                                       NativePixmapType nativePixmap,
                                       const egl::AttributeMap &attribs) override;
  
      egl::Error validatePixmap(const egl::Config *config,
                                EGLNativePixmapType pixmap,
                                const egl::AttributeMap &attributes) const override;
  
      ContextImpl *createContext(const gl::State &state,
                                 gl::ErrorSet *errorSet,
                                 const egl::Config *configuration,
                                 const gl::Context *shareContext,
                                 const egl::AttributeMap &attribs) override;
  
      egl::ConfigSet generateConfigs() override;
  
      bool testDeviceLost() override;
      egl::Error restoreLostDevice(const egl::Display *display) override;
  
      bool isValidNativeWindow(EGLNativeWindowType window) const override;
  
      egl::Error waitClient(const gl::Context *context) override;
      egl::Error waitNative(const gl::Context *context, EGLint engine) override;
  
      gl::Version getMaxSupportedESVersion() const override;
  
      // Synchronizes with the X server.
      // Calling this is required at the end of every functions that does buffered
      // X calls (not for glX calls) otherwise there might be race conditions
      // between the application's display and ANGLE's one.
      // Calling this only syncs if ANGLE opened the display, or if alwaysSync
      // is true.
      void syncXCommands(bool alwaysSync) const;
  
      // Depending on the supported GLX extension, swap interval can be set
      // globally or per drawable. This function will make sure the drawable's
      // swap interval is the one required so that the subsequent swapBuffers
      // acts as expected.
      void setSwapInterval(glx::Drawable drawable, SwapControlData *data);
  
      bool isWindowVisualIdSpecified() const;
      bool isMatchingWindowVisualId(unsigned long visualId) const;
  
      WorkerContext *createWorkerContext(std::string *infoLog);
  
      void initializeFrontendFeatures(angle::FrontendFeatures *features) const override;
  
      void populateFeatureList(angle::FeatureList *features) override;
  
      RendererGL *getRenderer() const override;
  
    private:
      egl::Error initializeContext(glx::FBConfig config,
                                   const egl::AttributeMap &eglAttributes,
                                   glx::Context *context);
  
      void generateExtensions(egl::DisplayExtensions *outExtensions) const override;
      void generateCaps(egl::Caps *outCaps) const override;
  
      egl::Error makeCurrentSurfaceless(gl::Context *context) override;
  
      int getGLXFBConfigAttrib(glx::FBConfig config, int attrib) const;
      egl::Error createContextAttribs(glx::FBConfig,
                                      const Optional<gl::Version> &version,
                                      int profileMask,
                                      glx::Context *context);
  
      std::shared_ptr<RendererGL> mRenderer;
  
      std::map<int, glx::FBConfig> configIdToGLXConfig;
  
      EGLint mRequestedVisual;
      glx::FBConfig mContextConfig;
      std::vector<int> mAttribs;
      XVisualInfo *mVisuals;
      glx::Context mContext;
      glx::Context mSharedContext;
      angle::HashMap<std::thread::id, glx::Context> mCurrentNativeContexts;
  
      // A pbuffer the context is current on during ANGLE initialization
      glx::Pbuffer mInitPbuffer;
  
      std::vector<glx::Pbuffer> mWorkerPbufferPool;
  
      bool mUsesNewXDisplay;
      bool mIsMesa;
      bool mHasMultisample;
      bool mHasARBCreateContext;
      bool mHasARBCreateContextProfile;
      bool mHasARBCreateContextRobustness;
      bool mHasEXTCreateContextES2Profile;
      bool mHasNVRobustnessVideoMemoryPurge;
  
      enum class SwapControl
      {
          Absent,
          EXT,
          Mesa,
          SGI,
      };
      SwapControl mSwapControl;
      int mMinSwapInterval;
      int mMaxSwapInterval;
      int mCurrentSwapInterval;
  
      glx::Drawable mCurrentDrawable;
  
      FunctionsGLX mGLX;
      Display *mXDisplay;
      egl::Display *mEGLDisplay;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_GL_GLX_DISPLAYGLX_H_
  

Download