kc3-lang/angle/src/libANGLE/renderer/TextureImpl.h

• Show log

  Commit

• Hash : e8528d89
  Author :
  Date : 2016-05-16T17:50:52
  

  Fix determining texture mipmap completeness
  
  The code didn't previously take base level properly into account
  when determining how many levels to check when checking for texture
  completeness.
  
  The code is refactored so that the "q" value in spec, that is the
  maximum mipmap level for determining completeness, can be queried from
  TextureState. This value is used now for checking completeness.
  
  This requires moving ImageDescs under TextureState. Functions that
  operate on the ImageDesc array are also moved from Texture to
  TextureState. TextureState members are also renamed to start with the
  "m" prefix and made private.
  
  Also handle levels outside the base/max level range consistently in
  eglCreateImageKHR validation. We interpret the spec so that if the
  level used for the EGL image is not a part of the texture levels that
  affect texture completeness, an error is generated.
  
  BUG=angleproject:596
  TEST=angle_end2end_tests
  
  Change-Id: I038ef24aa83e0a6905ca3c0bbada5989eecb00d9
  Reviewed-on: https://chromium-review.googlesource.com/344880
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/libANGLE/renderer/TextureImpl.h

• //
  // Copyright 2014 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // TextureImpl.h: Defines the abstract rx::TextureImpl classes.
  
  #ifndef LIBANGLE_RENDERER_TEXTUREIMPL_H_
  #define LIBANGLE_RENDERER_TEXTUREIMPL_H_
  
  #include <stdint.h>
  
  #include "angle_gl.h"
  #include "common/angleutils.h"
  #include "libANGLE/Error.h"
  #include "libANGLE/FramebufferAttachment.h"
  #include "libANGLE/ImageIndex.h"
  #include "libANGLE/Stream.h"
  
  namespace egl
  {
  class Surface;
  class Image;
  }
  
  namespace gl
  {
  struct Box;
  struct Extents;
  struct Offset;
  struct Rectangle;
  class Framebuffer;
  struct PixelUnpackState;
  struct TextureState;
  }
  
  namespace rx
  {
  
  class TextureImpl : public FramebufferAttachmentObjectImpl
  {
    public:
      TextureImpl(const gl::TextureState &state) : mState(state) {}
      virtual ~TextureImpl() {}
  
      virtual gl::Error setImage(GLenum target, size_t level, GLenum internalFormat, const gl::Extents &size, GLenum format, GLenum type,
                                 const gl::PixelUnpackState &unpack, const uint8_t *pixels) = 0;
      virtual gl::Error setSubImage(GLenum target, size_t level, const gl::Box &area, GLenum format, GLenum type,
                                    const gl::PixelUnpackState &unpack, const uint8_t *pixels) = 0;
  
      virtual gl::Error setCompressedImage(GLenum target, size_t level, GLenum internalFormat, const gl::Extents &size,
                                           const gl::PixelUnpackState &unpack, size_t imageSize, const uint8_t *pixels) = 0;
      virtual gl::Error setCompressedSubImage(GLenum target, size_t level, const gl::Box &area, GLenum format,
                                              const gl::PixelUnpackState &unpack, size_t imageSize, const uint8_t *pixels) = 0;
  
      virtual gl::Error copyImage(GLenum target, size_t level, const gl::Rectangle &sourceArea, GLenum internalFormat,
                                  const gl::Framebuffer *source) = 0;
      virtual gl::Error copySubImage(GLenum target, size_t level, const gl::Offset &destOffset, const gl::Rectangle &sourceArea,
                                     const gl::Framebuffer *source) = 0;
  
      virtual gl::Error setStorage(GLenum target, size_t levels, GLenum internalFormat, const gl::Extents &size) = 0;
  
      virtual gl::Error setEGLImageTarget(GLenum target, egl::Image *image) = 0;
  
      virtual gl::Error setImageExternal(GLenum target,
                                         egl::Stream *stream,
                                         const egl::Stream::GLTextureDescription &desc) = 0;
  
      virtual gl::Error generateMipmaps() = 0;
  
      virtual void setBaseLevel(GLuint baseLevel) = 0;
  
      virtual void bindTexImage(egl::Surface *surface) = 0;
      virtual void releaseTexImage() = 0;
  
    protected:
      const gl::TextureState &mState;
  };
  
  }
  
  #endif // LIBANGLE_RENDERER_TEXTUREIMPL_H_
  

Download