Hash :
436e32ae
Author :
Date :
2016-01-15T15:53:12
GLX backend: check for child window resizes on eglWaitNative This is the standard way, if not often used, for application to notify the driver of window size changes. Chromium uses it to resize when it is done rendering and swapping so that drivers do not clobber the backbuffer. This fixes black flickering appearing when resizing the Chromium windows with --use-gl=angle. BUG=angleproject:1281 Change-Id: Ic76f3c3ef453eae07eb59122135290411f86764d Reviewed-on: https://chromium-review.googlesource.com/322390 Reviewed-by: Jamie Madill <jmadill@chromium.org> Tryjob-Request: Corentin Wallez <cwallez@chromium.org> Tested-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142
//
// Copyright (c) 2015 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// PbufferSurfaceGLX.cpp: GLX implementation of egl::Surface for PBuffers
#include "libANGLE/renderer/gl/glx/PbufferSurfaceGLX.h"
#include "common/debug.h"
#include "libANGLE/renderer/gl/glx/DisplayGLX.h"
#include "libANGLE/renderer/gl/glx/FunctionsGLX.h"
namespace rx
{
PbufferSurfaceGLX::PbufferSurfaceGLX(RendererGL *renderer,
EGLint width,
EGLint height,
bool largest,
const FunctionsGLX &glx,
glx::Context context,
glx::FBConfig fbConfig)
: SurfaceGLX(renderer),
mWidth(width),
mHeight(height),
mLargest(largest),
mGLX(glx),
mContext(context),
mFBConfig(fbConfig),
mPbuffer(0)
{
}
PbufferSurfaceGLX::~PbufferSurfaceGLX()
{
if (mPbuffer)
{
mGLX.destroyPbuffer(mPbuffer);
}
}
egl::Error PbufferSurfaceGLX::initialize()
{
// Avoid creating 0-sized PBuffers as it fails on the Intel Mesa driver
// as commented on https://bugs.freedesktop.org/show_bug.cgi?id=38869 so we
// use (w, 1) or (1, h) instead.
int width = std::max(1, static_cast<int>(mWidth));
int height = std::max(1, static_cast<int>(mHeight));
const int attribs[] =
{
GLX_PBUFFER_WIDTH, width,
GLX_PBUFFER_HEIGHT, height,
GLX_LARGEST_PBUFFER, mLargest,
None
};
mPbuffer = mGLX.createPbuffer(mFBConfig, attribs);
if (!mPbuffer)
{
return egl::Error(EGL_BAD_ALLOC, "Failed to create a native GLX pbuffer.");
}
if (mLargest)
{
mGLX.queryDrawable(mPbuffer, GLX_WIDTH, &mWidth);
mGLX.queryDrawable(mPbuffer, GLX_HEIGHT, &mHeight);
}
return egl::Error(EGL_SUCCESS);
}
egl::Error PbufferSurfaceGLX::makeCurrent()
{
if (mGLX.makeCurrent(mPbuffer, mContext) != True)
{
return egl::Error(EGL_BAD_DISPLAY);
}
return egl::Error(EGL_SUCCESS);
}
egl::Error PbufferSurfaceGLX::swap()
{
return egl::Error(EGL_SUCCESS);
}
egl::Error PbufferSurfaceGLX::postSubBuffer(EGLint x, EGLint y, EGLint width, EGLint height)
{
return egl::Error(EGL_SUCCESS);
}
egl::Error PbufferSurfaceGLX::querySurfacePointerANGLE(EGLint attribute, void **value)
{
UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS);
}
egl::Error PbufferSurfaceGLX::bindTexImage(gl::Texture *texture, EGLint buffer)
{
UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS);
}
egl::Error PbufferSurfaceGLX::releaseTexImage(EGLint buffer)
{
UNIMPLEMENTED();
return egl::Error(EGL_SUCCESS);
}
void PbufferSurfaceGLX::setSwapInterval(EGLint interval)
{
}
EGLint PbufferSurfaceGLX::getWidth() const
{
return mWidth;
}
EGLint PbufferSurfaceGLX::getHeight() const
{
return mHeight;
}
EGLint PbufferSurfaceGLX::isPostSubBufferSupported() const
{
UNIMPLEMENTED();
return EGL_FALSE;
}
EGLint PbufferSurfaceGLX::getSwapBehavior() const
{
return EGL_BUFFER_PRESERVED;
}
egl::Error PbufferSurfaceGLX::checkForResize()
{
// The size of pbuffers never change
return egl::Error(EGL_SUCCESS);
}
}