-
Show log
Commit
-
Hash : d71dc819
Author :
Date : 2021-09-22T16:01:06
Fixes for RowMajor test failures row_major matrices get translated to column major matrices and the expressions rewritten. To do this temporary variables that contain the column and row index expressions are moved to separte statements before the matrix expression itself. When this happens it breaks side effects and short circuits in the expression. The solution is to call SeparateCompoundExpressions before calling RewriteRowMajorMatrices. Bug: angleproject:6386 Change-Id: I4d819ade959e2a875495f62733e11d86560d3fab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3177337 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Gregg Tavares <gman@chromium.org>
-
Files
- BUILD.gn
- OWNERS
- angle_deqp_tests_main.cpp
- angle_end2end_tests.gni
- angle_end2end_tests_expectations.txt
- angle_end2end_tests_main.cpp
- angle_generic_tests_main.cpp
- angle_perftests.gni
- angle_perftests_main.cpp
- angle_system_info_tests_main.cpp
- angle_unittest_main.cpp
- angle_unittests.gni
- angle_unittests_utils.h
- angle_white_box_tests.gni
- angle_white_box_tests_main.cpp
- capture_replay_tests.py
- capture_replay_tests/
- compiler_tests/
- deqp_support/
- egl_tests/
- gl_tests/
- gles1_conformance_tests/
- gles_conformance_tests/
- perf_tests/
- preprocessor_tests/
- restricted_traces/
- run_perf_tests.py
- skia_gold/
- test_expectations/
- test_utils/
- util_tests/
