kc3-lang/angle/src/common/spirv/angle_spirv_utils.cpp

• Show log

  Commit

• Hash : 159f3e62
  Author :
  Date : 2022-09-28T23:34:06
  

  Vulkan: Make sure spirv-val doesn't generate friendly names
  
  This makes it harder to debug as the disassembly uses raw ids.
  Additionally, the generation of friendly names itself is costly.
  
  On GLES1's TexCombine test, this change reduces run time by ~7%.
  
  Bug: angleproject:6644
  Change-Id: I47e6752cd709733c49915dd374c18f5438c0bfdf
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3926038
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Yuxin Hu <yuxinhu@google.com>
  Reviewed-by: Cody Northrop <cnorthrop@google.com>
  

Download

• src/common/spirv/angle_spirv_utils.cpp

• // Copyright 2021 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // spirv_types.cpp:
  //   Helper SPIR-V functions.
  
  #include "spirv_types.h"
  
  // SPIR-V tools include for AST validation.
  #include <spirv-tools/libspirv.hpp>
  
  namespace angle
  {
  namespace spirv
  {
  
  #if defined(ANGLE_ENABLE_ASSERTS)
  namespace
  {
  void ValidateSpirvMessage(spv_message_level_t level,
                            const char *source,
                            const spv_position_t &position,
                            const char *message)
  {
      WARN() << "Level" << level << ": " << message;
  }
  }  // anonymous namespace
  
  bool Validate(const Blob &blob)
  {
      spvtools::SpirvTools spirvTools(SPV_ENV_VULKAN_1_1);
  
      spvtools::ValidatorOptions options;
      options.SetFriendlyNames(false);
  
      spirvTools.SetMessageConsumer(ValidateSpirvMessage);
      const bool result = spirvTools.Validate(blob.data(), blob.size(), options);
  
      if (!result)
      {
          std::string readableSpirv;
          spirvTools.Disassemble(blob, &readableSpirv, 0);
          WARN() << "Invalid SPIR-V:\n" << readableSpirv;
      }
  
      return result;
  }
  
  void Print(const Blob &blob)
  {
      spvtools::SpirvTools spirvTools(SPV_ENV_VULKAN_1_1);
      std::string readableSpirv;
      spirvTools.Disassemble(blob, &readableSpirv, 0);
      INFO() << "Dissembly SPIRV: " << readableSpirv.c_str();
  }
  #else   // ANGLE_ENABLE_ASSERTS
  bool Validate(const Blob &blob)
  {
      // Placeholder implementation since this is only used inside an ASSERT().
      // Return false to indicate an error in case this is ever accidentally used somewhere else.
      return false;
  }
  #endif  // ANGLE_ENABLE_ASSERTS
  
  }  // namespace spirv
  }  // namespace angle
  

Download