-
Show log
Commit
-
Hash : c4a96d67
Author :
Date : 2015-07-23T17:37:39
Names of built-in functions cannot be redeclared as functions With ESSL 3.00, names of built-in functions cannot be redeclared as functions, and therefore an error needs to be generated if a built-in function is overloaded. This is fixed by inserting unmangled built-ins into a special set in the symbol table and checking if function declarations match any of the built-ins in the set. The regular symbol table structures can't be used for storing the unmangled names because that interferes with name hashing in OutputGLSL. Credit goes to Arun Patole, apatole@nvidia.com for initially investigating this issue and developing the first version of the patch. BUG=angleproject:1066 TEST=angle_unittests, dEQP-GLES3.functional.shaders.functions.invalid.overload_builtin_function* (2 tests started passing with this change) Change-Id: I28c8325f5a3a8f4a97226b0dfdbb9762724fa609 Reviewed-on: https://chromium-review.googlesource.com/328994 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
-
Files
- API_test.cpp
- BuiltInFunctionEmulator_test.cpp
- CollectVariables_test.cpp
- ConstantFolding_test.cpp
- DebugShaderPrecision_test.cpp
- EXT_blend_func_extended_test.cpp
- ExpressionLimit_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- IntermNode_test.cpp
- MalformedShader_test.cpp
- NV_draw_buffers_test.cpp
- Pack_Unpack_test.cpp
- PruneUnusedFunctions_test.cpp
- RecordConstantPrecision_test.cpp
- RemovePow_test.cpp
- ShCompile_test.cpp
- ShaderExtension_test.cpp
- ShaderVariable_test.cpp
- TypeTracking_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
