kc3-lang/angle/src/libANGLE/CLSampler.cpp

• Show log

  Commit

• Hash : 25390156
  Author :
  Date : 2025-08-21T00:13:19
  

  Suppress unsafe buffers on a file-by-file basis in src/ [1 of N]
  
  In this CL, we suppress many files but stop short of actually
  enabling the warning by not removing the line from the
  unsafe_buffers_paths.txt file. That will happen in a follow-on
  CL, along with resolving any stragglers missed here.
  
  This is mostly a manual change so as to familiarize myself with
  the kinds of issues faced by the Angle codebase when applying buffer
  safety warnings.
  
  -- Re-generate affected hashes.
  -- Clang-format applied to all changed files.
  -- Add a few missing .reserve() calls to vectors as noticed.
  -- Fix some mismatches between file names and header comments.
  -- Be more consistent with header comment format (blank lines and
     trailing //-only lines when a filename comment adjoins license
     boilerplate).
  
  Bug: b/436880895
  Change-Id: I3bde5cc2059acbe8345057289214f1a26f1c34aa
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6869022
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  

Download

• src/libANGLE/CLSampler.cpp

• //
  // Copyright 2021 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // CLSampler.cpp: Implements the cl::Sampler class.
  //
  
  #ifdef UNSAFE_BUFFERS_BUILD
  #    pragma allow_unsafe_buffers
  #endif
  
  #include "libANGLE/CLSampler.h"
  
  #include "libANGLE/CLContext.h"
  #include "libANGLE/cl_utils.h"
  
  #include <cstring>
  
  namespace cl
  {
  
  angle::Result Sampler::getInfo(SamplerInfo name,
                                 size_t valueSize,
                                 void *value,
                                 size_t *valueSizeRet) const
  {
      static_assert(std::is_same<cl_uint, cl_addressing_mode>::value &&
                        std::is_same<cl_uint, cl_filter_mode>::value,
                    "OpenCL type mismatch");
  
      cl_uint valUInt       = 0u;
      void *valPointer      = nullptr;
      const void *copyValue = nullptr;
      size_t copySize       = 0u;
  
      switch (name)
      {
          case SamplerInfo::ReferenceCount:
              valUInt   = getRefCount();
              copyValue = &valUInt;
              copySize  = sizeof(valUInt);
              break;
          case SamplerInfo::Context:
              valPointer = mContext->getNative();
              copyValue  = &valPointer;
              copySize   = sizeof(valPointer);
              break;
          case SamplerInfo::NormalizedCoords:
              copyValue = &mNormalizedCoords;
              copySize  = sizeof(mNormalizedCoords);
              break;
          case SamplerInfo::AddressingMode:
              valUInt   = ToCLenum(mAddressingMode);
              copyValue = &valUInt;
              copySize  = sizeof(valUInt);
              break;
          case SamplerInfo::FilterMode:
              valUInt   = ToCLenum(mFilterMode);
              copyValue = &valUInt;
              copySize  = sizeof(valUInt);
              break;
          case SamplerInfo::Properties:
              copyValue = mProperties.data();
              copySize  = mProperties.size() * sizeof(decltype(mProperties)::value_type);
              break;
          default:
              ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
      }
  
      if (value != nullptr)
      {
          // CL_INVALID_VALUE if size in bytes specified by param_value_size is < size of return type
          // as described in the Sampler Object Queries table and param_value is not NULL.
          if (valueSize < copySize)
          {
              ANGLE_CL_RETURN_ERROR(CL_INVALID_VALUE);
          }
          if (copyValue != nullptr)
          {
              std::memcpy(value, copyValue, copySize);
          }
      }
      if (valueSizeRet != nullptr)
      {
          *valueSizeRet = copySize;
      }
      return angle::Result::Continue;
  }
  
  Sampler::~Sampler() = default;
  
  Sampler::Sampler(Context &context,
                   PropArray &&properties,
                   cl_bool normalizedCoords,
                   AddressingMode addressingMode,
                   FilterMode filterMode)
      : mContext(&context),
        mProperties(std::move(properties)),
        mNormalizedCoords(normalizedCoords),
        mAddressingMode(addressingMode),
        mFilterMode(filterMode),
        mImpl(nullptr)
  {
      ANGLE_CL_IMPL_TRY(context.getImpl().createSampler(*this, &mImpl));
  }
  
  }  // namespace cl
  

Download