kc3-lang/angle/src/libANGLE/EGLSync.cpp

• Show log

  Commit

• Hash : 774bca93
  Author :
  Date : 2025-10-08T18:41:13
  

  [metal] Add commands scheduled sync object
  
  We need a thread-safe way to wait for ANGLE Metal command buffers to be
  scheduled for IOSurface synchronization with DrDC + Graphite on Mac.
  The existing eglWaitUntilWorkScheduledANGLE API isn't thread-safe as it
  reaches into ContextMtl innards to flush the command buffer.
  
  This CL adds the EGL_ANGLE_metal_commands_scheduled_sync extension which
  introduces a EGL_SYNC_METAL_COMMANDS_SCHEDULED_ANGLE sync object type.
  This sync object is signaled when pending Metal commands are scheduled
  to run on the GPU (MTLCommandBufferStatusScheduled). These sync objects
  are thread-safe - eglClientWaitSync() can be called on any thread even
  without a current context which is needed for DrDC + Graphite on Mac.
  
  Bug: chromium:444702048
  Change-Id: Ia13b352385a6fefaa026526ef74f6e596a6a6964
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7027996
  Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
  Reviewed-by: Quyen Le <lehoangquyen@chromium.org>
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
  

Download

• src/libANGLE/EGLSync.cpp

• //
  // Copyright 2002 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // EGLSync.cpp: Implements the egl::Sync class.
  
  #include "libANGLE/EGLSync.h"
  
  #include "angle_gl.h"
  
  #include "common/utilities.h"
  #include "libANGLE/renderer/EGLImplFactory.h"
  #include "libANGLE/renderer/EGLReusableSync.h"
  #include "libANGLE/renderer/EGLSyncImpl.h"
  
  namespace egl
  {
  
  Sync::Sync(rx::EGLImplFactory *factory, EGLenum type)
      : mLabel(nullptr), mId({0}), mType(type), mCondition(0), mNativeFenceFD(0)
  {
      switch (mType)
      {
          case EGL_SYNC_FENCE:
          case EGL_SYNC_GLOBAL_FENCE_ANGLE:
          case EGL_SYNC_NATIVE_FENCE_ANDROID:
          case EGL_SYNC_METAL_SHARED_EVENT_ANGLE:
          case EGL_SYNC_METAL_COMMANDS_SCHEDULED_ANGLE:
              mFence = std::unique_ptr<rx::EGLSyncImpl>(factory->createSync());
              break;
  
          case EGL_SYNC_REUSABLE_KHR:
              mFence = std::unique_ptr<rx::EGLSyncImpl>(new rx::ReusableSync());
              break;
  
          default:
              UNREACHABLE();
      }
  }
  
  void Sync::onDestroy(const Display *display)
  {
      ASSERT(mFence);
      mFence->onDestroy(display);
  }
  
  Sync::~Sync() {}
  
  Error Sync::initialize(const Display *display,
                         const gl::Context *context,
                         const SyncID &id,
                         const AttributeMap &attribs)
  {
      mId           = id;
      mAttributeMap = attribs;
      mNativeFenceFD =
          attribs.getAsInt(EGL_SYNC_NATIVE_FENCE_FD_ANDROID, EGL_NO_NATIVE_FENCE_FD_ANDROID);
      mCondition = EGL_SYNC_PRIOR_COMMANDS_COMPLETE_KHR;
  
      // Per extension spec: Signaling Condition.
      // "If the EGL_SYNC_NATIVE_FENCE_FD_ANDROID attribute is not
      // EGL_NO_NATIVE_FENCE_FD_ANDROID then the EGL_SYNC_CONDITION_KHR attribute
      // is set to EGL_SYNC_NATIVE_FENCE_SIGNALED_ANDROID and the EGL_SYNC_STATUS_KHR
      // attribute is set to reflect the signal status of the native fence object.
      if ((mType == EGL_SYNC_NATIVE_FENCE_ANDROID) &&
          (mNativeFenceFD != EGL_NO_NATIVE_FENCE_FD_ANDROID))
      {
          mCondition = EGL_SYNC_NATIVE_FENCE_SIGNALED_ANDROID;
      }
  
      // Per extension spec: Signaling Condition.
      if (mType == EGL_SYNC_METAL_SHARED_EVENT_ANGLE)
      {
          mCondition = attribs.getAsInt(EGL_SYNC_CONDITION, EGL_SYNC_PRIOR_COMMANDS_COMPLETE_KHR);
      }
  
      return mFence->initialize(display, context, mType, mAttributeMap);
  }
  
  void Sync::setLabel(EGLLabelKHR label)
  {
      mLabel = label;
  }
  
  EGLLabelKHR Sync::getLabel() const
  {
      return mLabel;
  }
  
  Error Sync::clientWait(const Display *display,
                         const gl::Context *context,
                         EGLint flags,
                         EGLTime timeout,
                         EGLint *outResult)
  {
      return mFence->clientWait(display, context, flags, timeout, outResult);
  }
  
  Error Sync::serverWait(const Display *display, const gl::Context *context, EGLint flags)
  {
      return mFence->serverWait(display, context, flags);
  }
  
  Error Sync::signal(const Display *display, const gl::Context *context, EGLint mode)
  {
      return mFence->signal(display, context, mode);
  }
  
  Error Sync::getStatus(const Display *display, EGLint *outStatus) const
  {
      return mFence->getStatus(display, outStatus);
  }
  
  Error Sync::copyMetalSharedEventANGLE(const Display *display, void **result) const
  {
      return mFence->copyMetalSharedEventANGLE(display, result);
  }
  
  Error Sync::dupNativeFenceFD(const Display *display, EGLint *result) const
  {
      return mFence->dupNativeFenceFD(display, result);
  }
  
  }  // namespace egl
  

Download