kc3-lang/angle/src/libANGLE/Sampler.h

Branch : - branch - main - tag -

• Show log

  Commit

• Author : James Darpinian
  Date : 2019-03-13 19:35:36
  Hash : 5fd08af4
  Message : Sampler state overrides texture state if set The new validation added in http://crbug.com/809237 failed to consider that sampler object state overrides texture object state if a sampler object is bound. State caching makes this complicated to fix. Fixes WebGL conformance test incompatible-texture-type-for-sampler.html https://github.com/KhronosGroup/WebGL/pull/2823 Bug: 940080, 809237 Change-Id: I26b0fb35c5630c36248edae80f0298a0cb7e14b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1522364 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>

• src/libANGLE/Sampler.h

• //
  // Copyright (c) 2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // Sampler.h : Defines the Sampler class, which represents a GLES 3
  // sampler object. Sampler objects store some state needed to sample textures.
  
  #ifndef LIBANGLE_SAMPLER_H_
  #define LIBANGLE_SAMPLER_H_
  
  #include "libANGLE/Debug.h"
  #include "libANGLE/Observer.h"
  #include "libANGLE/RefCountObject.h"
  #include "libANGLE/angletypes.h"
  
  namespace rx
  {
  class GLImplFactory;
  class SamplerImpl;
  }  // namespace rx
  
  namespace gl
  {
  
  class Sampler final : public RefCountObject, public LabeledObject, public angle::Subject
  {
    public:
      Sampler(rx::GLImplFactory *factory, GLuint id);
      ~Sampler() override;
  
      void onDestroy(const Context *context) override;
  
      void setLabel(const Context *context, const std::string &label) override;
      const std::string &getLabel() const override;
  
      void setMinFilter(const Context *context, GLenum minFilter);
      GLenum getMinFilter() const;
  
      void setMagFilter(const Context *context, GLenum magFilter);
      GLenum getMagFilter() const;
  
      void setWrapS(const Context *context, GLenum wrapS);
      GLenum getWrapS() const;
  
      void setWrapT(const Context *context, GLenum wrapT);
      GLenum getWrapT() const;
  
      void setWrapR(const Context *context, GLenum wrapR);
      GLenum getWrapR() const;
  
      void setMaxAnisotropy(const Context *context, float maxAnisotropy);
      float getMaxAnisotropy() const;
  
      void setMinLod(const Context *context, GLfloat minLod);
      GLfloat getMinLod() const;
  
      void setMaxLod(const Context *context, GLfloat maxLod);
      GLfloat getMaxLod() const;
  
      void setCompareMode(const Context *context, GLenum compareMode);
      GLenum getCompareMode() const;
  
      void setCompareFunc(const Context *context, GLenum compareFunc);
      GLenum getCompareFunc() const;
  
      void setSRGBDecode(const Context *context, GLenum sRGBDecode);
      GLenum getSRGBDecode() const;
  
      void setBorderColor(const Context *context, const ColorGeneric &color);
      const ColorGeneric &getBorderColor() const;
  
      const SamplerState &getSamplerState() const;
  
      rx::SamplerImpl *getImplementation() const;
  
      void syncState(const Context *context);
  
    private:
      SamplerState mState;
      rx::SamplerImpl *mImpl;
  
      std::string mLabel;
  };
  
  }  // namespace gl
  
  #endif  // LIBANGLE_SAMPLER_H_