kc3-lang/angle/src/libANGLE/renderer/gl/ShaderGL.h

• Show log

  Commit

• Hash : e7557744
  Author :
  Date : 2017-06-01T13:09:57
  

  WebGL compatibility: remove UB for draw buffers in the GL backend.
  
  WebGL adds two rules:
   - Fragment outputs declared but not written to should default to black.
   - FBO attachments for outputs not declared in the shader should not be
  written to (it is UB in OpenGL ES).
  
  Fix the first one by using the SH_INIT_OUTPUT_VARIABLES compiler
  options, and the second one by messing with glDrawBuffers so that the
  enabled draw buffers are always a subset of the ones declared by the
  shader.
  
  BUG=angleproject:2048
  
  Change-Id: I1d851c190959c1acfc3e41d837e6990aec1d4086
  Reviewed-on: https://chromium-review.googlesource.com/521682
  Commit-Queue: Corentin Wallez <cwallez@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Geoff Lang <geofflang@chromium.org>
  

Download

• src/libANGLE/renderer/gl/ShaderGL.h

• //
  // Copyright 2015 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  // ShaderGL.h: Defines the class interface for ShaderGL.
  
  #ifndef LIBANGLE_RENDERER_GL_SHADERGL_H_
  #define LIBANGLE_RENDERER_GL_SHADERGL_H_
  
  #include "libANGLE/renderer/ShaderImpl.h"
  
  namespace rx
  {
  class FunctionsGL;
  struct WorkaroundsGL;
  
  class ShaderGL : public ShaderImpl
  {
    public:
      ShaderGL(const gl::ShaderState &data,
               const FunctionsGL *functions,
               const WorkaroundsGL &workarounds,
               bool isWebGL);
      ~ShaderGL() override;
  
      // ShaderImpl implementation
      ShCompileOptions prepareSourceAndReturnOptions(std::stringstream *sourceStream,
                                                     std::string *sourcePath) override;
      bool postTranslateCompile(gl::Compiler *compiler, std::string *infoLog) override;
      std::string getDebugInfo() const override;
  
      GLuint getShaderID() const;
  
    private:
      const FunctionsGL *mFunctions;
      const WorkaroundsGL &mWorkarounds;
  
      GLuint mShaderID;
      bool mIsWebGL;
  };
  
  }
  
  #endif // LIBANGLE_RENDERER_GL_SHADERGL_H_
  

Download