Hash :
b5d548bb
Author :
Date :
2024-09-20T17:06:54
CL/Vulkan: Update map interface for CLMemoryVk Clean up the map interface of the CLMemoryVk to account for any offsets. Bug: angleproject:369724757 Change-Id: I12c7bf2f7f94cd7fbf57a8ee10748d2275a2ba70 Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5893956 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// CLMemoryVk.cpp: Implements the class methods for CLMemoryVk.
#include "libANGLE/renderer/vulkan/CLMemoryVk.h"
#include <cstdint>
#include "libANGLE/Error.h"
#include "libANGLE/renderer/vulkan/CLContextVk.h"
#include "libANGLE/renderer/vulkan/vk_renderer.h"
#include "libANGLE/CLBuffer.h"
#include "libANGLE/CLContext.h"
#include "libANGLE/CLMemory.h"
#include "libANGLE/cl_utils.h"
namespace rx
{
CLMemoryVk::CLMemoryVk(const cl::Memory &memory)
: CLMemoryImpl(memory),
mContext(&memory.getContext().getImpl<CLContextVk>()),
mRenderer(mContext->getRenderer()),
mMappedMemory(nullptr),
mMapCount(0),
mParent(nullptr)
{}
CLMemoryVk::~CLMemoryVk()
{
mContext->mAssociatedObjects->mMemories.erase(mMemory.getNative());
}
angle::Result CLMemoryVk::createSubBuffer(const cl::Buffer &buffer,
cl::MemFlags flags,
size_t size,
CLMemoryImpl::Ptr *subBufferOut)
{
UNIMPLEMENTED();
ANGLE_CL_RETURN_ERROR(CL_OUT_OF_RESOURCES);
}
VkBufferUsageFlags CLMemoryVk::getVkUsageFlags()
{
VkBufferUsageFlags usageFlags =
VK_BUFFER_USAGE_TRANSFER_SRC_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT;
if (mMemory.getFlags().isSet(CL_MEM_WRITE_ONLY))
{
usageFlags |= VK_BUFFER_USAGE_STORAGE_BUFFER_BIT;
}
else if (mMemory.getFlags().isSet(CL_MEM_READ_ONLY))
{
usageFlags |= VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT;
}
else
{
usageFlags |= VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_BUFFER_BIT;
}
return usageFlags;
}
VkMemoryPropertyFlags CLMemoryVk::getVkMemPropertyFlags()
{
// TODO: http://anglebug.com/42267018
VkMemoryPropertyFlags propFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
if (mMemory.getFlags().isSet(CL_MEM_USE_HOST_PTR | CL_MEM_ALLOC_HOST_PTR |
CL_MEM_COPY_HOST_PTR))
{
propFlags |= VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT;
}
return propFlags;
}
angle::Result CLMemoryVk::map(uint8_t *&ptrOut, size_t offset)
{
if (!isMapped())
{
ANGLE_TRY(mapImpl());
}
ptrOut = mMappedMemory + offset;
return angle::Result::Continue;
}
angle::Result CLMemoryVk::copyTo(void *dst, size_t srcOffset, size_t size)
{
uint8_t *src = nullptr;
ANGLE_TRY(map(src, srcOffset));
std::memcpy(dst, src, size);
unmap();
return angle::Result::Continue;
}
angle::Result CLMemoryVk::copyTo(CLMemoryVk *dst, size_t srcOffset, size_t dstOffset, size_t size)
{
uint8_t *dstPtr = nullptr;
ANGLE_TRY(dst->map(dstPtr, dstOffset));
ANGLE_TRY(copyTo(dstPtr, srcOffset, size));
dst->unmap();
return angle::Result::Continue;
}
angle::Result CLMemoryVk::copyFrom(const void *src, size_t srcOffset, size_t size)
{
uint8_t *dst = nullptr;
ANGLE_TRY(map(dst, srcOffset));
std::memcpy(dst, src, size);
unmap();
return angle::Result::Continue;
}
CLBufferVk::CLBufferVk(const cl::Buffer &buffer) : CLMemoryVk(buffer)
{
if (buffer.isSubBuffer())
{
mParent = &buffer.getParent()->getImpl<CLBufferVk>();
}
mDefaultBufferCreateInfo = {};
mDefaultBufferCreateInfo.sType = VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO;
mDefaultBufferCreateInfo.size = buffer.getSize();
mDefaultBufferCreateInfo.usage = getVkUsageFlags();
mDefaultBufferCreateInfo.sharingMode = VK_SHARING_MODE_EXCLUSIVE;
}
CLBufferVk::~CLBufferVk()
{
if (isMapped())
{
unmap();
}
mBuffer.destroy(mRenderer);
}
angle::Result CLBufferVk::createSubBuffer(const cl::Buffer &buffer,
cl::MemFlags flags,
size_t size,
CLMemoryImpl::Ptr *subBufferOut)
{
UNIMPLEMENTED();
ANGLE_CL_RETURN_ERROR(CL_OUT_OF_RESOURCES);
}
angle::Result CLBufferVk::create(void *hostPtr)
{
if (!isSubBuffer())
{
VkBufferCreateInfo createInfo = mDefaultBufferCreateInfo;
createInfo.size = getSize();
VkMemoryPropertyFlags memFlags = getVkMemPropertyFlags();
if (IsError(mBuffer.init(mContext, createInfo, memFlags)))
{
ANGLE_CL_RETURN_ERROR(CL_OUT_OF_RESOURCES);
}
if (mMemory.getFlags().isSet(CL_MEM_USE_HOST_PTR | CL_MEM_COPY_HOST_PTR))
{
ASSERT(hostPtr);
ANGLE_CL_IMPL_TRY_ERROR(setDataImpl(static_cast<uint8_t *>(hostPtr), getSize(), 0),
CL_OUT_OF_RESOURCES);
}
}
return angle::Result::Continue;
}
angle::Result CLBufferVk::mapImpl()
{
ASSERT(!isMapped());
if (isSubBuffer())
{
ANGLE_TRY(mParent->map(mMappedMemory, static_cast<size_t>(mBuffer.getOffset())));
return angle::Result::Continue;
}
ANGLE_TRY(mBuffer.map(mContext, &mMappedMemory));
return angle::Result::Continue;
}
void CLBufferVk::unmapImpl()
{
if (!isSubBuffer())
{
mBuffer.unmap(mRenderer);
}
mMappedMemory = nullptr;
}
angle::Result CLBufferVk::setDataImpl(const uint8_t *data, size_t size, size_t offset)
{
// buffer cannot be in use state
ASSERT(mBuffer.valid());
ASSERT(!isCurrentlyInUse());
ASSERT(size + offset <= getSize());
ASSERT(data != nullptr);
// Assuming host visible buffers for now
// TODO: http://anglebug.com/42267019
if (!mBuffer.isHostVisible())
{
UNIMPLEMENTED();
ANGLE_CL_RETURN_ERROR(CL_OUT_OF_RESOURCES);
}
uint8_t *mapPointer = nullptr;
ANGLE_TRY(mBuffer.mapWithOffset(mContext, &mapPointer, offset));
ASSERT(mapPointer != nullptr);
std::memcpy(mapPointer, data, size);
mBuffer.unmap(mRenderer);
return angle::Result::Continue;
}
bool CLBufferVk::isCurrentlyInUse() const
{
return !mRenderer->hasResourceUseFinished(mBuffer.getResourceUse());
}
} // namespace rx