-
Show log
Commit
-
Hash : 44bbfbda
Author :
Date : 2024-09-16T09:59:56
Tests: deqp no longer logs unused test expectations Similarly to https://crrev.com/c/5238992, deqp is the only suite that does this. Also, this applies only to the current platform (for example, unused expectations with tag VULKAN are not logged when running under Swiftshader). If we actually want to check for unused expectations we should revisit the approach and do it consistently across suites. Logging can cause obscure issues as described in b/361100186#comment3: Tests are executed by first listing the tests, then splitting the list into chunks and executing sequentially with filter=*test1:test2:...testN. The problem is that first part, "listing the tests", is pretty clunky, and instead of using a proper format we usually just parse stdout somewhere. So what's probably happening is "Line 20: expectation was unused." gets printed while listing tests, and the first word, Line, is assumed to be a test name, so we end up with filter=*Line Bug: b/361100186 Change-Id: Id7836640877e3adae04b53f03867028103f159b7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5866130 Commit-Queue: Roman Lavrov <romanl@google.com> Reviewed-by: Yuxin Hu <yuxinhu@google.com>
-
Files
- BUILD.gn
- OWNERS
- angle_android_test_runner.py
- angle_deqp_tests_main.cpp
- angle_end2end_tests.gni
- angle_end2end_tests_expectations.txt
- angle_end2end_tests_main.cpp
- angle_generic_tests_main.cpp
- angle_perftests.gni
- angle_perftests_main.cpp
- angle_system_info_tests_main.cpp
- angle_trace_tests_main.cpp
- angle_traces.gni
- angle_unittest_main.cpp
- angle_unittests.gni
- angle_unittests_utils.h
- angle_white_box_tests.gni
- angle_white_box_tests_main.cpp
- capture_replay_tests.py
- capture_replay_tests/
- capture_tests/
- compiler_tests/
- deqp_support/
- egl_tests/
- gl_tests/
- gles1_conformance_tests/
- gles_conformance_tests/
- perf_tests/
- preprocessor_tests/
- py_utils/
- restricted_traces/
- run_angle_android_test.py
- run_perf_tests.py
- test_expectations/
- test_utils/
- util_tests/
