-
Show log
Commit
-
Hash : a0924015
Author :
Date : 2021-11-22T19:44:05
Metal:Fix GLSLTest_ES3.GLVertexIDIntegerTextureDrawElements Metal The test was failing if the "first" argument to glDrawElements was odd. When odd the offset was not a multiple of 2 bytes and the code was going down a different path than when the offset was event. The fix for that just removes a check for alignment to 4 bytes. Checking with UNSIGNED_BYTE indices though and it still failed. That was because it was encoding the index conversion path on one command buffer and the provoking index prep on another and so they were happening out of order. Putting both on the same command buffer fixes that. Bug: angleproject:6688 Change-Id: I89b68ba965d073e0fa70b6d5b444dc743b5e34a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3296631 Commit-Queue: Gregg Tavares <gman@chromium.org> Reviewed-by: Kyle Piddington <kpiddington@apple.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- ActiveTextureCacheTest.cpp
- AtomicCounterBufferTest.cpp
- AttributeLayoutTest.cpp
- BPTCCompressedTextureTest.cpp
- BindGeneratesResourceTest.cpp
- BindUniformLocationTest.cpp
- BlendFuncExtendedTest.cpp
- BlendIntegerTest.cpp
- BlendMinMaxTest.cpp
- BlendPackedTest.cpp
- BlitFramebufferANGLETest.cpp
- BufferDataTest.cpp
- BuiltinVariableTest.cpp
- ClearTest.cpp
- ClientArraysTest.cpp
- ClipDistanceTest.cpp
- ColorMaskTest.cpp
- CompressedTextureFormatsTest.cpp
- ComputeShaderTest.cpp
- ContextLostTest.cpp
- ContextNoErrorTest.cpp
- CopyCompressedTextureTest.cpp
- CopyTexImageTest.cpp
- CopyTexture3DTest.cpp
- CopyTextureTest.cpp
- CubeMapTextureTest.cpp
- D3D11EmulatedIndexedBufferTest.cpp
- D3D11FormatTablesTest.cpp
- D3D11InputLayoutCacheTest.cpp
- D3DImageFormatConversionTest.cpp
- D3DTextureTest.cpp
- DXT1CompressedTextureTest.cpp
- DXTSRGBCompressedTextureTest.cpp
- DXTSRGBCompressedTextureTestData.inl
- DebugMarkerTest.cpp
- DebugTest.cpp
- DepthStencilFormatsTest.cpp
- DepthStencilTest.cpp
- DifferentStencilMasksTest.cpp
- DiscardFramebufferEXTTest.cpp
- DrawBaseVertexBaseInstanceTest.cpp
- DrawBaseVertexVariantsTest.cpp
- DrawBuffersTest.cpp
- DrawElementsTest.cpp
- ETCTextureTest.cpp
- ErrorMessages.cpp
- ExternalBufferTest.cpp
- ExternalWrapTest.cpp
- FenceSyncTests.cpp
- FloatingPointSurfaceTest.cpp
- FormatPrintTest.cpp
- FramebufferFetchTest.cpp
- FramebufferMixedSamplesTest.cpp
- FramebufferMultiviewTest.cpp
- FramebufferRenderMipmapTest.cpp
- FramebufferTest.cpp
- GLSLTest.cpp
- GeometryShaderTest.cpp
- GetImageTest.cpp
- GetTexLevelParameterTest.cpp
- ImageTest.cpp
- ImageTestMetal.mm
- IncompleteTextureTest.cpp
- IndexBufferOffsetTest.cpp
- IndexedPointsTest.cpp
- InstancingTest.cpp
- LineLoopTest.cpp
- LinkAndRelinkTest.cpp
- MatrixTest.cpp
- MaxTextureSizeTest.cpp
- MemoryBarrierTest.cpp
- MemoryObjectTest.cpp
- MemorySizeTest.cpp
- MipmapTest.cpp
- MultiDrawTest.cpp
- MultisampleCompatibilityTest.cpp
- MultisampleTest.cpp
- MultisampledRenderToTextureTest.cpp
- MultithreadingTest.cpp
- MultiviewDrawTest.cpp
- ObjectAllocationTest.cpp
- OcclusionQueriesTest.cpp
- PBOExtensionTest.cpp
- PackUnpackTest.cpp
- ParallelShaderCompileTest.cpp
- PbufferTest.cpp
- PixmapTest.cpp
- PointSpritesTest.cpp
- ProgramBinaryTest.cpp
- ProgramInterfaceTest.cpp
- ProgramParameterTest.cpp
- ProgramPipelineTest.cpp
- ProvokingVertexTest.cpp
- QueryObjectValidation.cpp
- ReadOnlyFeedbackLoopTest.cpp
- ReadPixelsTest.cpp
- RenderbufferMultisampleTest.cpp
- RendererTest.cpp
- RequestExtensionTest.cpp
- RobustBufferAccessBehaviorTest.cpp
- RobustClientMemoryTest.cpp
- RobustFragmentShaderOutputTest.cpp
- RobustResourceInitTest.cpp
- S3TCTextureSizesTest.cpp
- SRGBFramebufferTest.cpp
- SRGBTextureTest.cpp
- SamplersTest.cpp
- SemaphoreTest.cpp
- ShaderInterpTest.cpp
- ShaderNonConstGlobalInitializerTest.cpp
- ShaderStorageBufferTest.cpp
- SimpleOperationTest.cpp
- SixteenBppTextureTest.cpp
- StateChangeTest.cpp
- SwizzleTest.cpp
- SyncQueriesTest.cpp
- TextureExternalUpdateTest.cpp
- TextureFilteringHintTest.cpp
- TextureMultisampleTest.cpp
- TextureRectangleTest.cpp
- TextureTest.cpp
- TextureUploadFormatTest.cpp
- TimerQueriesTest.cpp
- TransformFeedbackTest.cpp
- UniformBufferTest.cpp
- UniformTest.cpp
- UnpackAlignmentTest.cpp
- UnpackRowLength.cpp
- VertexAttributeTest.cpp
- ViewportTest.cpp
- VulkanDescriptorSetTest.cpp
- VulkanExternalImageTest.cpp
- VulkanFormatTablesTest.cpp
- VulkanFramebufferTest.cpp
- VulkanMultithreadingTest.cpp
- VulkanPerformanceCounterTest.cpp
- VulkanUniformUpdatesTest.cpp
- WEBGLVideoTextureTest.cpp
- WebGLCompatibilityTest.cpp
- WebGLFramebufferTest.cpp
- WebGLReadOutsideFramebufferTest.cpp
- gles1/
- media/
