Hash :
acf2f3ad
Author :
Date :
2017-11-21T19:22:44
Apply Chromium style fixes. This addresses several minor code quality issues that are validated in Chromium, but not yet applied to ANGLE: * constructors and destructors must be defined out-of-line * auto is not allowed for simple pointer types * use override everywhere instead of virtual * virtual functions must also be defined out-of-line Slightly reduces binary size for me (~2k on Win, 150k on Linux). Bug: angleproject:1569 Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6 Reviewed-on: https://chromium-review.googlesource.com/779959 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135
//
// Copyright (c) 2002-2013 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// Fence.cpp: Implements the gl::FenceNV and gl::Sync classes, which support the GL_NV_fence
// extension and GLES3 sync objects.
#include "libANGLE/Fence.h"
#include "angle_gl.h"
#include "common/utilities.h"
#include "libANGLE/renderer/FenceNVImpl.h"
#include "libANGLE/renderer/SyncImpl.h"
namespace gl
{
FenceNV::FenceNV(rx::FenceNVImpl *impl)
: mFence(impl),
mIsSet(false),
mStatus(GL_FALSE),
mCondition(GL_NONE)
{
}
FenceNV::~FenceNV()
{
SafeDelete(mFence);
}
Error FenceNV::set(GLenum condition)
{
Error error = mFence->set(condition);
if (error.isError())
{
return error;
}
mCondition = condition;
mStatus = GL_FALSE;
mIsSet = true;
return NoError();
}
Error FenceNV::test(GLboolean *outResult)
{
// Flush the command buffer by default
Error error = mFence->test(&mStatus);
if (error.isError())
{
return error;
}
*outResult = mStatus;
return NoError();
}
Error FenceNV::finish()
{
ASSERT(mIsSet);
gl::Error error = mFence->finish();
if (error.isError())
{
return error;
}
mStatus = GL_TRUE;
return NoError();
}
Sync::Sync(rx::SyncImpl *impl, GLuint id)
: RefCountObject(id),
mFence(impl),
mLabel(),
mCondition(GL_SYNC_GPU_COMMANDS_COMPLETE),
mFlags(0)
{
}
Error Sync::onDestroy(const Context *context)
{
return NoError();
}
Sync::~Sync()
{
SafeDelete(mFence);
}
void Sync::setLabel(const std::string &label)
{
mLabel = label;
}
const std::string &Sync::getLabel() const
{
return mLabel;
}
Error Sync::set(GLenum condition, GLbitfield flags)
{
Error error = mFence->set(condition, flags);
if (error.isError())
{
return error;
}
mCondition = condition;
mFlags = flags;
return NoError();
}
Error Sync::clientWait(GLbitfield flags, GLuint64 timeout, GLenum *outResult)
{
ASSERT(mCondition != GL_NONE);
return mFence->clientWait(flags, timeout, outResult);
}
Error Sync::serverWait(GLbitfield flags, GLuint64 timeout)
{
return mFence->serverWait(flags, timeout);
}
Error Sync::getStatus(GLint *outResult) const
{
return mFence->getStatus(outResult);
}
} // namespace gl