kc3-lang/angle/src/libANGLE/params.cpp

• Show log

  Commit

• Hash : acf2f3ad
  Author :
  Date : 2017-11-21T19:22:44
  

  Apply Chromium style fixes.
  
  This addresses several minor code quality issues that are validated
  in Chromium, but not yet applied to ANGLE:
  
  * constructors and destructors must be defined out-of-line
  * auto is not allowed for simple pointer types
  * use override everywhere instead of virtual
  * virtual functions must also be defined out-of-line
  
  Slightly reduces binary size for me (~2k on Win, 150k on Linux).
  
  Bug: angleproject:1569
  Change-Id: I073ca3365188caf5f29fb28d9eb207903c1843e6
  Reviewed-on: https://chromium-review.googlesource.com/779959
  Commit-Queue: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/libANGLE/params.cpp

• //
  // Copyright 2017 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // params:
  //   Parameter wrapper structs for OpenGL ES. These helpers cache re-used values
  //   in entry point routines.
  
  #include "libANGLE/params.h"
  
  #include "common/utilities.h"
  #include "libANGLE/Context.h"
  #include "libANGLE/VertexArray.h"
  
  namespace gl
  {
  
  // static
  constexpr ParamTypeInfo ParamsBase::TypeInfo;
  constexpr ParamTypeInfo HasIndexRange::TypeInfo;
  
  HasIndexRange::HasIndexRange()
      : ParamsBase(nullptr), mContext(nullptr), mCount(0), mType(GL_NONE), mIndices(nullptr)
  {
  }
  
  HasIndexRange::HasIndexRange(Context *context, GLsizei count, GLenum type, const void *indices)
      : ParamsBase(context), mContext(context), mCount(count), mType(type), mIndices(indices)
  {
  }
  
  const Optional<IndexRange> &HasIndexRange::getIndexRange() const
  {
      if (mIndexRange.valid() || !mContext)
      {
          return mIndexRange;
      }
  
      const State &state = mContext->getGLState();
  
      const gl::VertexArray *vao     = state.getVertexArray();
      gl::Buffer *elementArrayBuffer = vao->getElementArrayBuffer().get();
  
      if (elementArrayBuffer)
      {
          uintptr_t offset = reinterpret_cast<uintptr_t>(mIndices);
          IndexRange indexRange;
          Error error =
              elementArrayBuffer->getIndexRange(mContext, mType, static_cast<size_t>(offset), mCount,
                                                state.isPrimitiveRestartEnabled(), &indexRange);
          if (error.isError())
          {
              mContext->handleError(error);
              return mIndexRange;
          }
  
          mIndexRange = indexRange;
      }
      else
      {
          mIndexRange = ComputeIndexRange(mType, mIndices, mCount, state.isPrimitiveRestartEnabled());
      }
  
      return mIndexRange;
  }
  
  }  // namespace gl
  

Download