-
Show log
Commit
-
Hash : 3b3783bc
Author :
Date : 2024-11-18T16:42:47
Reland "Possibly fix FixedQueue.ConcurrentPushPop flakiness" This is a reland of commit 84b175546ec95af14b6a85def7d5b2e81ae5a88a Reverted CL increased flakiness because of incorrect `ASSERT` expressions present in the original code and which should have been also corrected. The fix itself had no new issues. This CL additionally fixes these `ASSERT` expressions. Suspected source of flakiness in both tests is the possibility to call `q.pop()` while `q.empty()` is true. Original fix added check for `enqueueThreadFinished` to break from the loop. New fix instead of checking for `enqueueThreadFinished` to break from the loop, checks if `q.empty()` is true. This change allows processing already pushed values even if the enqueue thread already finished. It is applied to both tests. Additional changes not related to fixing the flakiness: - `std::time()` replaced with `angle::GetCurrentSystemTime()` because `std::time_t` may be integer (Android) while `timeOut` is double. This is confusing. For example, if set `timeOut = 0.5` - actual timeout will still be one second. - fix enqueue thread to actually reach the maximum capacity. - improve dequeue thread to prevent updating to the same of greater capacity. - add extra `ASSERT` checks. - make code in both tests consistent with each other. Original change's description: > Possibly fix FixedQueue.ConcurrentPushPop flakiness > > Queue may be empty when `enqueueThreadFinished` become true. > > This is same as the previous fix for `ConcurrentPushPopWithResize`: > https://chromium-review.googlesource.com/c/angle/angle/+/5823039 > > Change also removes always true expressions from the > `ConcurrentPushPopWithResize` test. > > Bug: b/302739073 > Change-Id: I82ee294208d918b7007d85b2cd90e2642fc1e54f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6030517 > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Igor Nazarov <i.nazarov@samsung.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: b/302739073 Change-Id: I8f3840326f3fceed044fa188245772a5ff7b638d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6038334 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
-
Files
- BinaryStream.h
- BinaryStream_unittest.cpp
- CircularBuffer.h
- CircularBuffer_unittest.cpp
- Color.h
- Color.inc
- CompiledShaderState.cpp
- CompiledShaderState.h
- FastVector.h
- FastVector_unittest.cpp
- FixedQueue.h
- FixedQueue_unittest.cpp
- FixedVector.h
- FixedVector_unittest.cpp
- Float16ToFloat32.cpp
- Float16ToFloat32.py
- MemoryBuffer.cpp
- MemoryBuffer.h
- Optional.h
- Optional_unittest.cpp
- PackedCLEnums_autogen.cpp
- PackedCLEnums_autogen.h
- PackedEGLEnums_autogen.cpp
- PackedEGLEnums_autogen.h
- PackedEnums.cpp
- PackedEnums.h
- PackedGLEnums_autogen.cpp
- PackedGLEnums_autogen.h
- PoolAlloc.cpp
- PoolAlloc.h
- PoolAlloc_unittest.cpp
- RingBufferAllocator.cpp
- RingBufferAllocator.h
- SimpleMutex.cpp
- SimpleMutex.h
- SimpleMutex_unittest.cpp
- SynchronizedValue.h
- WorkerThread.cpp
- WorkerThread.h
- WorkerThread_unittest.cpp
- aligned_memory.cpp
- aligned_memory.h
- aligned_memory_unittest.cpp
- android_util.cpp
- android_util.h
- angle_version.h
- angle_version_info.cpp
- angle_version_info.h
- angleutils.cpp
- angleutils.h
- angleutils_unittest.cpp
- apple/
- apple_platform_utils.h
- apple_platform_utils.mm
- backtrace_utils.h
- backtrace_utils_android.cpp
- backtrace_utils_noop.cpp
- base/
- bitset_utils.h
- bitset_utils_unittest.cpp
- debug.cpp
- debug.h
- entry_points_enum_autogen.cpp
- entry_points_enum_autogen.h
- event_tracer.cpp
- event_tracer.h
- frame_capture_utils.cpp
- frame_capture_utils.h
- frame_capture_utils_autogen.cpp
- frame_capture_utils_autogen.h
- fuchsia_egl/
- gen_packed_gl_enums.py
- gen_uniform_type_table.py
- gl/
- gl_enum_utils.cpp
- gl_enum_utils.h
- gl_enum_utils_autogen.cpp
- gl_enum_utils_autogen.h
- hash_containers.h
- hash_utils.h
- hash_utils_unittest.cpp
- linux/
- log_utils.h
- mathutil.cpp
- mathutil.h
- mathutil_unittest.cpp
- matrix_utils.cpp
- matrix_utils.h
- matrix_utils_unittest.cpp
- packed_cl_enums.json
- packed_egl_enums.json
- packed_gl_enums.json
- platform.h
- platform_helpers.cpp
- platform_helpers.h
- serializer/
- spirv/
- string_utils.cpp
- string_utils.h
- string_utils_unittest.cpp
- system_utils.cpp
- system_utils.h
- system_utils_apple.cpp
- system_utils_ios.cpp
- system_utils_ios.mm
- system_utils_linux.cpp
- system_utils_mac.cpp
- system_utils_posix.cpp
- system_utils_unittest.cpp
- system_utils_win.cpp
- system_utils_win32.cpp
- system_utils_winuwp.cpp
- third_party/
- tls.cpp
- tls.h
- uniform_type_info_autogen.cpp
- uniform_type_info_autogen.h
- utilities.cpp
- utilities.h
- utilities_unittest.cpp
- vector_utils.h
- vector_utils_unittest.cpp
- vulkan/
