-
Show log
Commit
-
Hash : c6fbf93d
Author :
Date : 2024-01-19T09:57:12
Vulkan: Fix input attachments leaking into uniform list To communicate the existence of input attachments added to the shader, the translator was adding `ShaderVariable`s for each to the list of uniforms exported from the shader. This was incorrect, as this list is visible to the application through `glGetActiveUniform`. Additionally, this was unnecessarily causing these uniforms to go through program link. Reserving SPIR-V ids for these uniforms, all that is needed from the translator is the mere existence of these input attachments. This change removes the addition of uniforms, and instead exports a bitset. Elsewhere, that bitset is consulted and reserved SPIR-V ids are used. Bug: b/320563594 Bug: angleproject:5792 Change-Id: Id93846cbc3996248f391fd2d5a65af1e48d6d46e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5215089 Reviewed-by: mohan maiya <m.maiya@samsung.com> Reviewed-by: Charlie Lao <cclao@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- EmulateAdvancedBlendEquations.cpp
- EmulateAdvancedBlendEquations.h
- EmulateDithering.cpp
- EmulateDithering.h
- EmulateFragColorData.cpp
- EmulateFragColorData.h
- EmulateFramebufferFetch.cpp
- EmulateFramebufferFetch.h
- EmulateYUVBuiltIns.cpp
- EmulateYUVBuiltIns.h
- FlagSamplersWithTexelFetch.cpp
- FlagSamplersWithTexelFetch.h
- ReswizzleYUVOps.cpp
- ReswizzleYUVOps.h
- RewriteInterpolateAtOffset.cpp
- RewriteInterpolateAtOffset.h
- RewriteR32fImages.cpp
- RewriteR32fImages.h
