-
Show log
Commit
-
Hash : 0197826b
Author :
Date : 2024-03-22T14:42:34
Revert "Add conversion operator from ImmutableString to std::string" This reverts commit 8c0dae388bccb00f11cd94d641d719cc68325826. Reason for revert: Breaks Android rolls: external/angle/src/compiler/translator/ImmutableString.h:103:15: error: constexpr function's return type 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char>>') is not a literal type 103 | constexpr operator std::string() const { return std::string(data(), length()); } | ^ external/libcxx/include/string:4332:64: note: 'basic_string<char>' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move constructors 4332 | _LIBCPP_EXTERN_TEMPLATE(class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS basic_string<char>) Original change's description: > Add conversion operator from ImmutableString to std::string > > Also use the operator in a couple of places. Sometimes saves a strlen. > > Bug: angleproject:8614 > Change-Id: I429f3ac02af04b568ac7d1adf22ab65e5007fbda > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5372728 > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Auto-Submit: Kimmo Kinnunen <kkinnunen@apple.com> > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Bug: angleproject:8614 Change-Id: I46963686f9506f7029e164250b1bf81f8ab2c519 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5388255 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Roman Lavrov <romanl@google.com>
-
Files
- API_test.cpp
- APPLE_clip_distance_test.cpp
- ARB_texture_rectangle_test.cpp
- AppendixALimitations_test.cpp
- AtomicCounter_test.cpp
- BufferVariables_test.cpp
- CollectVariables_test.cpp
- ConstantFoldingNaN_test.cpp
- ConstantFoldingOverflow_test.cpp
- ConstantFolding_test.cpp
- ConstructCompiler_test.cpp
- EXT_YUV_target_test.cpp
- EXT_blend_func_extended_test.cpp
- EXT_clip_cull_distance_test.cpp
- EXT_frag_depth_test.cpp
- EXT_shader_framebuffer_fetch_test.cpp
- EXT_shader_texture_lod_test.cpp
- EXT_shadow_samplers_test.cpp
- EmulateGLBaseVertexBaseInstance_test.cpp
- EmulateGLDrawID_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- ExtensionDirective_test.cpp
- FloatLex_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- GeometryShader_test.cpp
- GlFragDataNotModified_test.cpp
- HLSLOutput_test.cpp
- ImmutableString_test.cpp
- ImmutableString_test_ESSL_autogen.cpp
- ImmutableString_test_autogen.cpp
- InitOutputVariables_test.cpp
- IntermNode_test.cpp
- KHR_blend_equation_advanced_test.cpp
- MSLOutput_test.cpp
- NV_draw_buffers_test.cpp
- OES_sample_variables_test.cpp
- OES_standard_derivatives_test.cpp
- OES_texture_cube_map_array_test.cpp
- OVR_multiview2_test.cpp
- OVR_multiview_test.cpp
- Pack_Unpack_test.cpp
- Parse_test.cpp
- Precise_test.cpp
- PruneEmptyCases_test.cpp
- PruneEmptyDeclarations_test.cpp
- PrunePureLiteralStatements_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RegenerateStructNames_test.cpp
- RemoveUnreferencedVariables_test.cpp
- RewriteDoWhile_test.cpp
- SamplerMultisample_test.cpp
- SamplerVideoWEBGL_test.cpp
- ShCompile_test.cpp
- ShaderImage_test.cpp
- ShaderValidation_test.cpp
- ShaderVariable_test.cpp
- TextureFunction_test.cpp
- TypeTracking_test.cpp
- Type_test.cpp
- UnfoldShortCircuitAST_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- WorkGroupSize_test.cpp
