Hash :
a4a52f78
Author :
Date :
2021-11-10T12:43:37
EGL: Validate CreatePbufferSurface attributes. This fixes an ASAN issue with a dEQP negative test: dEQP.EGL/functional_negative_api_create_pbuffer_surface Bug: angleproject:6660 Change-Id: I2d052f9f948b7a2a6fe3fbb1f1621dd280bb0d36 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3270978 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
#ifndef LIBANGLE_ATTRIBUTEMAP_H_
#define LIBANGLE_ATTRIBUTEMAP_H_
#include "common/PackedEnums.h"
#include <EGL/egl.h>
#include <functional>
#include <map>
#include <vector>
namespace egl
{
class Display;
struct ValidationContext;
// Validates {key, value} for each attribute. Generates an error and returns false on invalid usage.
using AttributeValidationFunc =
std::function<bool(const ValidationContext *, const Display *, EGLAttrib)>;
class AttributeMap final
{
public:
AttributeMap();
AttributeMap(const AttributeMap &other);
AttributeMap &operator=(const AttributeMap &other);
~AttributeMap();
void insert(EGLAttrib key, EGLAttrib value);
bool contains(EGLAttrib key) const;
EGLAttrib get(EGLAttrib key) const;
EGLAttrib get(EGLAttrib key, EGLAttrib defaultValue) const;
EGLint getAsInt(EGLAttrib key) const;
EGLint getAsInt(EGLAttrib key, EGLint defaultValue) const;
template <typename PackedEnumT>
PackedEnumT getAsPackedEnum(EGLAttrib key) const
{
return FromEGLenum<PackedEnumT>(static_cast<EGLenum>(get(key)));
}
template <typename PackedEnumT>
PackedEnumT getAsPackedEnum(EGLAttrib key, PackedEnumT defaultValue) const
{
auto iter = attribs().find(key);
return (attribs().find(key) != attribs().end())
? FromEGLenum<PackedEnumT>(static_cast<EGLenum>(iter->second))
: defaultValue;
}
bool isEmpty() const;
std::vector<EGLint> toIntVector() const;
typedef std::map<EGLAttrib, EGLAttrib>::const_iterator const_iterator;
const_iterator begin() const;
const_iterator end() const;
ANGLE_NO_DISCARD bool validate(const ValidationContext *val,
const egl::Display *display,
AttributeValidationFunc validationFunc) const;
// TODO: remove this and validate at every call site. http://anglebug.com/6671
void initializeWithoutValidation() const;
static AttributeMap CreateFromIntArray(const EGLint *attributes);
static AttributeMap CreateFromAttribArray(const EGLAttrib *attributes);
private:
bool isValidated() const;
const std::map<EGLAttrib, EGLAttrib> &attribs() const
{
ASSERT(isValidated());
return mValidatedAttributes;
}
std::map<EGLAttrib, EGLAttrib> &attribs()
{
ASSERT(isValidated());
return mValidatedAttributes;
}
mutable const EGLint *mIntPointer = nullptr;
mutable const EGLAttrib *mAttribPointer = nullptr;
mutable std::map<EGLAttrib, EGLAttrib> mValidatedAttributes;
};
} // namespace egl
#endif // LIBANGLE_ATTRIBUTEMAP_H_