kc3-lang/angle/src/libANGLE/renderer/vulkan/TransformFeedbackVk.h

• Show log

  Commit

• Hash : 29aae8ac
  Author :
  Date : 2023-08-14T15:33:16
  

  Vulkan: Don't access the XFB object during link
  
  The descriptor set layout set up for XFB emulation lived in
  TransfromFeedbackVk, but did not access anything in that object at all.
  More importantly, it doesn't make any sense to look at the current XFB
  object when linking a program.
  
  Bug: angleproject:8297
  Change-Id: I8bd0e747b7d3e3783ef053f20378cc42d2c1d997
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4774786
  Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Reviewed-by: Yuxin Hu <yuxinhu@google.com>
  

Download

• src/libANGLE/renderer/vulkan/TransformFeedbackVk.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // TransformFeedbackVk.h:
  //    Defines the class interface for TransformFeedbackVk, implementing TransformFeedbackImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_VULKAN_TRANSFORMFEEDBACKVK_H_
  #define LIBANGLE_RENDERER_VULKAN_TRANSFORMFEEDBACKVK_H_
  
  #include "libANGLE/renderer/TransformFeedbackImpl.h"
  
  #include "libANGLE/renderer/vulkan/vk_helpers.h"
  
  namespace gl
  {
  class ProgramState;
  }  // namespace gl
  
  namespace rx
  {
  class UpdateDescriptorSetsBuilder;
  class ShaderInterfaceVariableInfoMap;
  
  namespace vk
  {
  class DescriptorSetLayoutDesc;
  }  // namespace vk
  
  class TransformFeedbackVk : public TransformFeedbackImpl, public angle::ObserverInterface
  {
    public:
      TransformFeedbackVk(const gl::TransformFeedbackState &state);
      ~TransformFeedbackVk() override;
      void onDestroy(const gl::Context *context) override;
  
      angle::Result begin(const gl::Context *context, gl::PrimitiveMode primitiveMode) override;
      angle::Result end(const gl::Context *context) override;
      angle::Result pause(const gl::Context *context) override;
      angle::Result resume(const gl::Context *context) override;
  
      angle::Result bindIndexedBuffer(const gl::Context *context,
                                      size_t index,
                                      const gl::OffsetBindingPointer<gl::Buffer> &binding) override;
  
      void getBufferOffsets(ContextVk *contextVk,
                            GLint drawCallFirstVertex,
                            int32_t *offsetsOut,
                            size_t offsetsSize) const;
  
      bool getAndResetBufferRebindState()
      {
          bool retVal                    = mRebindTransformFeedbackBuffer;
          mRebindTransformFeedbackBuffer = false;
          return retVal;
      }
  
      const gl::TransformFeedbackBuffersArray<vk::BufferHelper *> &getBufferHelpers() const
      {
          return mBufferHelpers;
      }
  
      const gl::TransformFeedbackBuffersArray<VkBuffer> &getBufferHandles() const
      {
          return mBufferHandles;
      }
  
      const gl::TransformFeedbackBuffersArray<VkDeviceSize> &getBufferOffsets() const
      {
          return mBufferOffsets;
      }
  
      const gl::TransformFeedbackBuffersArray<VkDeviceSize> &getBufferSizes() const
      {
          return mBufferSizes;
      }
  
      gl::TransformFeedbackBuffersArray<vk::BufferHelper> &getCounterBufferHelpers()
      {
          return mCounterBufferHelpers;
      }
  
      const gl::TransformFeedbackBuffersArray<VkBuffer> &getCounterBufferHandles() const
      {
          return mCounterBufferHandles;
      }
  
      void updateTransformFeedbackDescriptorDesc(
          const vk::Context *context,
          const gl::ProgramExecutable &executable,
          const ShaderInterfaceVariableInfoMap &variableInfoMap,
          const vk::WriteDescriptorDescs &writeDescriptorDescs,
          const vk::BufferHelper &emptyBuffer,
          bool activeUnpaused,
          vk::DescriptorSetDescBuilder *builder) const;
  
      const gl::TransformFeedbackBuffersArray<VkDeviceSize> &getCounterBufferOffsets() const
      {
          return mCounterBufferOffsets;
      }
  
      void onSubjectStateChange(angle::SubjectIndex index, angle::SubjectMessage message) override;
  
      void onNewDescriptorSet(const gl::ProgramExecutable &executable,
                              const vk::SharedDescriptorSetCacheKey &sharedCacheKey);
  
    private:
      void initializeXFBVariables(ContextVk *contextVk, uint32_t xfbBufferCount);
  
      void releaseCounterBuffers(RendererVk *renderer);
  
      // This member variable is set when glBindTransformFeedbackBuffers/glBeginTransformFeedback
      // is called and unset in dirty bit handler for transform feedback state change. If this
      // value is true, vertex shader will record transform feedback varyings from the beginning
      // of the buffer.
      bool mRebindTransformFeedbackBuffer;
  
      gl::TransformFeedbackBuffersArray<vk::BufferHelper *> mBufferHelpers;
      gl::TransformFeedbackBuffersArray<VkBuffer> mBufferHandles;
      gl::TransformFeedbackBuffersArray<VkDeviceSize> mBufferOffsets;
      gl::TransformFeedbackBuffersArray<VkDeviceSize> mBufferSizes;
  
      // Counter buffer used for pause and resume.
      gl::TransformFeedbackBuffersArray<vk::BufferHelper> mCounterBufferHelpers;
      gl::TransformFeedbackBuffersArray<VkBuffer> mCounterBufferHandles;
      gl::TransformFeedbackBuffersArray<VkDeviceSize> mCounterBufferOffsets;
  
      // Buffer binding points
      std::vector<angle::ObserverBinding> mBufferObserverBindings;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_VULKAN_TRANSFORMFEEDBACKVK_H_
  

Download