-
Show log
Commit
-
Hash : d919870f
Author :
Date : 2023-09-14T16:00:07
Vulkan: Do host image copy without holding the share group lock When an application uploads texture data such as with `glTexSubImage2D`, the share group lock is being hold while the data is being copied. Without VK_EXT_host_image_copy, this is a copy to a staging buffer, which may itself be expensive. With VK_EXT_host_image_copy, the cost of the copy is higher and so the lock would be held for a longer duration. This is particularly harmful to applications that spawn a separate thread for texture uploads (as the main thread is unable to make GL calls). This change moves the actual copy call to the tail of the call after the share group lock has been released. As a result: - The upload thread may be a bit slower, but - The copy does not interfere with the main thread, and - The copy does not interfere with the GPU's rendering work. As a result, games that load content seamlessly during gameplay should experience less stutter during texture uploads. Bug: angleproject:8341 Change-Id: I818c4389d4bf828847578da89414623e4b5e844e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4864290 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- angle_deqp_bundle.py
- angle_deqp_test_merge.py
- angle_presubmit_utils.py
- angle_presubmit_utils_unittest.py
- angle_trace_bundle.py
- apply_clang_format_on_all_sources.py
- bootstrap.py
- code_generation_hashes/
- egl_angle_ext.xml
- entry_point_packed_egl_enums.json
- entry_point_packed_gl_enums.json
- export_targets.py
- extension_data/
- file_exists.py
- gen_angle_gn_info_json.py
- gen_gl_enum_utils.py
- gen_interpreter_utils.py
- gen_proc_table.py
- gen_vk_gl_cts_build.py
- generate_android_bp.py
- generate_entry_points.py
- generate_loader.py
- generate_stats.py
- gl_angle_ext.xml
- process_angle_perf_results.py
- registry_xml.py
- roll_aosp.sh
- roll_chromium_deps.py
- run_code_generation.py
- tracegz.py
- trigger.bat
- trigger.py
- update_chrome_angle.py
- update_extension_data.py
- vk_mandatory_format_support_capture_to_json.js
