-
Show log
Commit
-
Hash : 3892ac14
Author :
Date : 2023-10-12T13:35:33
Do not flush normal float constants to zero. It's ok to flush denormalized constants to zero. It's not ok to flush perfectly valid normal float constants >= FLT_MIN to zero. Two problems: 1) Values when parsed as doubles with a value less than FLT_MIN are being flushed to zero. This is incorrect when the comparison is done in double, since some values below FLT_MIN in double are equal to FLT_MIN when cast to float. The fix is to perform the comparison in float. 2) Values with a decimal exponent less than FLT_MIN_10_EXP are being flushed to zero. FLT_MIN_10_EXP is -37 but FLT_MIN is 1.1754943E-38. 10^-37 may be the "minimum negative integer such that 10 raised to that power is a normalized float", but being constrained to powers of ten it's above FLT_MIN (which is 2^-126). Since this comparison is done before #1 above, it's only present (AFAIK) to ensure that the exponent will not make the pow() function overflow. Comparing against -38 (FLT_MIN_10_EXP - 1) instead will do the trick. Bug: angleproject:8373, dawn:2077 Change-Id: I1ddf410c2caa9f0d1ba3529ace693dcd326a2cb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4936714 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
-
Files
- API_test.cpp
- APPLE_clip_distance_test.cpp
- ARB_texture_rectangle_test.cpp
- AppendixALimitations_test.cpp
- AtomicCounter_test.cpp
- BufferVariables_test.cpp
- CollectVariables_test.cpp
- ConstantFoldingNaN_test.cpp
- ConstantFoldingOverflow_test.cpp
- ConstantFolding_test.cpp
- ConstructCompiler_test.cpp
- EXT_YUV_target_test.cpp
- EXT_blend_func_extended_test.cpp
- EXT_clip_cull_distance_test.cpp
- EXT_frag_depth_test.cpp
- EXT_shader_framebuffer_fetch_test.cpp
- EXT_shader_texture_lod_test.cpp
- EXT_shadow_samplers_test.cpp
- EmulateGLBaseVertexBaseInstance_test.cpp
- EmulateGLDrawID_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- ExtensionDirective_test.cpp
- FloatLex_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- GeometryShader_test.cpp
- GlFragDataNotModified_test.cpp
- HLSLOutput_test.cpp
- ImmutableString_test.cpp
- ImmutableString_test_ESSL_autogen.cpp
- ImmutableString_test_autogen.cpp
- InitOutputVariables_test.cpp
- IntermNode_test.cpp
- KHR_blend_equation_advanced_test.cpp
- MSLOutput_test.cpp
- NV_draw_buffers_test.cpp
- OES_sample_variables_test.cpp
- OES_standard_derivatives_test.cpp
- OES_texture_cube_map_array_test.cpp
- OVR_multiview2_test.cpp
- OVR_multiview_test.cpp
- Pack_Unpack_test.cpp
- Precise_test.cpp
- PruneEmptyCases_test.cpp
- PruneEmptyDeclarations_test.cpp
- PrunePureLiteralStatements_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RegenerateStructNames_test.cpp
- RemoveUnreferencedVariables_test.cpp
- RewriteDoWhile_test.cpp
- SamplerMultisample_test.cpp
- SamplerVideoWEBGL_test.cpp
- ShCompile_test.cpp
- ShaderImage_test.cpp
- ShaderValidation_test.cpp
- ShaderVariable_test.cpp
- TextureFunction_test.cpp
- TypeTracking_test.cpp
- Type_test.cpp
- UnfoldShortCircuitAST_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- WorkGroupSize_test.cpp
