Hash :
4cbe8548
Author :
Date :
2023-02-28T21:12:17
Expose shader extensions based on ESSL version Previously, all suported extensions were always exposed in the preprocessor. This broke some games which relied on ESSL1-only extension macros not being defined in ESSL3 shaders. This change adds min/max version information to list of extensions so the preprocessor can conditionally expose extensions based on the shader language version, both via the extension name macros and the #extension directive. Test: angle_unittests --gtest_filter="VersionTest.*" Test: angle_end2end_tests --gtest_filter="*ESSL*ExtensionMacros*" Test: Run com.gameloft.android.ANMP.GloftGGHM on Pixel 6 Bug: b/268091452 Change-Id: I2332a6cb964f54c47d23e2ef6b24e99a0b5c8202 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4304907 Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mike Schuchardt <mikes@lunarg.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145
//
// Copyright 2017 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// ExtensionBehavior.cpp: Extension name enumeration and data structures for storing extension
// behavior.
#include "compiler/translator/ExtensionBehavior.h"
#include "common/debug.h"
#include <string.h>
// clang-format off
// Extension Name, Min ESSL Version, Max ESSL Version
#define LIST_EXTENSIONS(OP) \
OP(ANDROID_extension_pack_es31a, 310, 320) \
OP(ANGLE_base_vertex_base_instance_shader_builtin, 300, 320) \
OP(ANGLE_clip_cull_distance, 300, 320) \
OP(ANGLE_multi_draw, 100, 320) \
OP(ANGLE_shader_pixel_local_storage, 300, 320) \
OP(ANGLE_texture_multisample, 300, 320) \
OP(APPLE_clip_distance, 100, 320) \
OP(ARB_texture_rectangle, 100, 320) \
OP(ARM_shader_framebuffer_fetch, 100, 320) \
OP(EXT_blend_func_extended, 100, 320) \
OP(EXT_clip_cull_distance, 300, 320) \
OP(EXT_draw_buffers, 100, 100) \
OP(EXT_frag_depth, 100, 100) \
OP(EXT_geometry_shader, 310, 320) \
OP(OES_geometry_shader, 310, 320) \
OP(OES_shader_io_blocks, 310, 320) \
OP(EXT_shader_io_blocks, 310, 320) \
OP(EXT_gpu_shader5, 310, 320) \
OP(EXT_primitive_bounding_box, 310, 320) \
OP(OES_primitive_bounding_box, 310, 320) \
OP(EXT_separate_shader_objects, 100, 320) \
OP(EXT_shader_framebuffer_fetch, 100, 320) \
OP(EXT_shader_framebuffer_fetch_non_coherent, 100, 320) \
OP(EXT_shader_non_constant_global_initializers, 100, 320) \
OP(EXT_shader_texture_lod, 100, 100) \
OP(EXT_shadow_samplers, 100, 100) \
OP(EXT_tessellation_shader, 310, 320) \
OP(EXT_texture_buffer, 310, 320) \
OP(EXT_texture_cube_map_array, 310, 320) \
OP(EXT_YUV_target, 300, 320) \
OP(KHR_blend_equation_advanced, 100, 320) \
OP(NV_EGL_stream_consumer_external, 100, 320) \
OP(NV_shader_framebuffer_fetch, 100, 100) \
OP(NV_shader_noperspective_interpolation, 300, 320) \
OP(OES_EGL_image_external, 100, 100) \
OP(OES_EGL_image_external_essl3, 300, 320) \
OP(OES_sample_variables, 300, 320) \
OP(OES_shader_multisample_interpolation, 300, 320) \
OP(OES_shader_image_atomic, 310, 320) \
OP(OES_standard_derivatives, 100, 100) \
OP(OES_texture_3D, 100, 100) \
OP(OES_texture_buffer, 310, 320) \
OP(OES_texture_cube_map_array, 310, 320) \
OP(OES_texture_storage_multisample_2d_array, 310, 320) \
OP(OVR_multiview, 300, 320) \
OP(OVR_multiview2, 300, 320) \
OP(WEBGL_video_texture, 100, 320)
// clang-format on
namespace sh
{
#define RETURN_EXTENSION_NAME_CASE(ext, min_version, max_version) \
case TExtension::ext: \
return "GL_" #ext;
const char *GetExtensionNameString(TExtension extension)
{
switch (extension)
{
LIST_EXTENSIONS(RETURN_EXTENSION_NAME_CASE)
default:
UNREACHABLE();
return "";
}
}
#define RETURN_EXTENSION_IF_NAME_MATCHES(ext, min_version, max_version) \
if (strcmp(extWithoutGLPrefix, #ext) == 0) \
{ \
return TExtension::ext; \
}
TExtension GetExtensionByName(const char *extension)
{
// If first characters of the extension don't equal "GL_", early out.
if (strncmp(extension, "GL_", 3) != 0)
{
return TExtension::UNDEFINED;
}
const char *extWithoutGLPrefix = extension + 3;
LIST_EXTENSIONS(RETURN_EXTENSION_IF_NAME_MATCHES)
return TExtension::UNDEFINED;
}
#define RETURN_VERSION_CHECK(ext, min_version, max_version) \
case TExtension::ext: \
return (version >= min_version) && (version <= max_version);
bool CheckExtensionVersion(TExtension extension, int version)
{
switch (extension)
{
LIST_EXTENSIONS(RETURN_VERSION_CHECK)
default:
UNREACHABLE();
return false;
}
}
const char *GetBehaviorString(TBehavior b)
{
switch (b)
{
case EBhRequire:
return "require";
case EBhEnable:
return "enable";
case EBhWarn:
return "warn";
case EBhDisable:
return "disable";
default:
return nullptr;
}
}
bool IsExtensionEnabled(const TExtensionBehavior &extBehavior, TExtension extension)
{
ASSERT(extension != TExtension::UNDEFINED);
auto iter = extBehavior.find(extension);
return iter != extBehavior.end() &&
(iter->second == EBhEnable || iter->second == EBhRequire || iter->second == EBhWarn);
}
} // namespace sh