kc3-lang/angle/src/libANGLE/serializer

Diff

• Show log

  Commit

• Hash : f2c96887
  Author :
  Date : 2021-08-16T15:23:34
  

  Capture/Replay: Pop only after using values it in endGroup
  
  When running the replay in valgrind the use of an undefined
  value in the JsonSerializer::endGroup shows that 'name' value
  on the stack is handled in an unexpected fashion, i.e
  the pop seems to  invalidate the values that should have
  already been moved.
  
  Using the reference of the top() values and doing pop() only
  after the new group entry has been created avoids this.
  
  Bug: angleproject:6180
  Change-Id: I8e5f8dd3d14928d4763faabe236379b40a4f6f4c
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3093815
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Reviewed-by: Cody Northrop <cnorthrop@google.com>
  Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
  

• Files

• JsonSerializer.cpp
• JsonSerializer.h
• JsonSerializer_unittest.cpp

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags