Hash :
aa5b97de
Author :
Date :
2023-03-06T17:59:43
ANGLE_metal_shared_event_sync: Control signaling external events It was assumed that the external MTLSharedEvent passed to eglCreateSync should be signaled by the GL. This change adds EGL_SYNC_METAL_SHARED_EVENT_SIGNALED_ANGLE, which when passed as the value for EGL_SYNC_CONDITION during eglCreateSync, changes the behavior to not insert a fence command into the command stream. Test: angle_end2end_tests --gtest_filter=EGLSyncTestMetalSharedEvent.AngleMetalSharedEventSync_WaitSync_ExternallySignaled Bug: angleproject:8064 Change-Id: Ia1b8615b976f293d411b7d2be506b0ac87d64dee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4307152 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182
//
// Copyright (c) 2020 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// SyncMtl:
// Defines the class interface for SyncMtl, implementing SyncImpl.
//
#ifndef LIBANGLE_RENDERER_METAL_SYNCMTL_H_
#define LIBANGLE_RENDERER_METAL_SYNCMTL_H_
#include <condition_variable>
#include <mutex>
#include "libANGLE/renderer/EGLSyncImpl.h"
#include "libANGLE/renderer/FenceNVImpl.h"
#include "libANGLE/renderer/SyncImpl.h"
#include "libANGLE/renderer/metal/mtl_common.h"
#include "common/Optional.h"
namespace egl
{
class AttributeMap;
}
namespace rx
{
class ContextMtl;
namespace mtl
{
// Common class to be used by both SyncImpl and EGLSyncImpl.
// NOTE: SharedEvent is only declared on iOS 12.0+ or mac 10.14+
#if defined(__IPHONE_12_0) || defined(__MAC_10_14)
class Sync
{
public:
Sync();
~Sync();
void onDestroy();
angle::Result initialize(ContextMtl *contextMtl,
id<MTLSharedEvent> sharedEvent,
Optional<uint64_t> signalValue);
angle::Result set(ContextMtl *contextMtl,
GLenum condition,
GLbitfield flags,
id<MTLSharedEvent> sharedEvent,
Optional<uint64_t> signalValue);
angle::Result clientWait(ContextMtl *contextMtl,
bool flushCommands,
uint64_t timeout,
GLenum *outResult);
void serverWait(ContextMtl *contextMtl);
angle::Result getStatus(bool *signaled);
void *copySharedEvent() const;
private:
SharedEventRef mMetalSharedEvent;
uint64_t mSignalValue = 0;
std::shared_ptr<std::condition_variable> mCv;
std::shared_ptr<std::mutex> mLock;
};
#else // #if defined(__IPHONE_12_0) || defined(__MAC_10_14)
class Sync
{
public:
void onDestroy() { UNREACHABLE(); }
angle::Result initialize(ContextMtl *context)
{
UNREACHABLE();
return angle::Result::Stop;
}
angle::Result set(ContextMtl *contextMtl, GLenum condition, GLbitfield flags)
{
UNREACHABLE();
return angle::Result::Stop;
}
angle::Result clientWait(ContextMtl *context,
bool flushCommands,
uint64_t timeout,
GLenum *outResult)
{
UNREACHABLE();
return angle::Result::Stop;
}
void serverWait(ContextMtl *contextMtl) { UNREACHABLE(); }
angle::Result getStatus(bool *signaled)
{
UNREACHABLE();
return angle::Result::Stop;
}
void *copySharedEvent() const
{
UNREACHABLE();
return nullptr;
}
};
#endif // #if defined(__IPHONE_12_0) || defined(__MAC_10_14)
} // namespace mtl
class FenceNVMtl : public FenceNVImpl
{
public:
FenceNVMtl();
~FenceNVMtl() override;
void onDestroy(const gl::Context *context) override;
angle::Result set(const gl::Context *context, GLenum condition) override;
angle::Result test(const gl::Context *context, GLboolean *outFinished) override;
angle::Result finish(const gl::Context *context) override;
private:
mtl::Sync mSync;
};
class SyncMtl : public SyncImpl
{
public:
SyncMtl();
~SyncMtl() override;
void onDestroy(const gl::Context *context) override;
angle::Result set(const gl::Context *context, GLenum condition, GLbitfield flags) override;
angle::Result clientWait(const gl::Context *context,
GLbitfield flags,
GLuint64 timeout,
GLenum *outResult) override;
angle::Result serverWait(const gl::Context *context,
GLbitfield flags,
GLuint64 timeout) override;
angle::Result getStatus(const gl::Context *context, GLint *outResult) override;
private:
mtl::Sync mSync;
};
class EGLSyncMtl final : public EGLSyncImpl
{
public:
EGLSyncMtl(const egl::AttributeMap &attribs);
~EGLSyncMtl() override;
void onDestroy(const egl::Display *display) override;
egl::Error initialize(const egl::Display *display,
const gl::Context *context,
EGLenum type) override;
egl::Error clientWait(const egl::Display *display,
const gl::Context *context,
EGLint flags,
EGLTime timeout,
EGLint *outResult) override;
egl::Error serverWait(const egl::Display *display,
const gl::Context *context,
EGLint flags) override;
egl::Error getStatus(const egl::Display *display, EGLint *outStatus) override;
egl::Error copyMetalSharedEventANGLE(const egl::Display *display, void **result) const override;
egl::Error dupNativeFenceFD(const egl::Display *display, EGLint *result) const override;
private:
mtl::Sync mSync;
id<MTLSharedEvent> mSharedEvent;
Optional<uint64_t> mSignalValue;
EGLenum mType;
EGLenum mCondition;
};
} // namespace rx
#endif