kc3-lang/angle/src/libANGLE/renderer/vulkan/ImageVk.h

• Show log

  Commit

• Hash : 233c128b
  Author :
  Date : 2023-01-17T19:21:58
  

  Vulkan: Fix UBs when deleted attachment is used in a RenderPass.
  
  Problem:
  - "RenderbufferVk"/"TextureVk" with "mOwnsImage == false" used as
    RenderPass attachment.
  - "RenderbufferVk"/"TextureVk" deleted.
  - Owning resource is destroyed ("EGLImage" and all siblings /
    "EGLSurface").
  - Crash (UB) may happen when ending RenderPass, flushing or executing
    commands.
  
  Fix adds tracking of "vk::ImageSourceID" value in
  "vk::RenderPassAttachment" - IDs of objects, that originally provide
  "vk::ImageHelper" images. This is necessary, because when using
  EGLImage, there may be multiple "TextureVk" objects with same
  "vk::ImageHelper", and need to call "finalizeImageLayout()" for the
  correct attachment.
  
  Bug: angleproject:8032
  Test: angle_end2end_tests --gtest_filter=ImageTest*DeletedWhileInUse*
  Test: angle_end2end_tests --gtest_filter=PbufferTest.UseAsFramebufferColorThenDestroy*
  Change-Id: I50fdd9d6b6a9677adad2262373303b46de1dee4c
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4296014
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Charlie Lao <cclao@google.com>
  Commit-Queue: Igor Nazarov <i.nazarov@samsung.com>
  

Download

• src/libANGLE/renderer/vulkan/ImageVk.h

• //
  // Copyright 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // ImageVk.h:
  //    Defines the class interface for ImageVk, implementing ImageImpl.
  //
  
  #ifndef LIBANGLE_RENDERER_VULKAN_IMAGEVK_H_
  #define LIBANGLE_RENDERER_VULKAN_IMAGEVK_H_
  
  #include "libANGLE/renderer/ImageImpl.h"
  #include "libANGLE/renderer/vulkan/vk_helpers.h"
  
  namespace rx
  {
  
  class ExternalImageSiblingVk : public ExternalImageSiblingImpl
  {
    public:
      ExternalImageSiblingVk() {}
      ~ExternalImageSiblingVk() override {}
  
      virtual vk::ImageHelper *getImage() const = 0;
  
      virtual void release(RendererVk *renderer) = 0;
  };
  
  class ImageVk : public ImageImpl
  {
    public:
      ImageVk(const egl::ImageState &state, const gl::Context *context);
      ~ImageVk() override;
      void onDestroy(const egl::Display *display) override;
  
      egl::Error initialize(const egl::Display *display) override;
  
      angle::Result orphan(const gl::Context *context, egl::ImageSibling *sibling) override;
  
      egl::Error exportVkImage(void *vkImage, void *vkImageCreateInfo) override;
  
      vk::ImageHelper *getImage() const { return mImage; }
      gl::TextureType getImageTextureType() const;
      gl::LevelIndex getImageLevel() const;
      uint32_t getImageLayer() const;
  
      UniqueSerial generateSiblingSerial() { return mImageSiblingSerialFactory.generate(); }
  
    private:
      bool mOwnsImage;
      vk::ImageHelper *mImage;
      UniqueSerialFactory mImageSiblingSerialFactory;
  
      const gl::Context *mContext;
  };
  
  }  // namespace rx
  
  #endif  // LIBANGLE_RENDERER_VULKAN_IMAGEVK_H_
  

Download