Hash :
6f959e07
Author :
Date :
2023-04-28T16:00:11
Vulkan: Add non-device memory option for VMA image * Updated the required flags for allocateAndBindMemory() to no longer include VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT, though still preferred. This allows VMA to allocate from another memory type if the device is out of memory. * Added a debug message to indicate when allocated memory for VMA image does not have all the preferred property flags. * Also added a warning in the case of memory allocation fallback. * Added a perf counter to keep track of image allocation fallbacks from the device memory. * deviceMemoryImageAllocationFallbacks * Added a test to make sure that VMA images can still be allocated from other memory types even if device memory is unavailable. * VulkanImageTest.AllocateVMAImageWhenDeviceOOM Bug: b/280304441 Change-Id: Ic452c18ded25345cdb7e271442372b99aede045e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4493483 Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695
//
// Copyright 2021 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// VulkanImageTest.cpp : Tests of EGL_ANGLE_vulkan_image & GL_ANGLE_vulkan_image extensions.
#include "test_utils/ANGLETest.h"
#include "common/debug.h"
#include "test_utils/VulkanHelper.h"
#include "test_utils/angle_test_instantiate.h"
#include "test_utils/gl_raii.h"
namespace angle
{
constexpr GLuint kWidth = 64u;
constexpr GLuint kHeight = 64u;
constexpr GLuint kWhite = 0xffffffff;
constexpr GLuint kRed = 0xff0000ff;
class VulkanImageTest : public ANGLETest<>
{
protected:
VulkanImageTest() { setRobustResourceInit(true); }
angle::VulkanPerfCounters getPerfCounters()
{
if (mIndexMap.empty())
{
mIndexMap = BuildCounterNameToIndexMap();
}
return GetPerfCounters(mIndexMap);
}
CounterNameToIndexMap mIndexMap;
};
// Check extensions with Vukan backend.
TEST_P(VulkanImageTest, HasVulkanImageExtensions)
{
ANGLE_SKIP_TEST_IF(!IsVulkan());
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
EXPECT_TRUE(IsEGLClientExtensionEnabled("EGL_EXT_device_query"));
EXPECT_TRUE(IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
EXPECT_TRUE(IsGLExtensionEnabled("GL_ANGLE_vulkan_image"));
EGLAttrib result = 0;
EXPECT_EGL_TRUE(eglQueryDisplayAttribEXT(display, EGL_DEVICE_EXT, &result));
EGLDeviceEXT device = reinterpret_cast<EGLDeviceEXT>(result);
EXPECT_NE(EGL_NO_DEVICE_EXT, device);
EXPECT_TRUE(IsEGLDeviceExtensionEnabled(device, "EGL_ANGLE_device_vulkan"));
}
TEST_P(VulkanImageTest, DeviceVulkan)
{
ANGLE_SKIP_TEST_IF(!IsVulkan());
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
EGLAttrib result = 0;
EXPECT_EGL_TRUE(eglQueryDisplayAttribEXT(display, EGL_DEVICE_EXT, &result));
EGLDeviceEXT device = reinterpret_cast<EGLDeviceEXT>(result);
EXPECT_NE(EGL_NO_DEVICE_EXT, device);
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_INSTANCE_ANGLE, &result));
VkInstance instance = reinterpret_cast<VkInstance>(result);
EXPECT_NE(instance, static_cast<VkInstance>(VK_NULL_HANDLE));
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_PHYSICAL_DEVICE_ANGLE, &result));
VkPhysicalDevice physical_device = reinterpret_cast<VkPhysicalDevice>(result);
EXPECT_NE(physical_device, static_cast<VkPhysicalDevice>(VK_NULL_HANDLE));
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_DEVICE_ANGLE, &result));
VkDevice vk_device = reinterpret_cast<VkDevice>(result);
EXPECT_NE(vk_device, static_cast<VkDevice>(VK_NULL_HANDLE));
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_QUEUE_ANGLE, &result));
VkQueue queue = reinterpret_cast<VkQueue>(result);
EXPECT_NE(queue, static_cast<VkQueue>(VK_NULL_HANDLE));
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_QUEUE_FAMILIY_INDEX_ANGLE, &result));
{
EXPECT_EGL_TRUE(
eglQueryDeviceAttribEXT(device, EGL_VULKAN_DEVICE_EXTENSIONS_ANGLE, &result));
const char *const *extensions = reinterpret_cast<const char *const *>(result);
EXPECT_NE(extensions, nullptr);
int extension_count = 0;
while (extensions[extension_count])
{
extension_count++;
}
EXPECT_NE(extension_count, 0);
}
{
EXPECT_EGL_TRUE(
eglQueryDeviceAttribEXT(device, EGL_VULKAN_INSTANCE_EXTENSIONS_ANGLE, &result));
const char *const *extensions = reinterpret_cast<const char *const *>(result);
EXPECT_NE(extensions, nullptr);
int extension_count = 0;
while (extensions[extension_count])
{
extension_count++;
}
EXPECT_NE(extension_count, 0);
}
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_FEATURES_ANGLE, &result));
const VkPhysicalDeviceFeatures2KHR *features =
reinterpret_cast<const VkPhysicalDeviceFeatures2KHR *>(result);
EXPECT_NE(features, nullptr);
EXPECT_EQ(features->sType, VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2);
EXPECT_EGL_TRUE(eglQueryDeviceAttribEXT(device, EGL_VULKAN_GET_INSTANCE_PROC_ADDR, &result));
PFN_vkGetInstanceProcAddr get_instance_proc_addr =
reinterpret_cast<PFN_vkGetInstanceProcAddr>(result);
EXPECT_NE(get_instance_proc_addr, nullptr);
}
TEST_P(VulkanImageTest, ExportVKImage)
{
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
GLTexture texture;
glBindTexture(GL_TEXTURE_2D, texture);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
glBindTexture(GL_TEXTURE_2D, 0);
EXPECT_GL_NO_ERROR();
EGLContext context = window->getContext();
EGLImageKHR eglImage = eglCreateImageKHR(
display, context, EGL_GL_TEXTURE_2D_KHR,
reinterpret_cast<EGLClientBuffer>(static_cast<uintptr_t>(texture)), nullptr);
EXPECT_NE(eglImage, EGL_NO_IMAGE_KHR);
VkImage vkImage = VK_NULL_HANDLE;
VkImageCreateInfo info = {};
EXPECT_EGL_TRUE(eglExportVkImageANGLE(display, eglImage, &vkImage, &info));
EXPECT_NE(vkImage, static_cast<VkImage>(VK_NULL_HANDLE));
EXPECT_EQ(info.sType, VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
EXPECT_EQ(info.pNext, nullptr);
EXPECT_EQ(info.imageType, VK_IMAGE_TYPE_2D);
EXPECT_EQ(info.format, VK_FORMAT_R8G8B8A8_UNORM);
EXPECT_EQ(info.extent.width, kWidth);
EXPECT_EQ(info.extent.height, kHeight);
EXPECT_EQ(info.extent.depth, 1u);
EXPECT_EQ(info.queueFamilyIndexCount, 0u);
EXPECT_EQ(info.pQueueFamilyIndices, nullptr);
EXPECT_EQ(info.initialLayout, VK_IMAGE_LAYOUT_UNDEFINED);
EXPECT_EGL_TRUE(eglDestroyImageKHR(display, eglImage));
}
// Check pixels after glTexImage2D
TEST_P(VulkanImageTest, PixelTestTexImage2D)
{
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
VulkanHelper helper;
helper.initializeFromANGLE();
constexpr GLuint kColor = 0xafbfcfdf;
GLTexture texture;
{
glBindTexture(GL_TEXTURE_2D, texture);
std::vector<GLuint> pixels(kWidth * kHeight, kColor);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE,
pixels.data());
glBindTexture(GL_TEXTURE_2D, 0);
}
EGLContext context = window->getContext();
EGLImageKHR eglImage = eglCreateImageKHR(
display, context, EGL_GL_TEXTURE_2D_KHR,
reinterpret_cast<EGLClientBuffer>(static_cast<uintptr_t>(texture)), nullptr);
EXPECT_NE(eglImage, EGL_NO_IMAGE_KHR);
VkImage vkImage = VK_NULL_HANDLE;
VkImageCreateInfo info = {};
EXPECT_EGL_TRUE(eglExportVkImageANGLE(display, eglImage, &vkImage, &info));
EXPECT_NE(vkImage, static_cast<VkImage>(VK_NULL_HANDLE));
GLuint textures[1] = {texture};
GLenum layouts[1] = {GL_NONE};
glReleaseTexturesANGLE(1, textures, layouts);
EXPECT_EQ(layouts[0], static_cast<GLenum>(GL_LAYOUT_TRANSFER_DST_EXT));
{
std::vector<GLuint> pixels(kWidth * kHeight);
helper.readPixels(vkImage, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, info.format, {},
info.extent, pixels.data(), pixels.size() * sizeof(GLuint));
EXPECT_EQ(pixels, std::vector<GLuint>(kWidth * kHeight, kColor));
}
layouts[0] = GL_LAYOUT_TRANSFER_SRC_EXT;
glAcquireTexturesANGLE(1, textures, layouts);
EXPECT_GL_NO_ERROR();
EXPECT_EGL_TRUE(eglDestroyImageKHR(display, eglImage));
}
// Check pixels after glClear
TEST_P(VulkanImageTest, PixelTestClear)
{
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
VulkanHelper helper;
helper.initializeFromANGLE();
GLTexture texture;
glBindTexture(GL_TEXTURE_2D, texture);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
glBindTexture(GL_TEXTURE_2D, 0);
EGLContext context = window->getContext();
EGLImageKHR eglImage = eglCreateImageKHR(
display, context, EGL_GL_TEXTURE_2D_KHR,
reinterpret_cast<EGLClientBuffer>(static_cast<uintptr_t>(texture)), nullptr);
EXPECT_NE(eglImage, EGL_NO_IMAGE_KHR);
VkImage vkImage = VK_NULL_HANDLE;
VkImageCreateInfo info = {};
EXPECT_EGL_TRUE(eglExportVkImageANGLE(display, eglImage, &vkImage, &info));
EXPECT_NE(vkImage, static_cast<VkImage>(VK_NULL_HANDLE));
GLFramebuffer framebuffer;
glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
EXPECT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
glViewport(0, 0, kWidth, kHeight);
// clear framebuffer with white color.
glClearColor(1.f, 1.f, 1.f, 1.f);
glClear(GL_COLOR_BUFFER_BIT);
GLuint textures[1] = {texture};
GLenum layouts[1] = {GL_NONE};
glReleaseTexturesANGLE(1, textures, layouts);
EXPECT_EQ(layouts[0], static_cast<GLenum>(GL_LAYOUT_TRANSFER_DST_EXT));
std::vector<GLuint> pixels(kWidth * kHeight);
helper.readPixels(vkImage, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, info.format, {}, info.extent,
pixels.data(), pixels.size() * sizeof(GLuint));
EXPECT_EQ(pixels, std::vector<GLuint>(kWidth * kHeight, kWhite));
layouts[0] = GL_LAYOUT_TRANSFER_SRC_EXT;
glAcquireTexturesANGLE(1, textures, layouts);
// clear framebuffer with red color.
glClearColor(1.f, 0.f, 0.f, 1.f);
glClear(GL_COLOR_BUFFER_BIT);
glReleaseTexturesANGLE(1, textures, layouts);
EXPECT_EQ(layouts[0], static_cast<GLenum>(GL_LAYOUT_TRANSFER_DST_EXT));
helper.readPixels(vkImage, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, info.format, {}, info.extent,
pixels.data(), pixels.size() * sizeof(GLuint));
EXPECT_EQ(pixels, std::vector<GLuint>(kWidth * kHeight, kRed));
layouts[0] = GL_LAYOUT_TRANSFER_SRC_EXT;
glAcquireTexturesANGLE(1, textures, layouts);
EXPECT_GL_NO_ERROR();
EXPECT_EGL_TRUE(eglDestroyImageKHR(display, eglImage));
glBindFramebuffer(GL_FRAMEBUFFER, 0);
}
// Check pixels after GL draw.
TEST_P(VulkanImageTest, PixelTestDrawQuad)
{
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
VulkanHelper helper;
helper.initializeFromANGLE();
GLTexture texture;
glBindTexture(GL_TEXTURE_2D, texture);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
glBindTexture(GL_TEXTURE_2D, 0);
EGLContext context = window->getContext();
EGLImageKHR eglImage = eglCreateImageKHR(
display, context, EGL_GL_TEXTURE_2D_KHR,
reinterpret_cast<EGLClientBuffer>(static_cast<uintptr_t>(texture)), nullptr);
EXPECT_NE(eglImage, EGL_NO_IMAGE_KHR);
GLFramebuffer framebuffer;
glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
EXPECT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
glViewport(0, 0, kWidth, kHeight);
// clear framebuffer with black color.
glClearColor(0.f, 0.f, 0.f, 0.f);
glClear(GL_COLOR_BUFFER_BIT);
// draw red quad
ANGLE_GL_PROGRAM(drawRed, essl1_shaders::vs::Simple(), essl1_shaders::fs::Red());
drawQuad(drawRed, essl1_shaders::PositionAttrib(), 0.5f);
GLuint textures[1] = {texture};
GLenum layouts[1] = {GL_NONE};
glReleaseTexturesANGLE(1, textures, layouts);
EXPECT_EQ(layouts[0], static_cast<GLenum>(GL_LAYOUT_COLOR_ATTACHMENT_EXT));
VkImage vkImage = VK_NULL_HANDLE;
VkImageCreateInfo info = {};
EXPECT_EGL_TRUE(eglExportVkImageANGLE(display, eglImage, &vkImage, &info));
EXPECT_NE(vkImage, static_cast<VkImage>(VK_NULL_HANDLE));
std::vector<GLuint> pixels(kWidth * kHeight);
helper.readPixels(vkImage, VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, info.format, {},
info.extent, pixels.data(), pixels.size() * sizeof(GLuint));
EXPECT_EQ(pixels, std::vector<GLuint>(kWidth * kHeight, kRed));
layouts[0] = GL_LAYOUT_TRANSFER_SRC_EXT;
glAcquireTexturesANGLE(1, textures, layouts);
EXPECT_GL_NO_ERROR();
EXPECT_EGL_TRUE(eglDestroyImageKHR(display, eglImage));
glBindFramebuffer(GL_FRAMEBUFFER, 0);
}
// Test importing VkImage with eglCreateImageKHR
TEST_P(VulkanImageTest, ClientBuffer)
{
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
VulkanHelper helper;
helper.initializeFromANGLE();
constexpr VkImageUsageFlags kDefaultImageUsageFlags =
VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT |
VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT |
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT;
VkImage vkImage = VK_NULL_HANDLE;
VkDeviceMemory vkDeviceMemory = VK_NULL_HANDLE;
VkDeviceSize deviceSize = 0u;
VkImageCreateInfo imageCreateInfo = {};
VkResult result = VK_SUCCESS;
result = helper.createImage2D(VK_FORMAT_R8G8B8A8_UNORM, 0, kDefaultImageUsageFlags,
{kWidth, kHeight, 1}, &vkImage, &vkDeviceMemory, &deviceSize,
&imageCreateInfo);
EXPECT_EQ(result, VK_SUCCESS);
EXPECT_EQ(imageCreateInfo.sType, VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
uint64_t info = reinterpret_cast<uint64_t>(&imageCreateInfo);
EGLint attribs[] = {
EGL_VULKAN_IMAGE_CREATE_INFO_HI_ANGLE,
static_cast<EGLint>((info >> 32) & 0xffffffff),
EGL_VULKAN_IMAGE_CREATE_INFO_LO_ANGLE,
static_cast<EGLint>(info & 0xffffffff),
EGL_NONE,
};
EGLImageKHR eglImage = eglCreateImageKHR(display, EGL_NO_CONTEXT, EGL_VULKAN_IMAGE_ANGLE,
reinterpret_cast<EGLClientBuffer>(&vkImage), attribs);
EXPECT_NE(eglImage, EGL_NO_IMAGE_KHR);
GLTexture texture;
glBindTexture(GL_TEXTURE_2D, texture);
glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, eglImage);
GLuint textures[1] = {texture};
GLenum layouts[1] = {GL_NONE};
glAcquireTexturesANGLE(1, textures, layouts);
GLFramebuffer framebuffer;
glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
EXPECT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
glViewport(0, 0, kWidth, kHeight);
// clear framebuffer with white color.
glClearColor(1.f, 1.f, 1.f, 1.f);
glClear(GL_COLOR_BUFFER_BIT);
textures[0] = texture;
layouts[0] = GL_NONE;
glReleaseTexturesANGLE(1, textures, layouts);
EXPECT_EQ(layouts[0], static_cast<GLenum>(GL_LAYOUT_TRANSFER_DST_EXT));
std::vector<GLuint> pixels(kWidth * kHeight);
helper.readPixels(vkImage, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, imageCreateInfo.format, {},
imageCreateInfo.extent, pixels.data(), pixels.size() * sizeof(GLuint));
EXPECT_EQ(pixels, std::vector<GLuint>(kWidth * kHeight, kWhite));
layouts[0] = GL_LAYOUT_TRANSFER_SRC_EXT;
glAcquireTexturesANGLE(1, textures, layouts);
// clear framebuffer with red color.
glClearColor(1.f, 0.f, 0.f, 1.f);
glClear(GL_COLOR_BUFFER_BIT);
glReleaseTexturesANGLE(1, textures, layouts);
EXPECT_EQ(layouts[0], static_cast<GLenum>(GL_LAYOUT_TRANSFER_DST_EXT));
helper.readPixels(vkImage, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL, imageCreateInfo.format, {},
imageCreateInfo.extent, pixels.data(), pixels.size() * sizeof(GLuint));
EXPECT_EQ(pixels, std::vector<GLuint>(kWidth * kHeight, kRed));
EXPECT_GL_NO_ERROR();
glBindFramebuffer(GL_FRAMEBUFFER, 0);
framebuffer.reset();
texture.reset();
glFinish();
EXPECT_EGL_TRUE(eglDestroyImageKHR(display, eglImage));
vkDestroyImage(helper.getDevice(), vkImage, nullptr);
vkFreeMemory(helper.getDevice(), vkDeviceMemory, nullptr);
}
// Test importing VkImage with eglCreateImageKHR and drawing to make sure no errors occur in setting
// up the framebuffer, including an imageless framebuffer.
TEST_P(VulkanImageTest, ClientBufferWithDraw)
{
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
VulkanHelper helper;
helper.initializeFromANGLE();
constexpr VkImageUsageFlags kDefaultImageUsageFlags =
VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT |
VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT |
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT;
VkImage vkImage = VK_NULL_HANDLE;
VkDeviceMemory vkDeviceMemory = VK_NULL_HANDLE;
VkDeviceSize deviceSize = 0u;
VkImageCreateInfo imageCreateInfo = {};
VkResult result = VK_SUCCESS;
result = helper.createImage2D(VK_FORMAT_R8G8B8A8_UNORM, 0, kDefaultImageUsageFlags,
{kWidth, kHeight, 1}, &vkImage, &vkDeviceMemory, &deviceSize,
&imageCreateInfo);
EXPECT_EQ(result, VK_SUCCESS);
EXPECT_EQ(imageCreateInfo.sType, VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
uint64_t info = reinterpret_cast<uint64_t>(&imageCreateInfo);
EGLint attribs[] = {
EGL_VULKAN_IMAGE_CREATE_INFO_HI_ANGLE,
static_cast<EGLint>((info >> 32) & 0xffffffff),
EGL_VULKAN_IMAGE_CREATE_INFO_LO_ANGLE,
static_cast<EGLint>(info & 0xffffffff),
EGL_NONE,
};
EGLImageKHR eglImage = eglCreateImageKHR(display, EGL_NO_CONTEXT, EGL_VULKAN_IMAGE_ANGLE,
reinterpret_cast<EGLClientBuffer>(&vkImage), attribs);
EXPECT_NE(eglImage, EGL_NO_IMAGE_KHR);
GLTexture texture;
glBindTexture(GL_TEXTURE_2D, texture);
glEGLImageTargetTexture2DOES(GL_TEXTURE_2D, eglImage);
GLuint textures[1] = {texture};
GLenum layouts[1] = {GL_NONE};
glAcquireTexturesANGLE(1, textures, layouts);
GLFramebuffer framebuffer;
glBindFramebuffer(GL_FRAMEBUFFER, framebuffer);
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
EXPECT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
ANGLE_GL_PROGRAM(drawGreen, essl1_shaders::vs::Simple(), essl1_shaders::fs::Green());
drawQuad(drawGreen, essl1_shaders::PositionAttrib(), 0.5f);
EXPECT_GL_NO_ERROR();
glBindFramebuffer(GL_FRAMEBUFFER, 0);
framebuffer.reset();
texture.reset();
glFinish();
EXPECT_EGL_TRUE(eglDestroyImageKHR(display, eglImage));
vkDestroyImage(helper.getDevice(), vkImage, nullptr);
vkFreeMemory(helper.getDevice(), vkDeviceMemory, nullptr);
}
// Test that when VMA image suballocation is used, image memory can be allocated from the system in
// case the device memory runs out.
TEST_P(VulkanImageTest, AllocateVMAImageWhenDeviceOOM)
{
ANGLE_SKIP_TEST_IF(!getEGLWindow()->isFeatureEnabled(Feature::UseVmaForImageSuballocation));
VulkanHelper helper;
helper.initializeFromANGLE();
uint64_t expectedAllocationFallbacks =
getPerfCounters().deviceMemoryImageAllocationFallbacks + 1;
uint64_t expectedAllocationFallbacksAfterLastTexture =
getPerfCounters().deviceMemoryImageAllocationFallbacks + 2;
// Acquire the sizes and memory property flags for all available memory types. There should be
// at least one memory heap without the device local bit (VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT).
// Otherwise, the test should be skipped.
VkPhysicalDeviceMemoryProperties memoryProperties;
vkGetPhysicalDeviceMemoryProperties(helper.getPhysicalDevice(), &memoryProperties);
VkDeviceSize totalDeviceLocalMemoryHeapSize = 0;
uint32_t heapsWithoutLocalDeviceMemoryBit = 0;
for (uint32_t i = 0; i < memoryProperties.memoryHeapCount; i++)
{
if ((memoryProperties.memoryHeaps[i].flags & VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT) == 0)
{
heapsWithoutLocalDeviceMemoryBit++;
}
else
{
totalDeviceLocalMemoryHeapSize += memoryProperties.memoryHeaps[i].size;
}
}
ANGLE_SKIP_TEST_IF(heapsWithoutLocalDeviceMemoryBit == 0 ||
totalDeviceLocalMemoryHeapSize == 0);
// Device memory is the first choice for image memory allocation. However, in case it runs out,
// memory should be allocated from the system if available. Therefore, we want to make sure that
// we can still allocate image memory even if the device memory is full.
constexpr VkDeviceSize kTextureWidth = 2048;
constexpr VkDeviceSize kTextureHeight = 2048;
constexpr VkDeviceSize kTextureSize = kTextureWidth * kTextureHeight * 4;
VkDeviceSize textureCount = (totalDeviceLocalMemoryHeapSize / kTextureSize) + 1;
std::vector<GLTexture> textures;
textures.resize(textureCount);
for (uint32_t i = 0; i < textureCount; i++)
{
glBindTexture(GL_TEXTURE_2D, textures[i]);
glTexStorage2DEXT(GL_TEXTURE_2D, 1, GL_RGBA8, kTextureWidth, kTextureHeight);
glDrawArrays(GL_POINTS, 0, 1);
EXPECT_GL_NO_ERROR();
// This process only needs to continue until the allocation is no longer on the device.
if (getPerfCounters().deviceMemoryImageAllocationFallbacks == expectedAllocationFallbacks)
{
break;
}
}
EXPECT_EQ(getPerfCounters().deviceMemoryImageAllocationFallbacks, expectedAllocationFallbacks);
// Verify that the texture allocated on the system memory can attach to a framebuffer correctly.
GLTexture texture;
std::vector<GLColor> textureColor(kTextureWidth * kTextureHeight, GLColor::magenta);
glBindTexture(GL_TEXTURE_2D, texture);
glTexStorage2DEXT(GL_TEXTURE_2D, 1, GL_RGBA8, kTextureWidth, kTextureHeight);
glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, kTextureWidth, kTextureHeight, GL_RGBA,
GL_UNSIGNED_BYTE, textureColor.data());
EXPECT_EQ(getPerfCounters().deviceMemoryImageAllocationFallbacks,
expectedAllocationFallbacksAfterLastTexture);
GLFramebuffer fbo;
glBindFramebuffer(GL_FRAMEBUFFER, fbo);
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
EXPECT_GL_FRAMEBUFFER_COMPLETE(GL_FRAMEBUFFER);
EXPECT_PIXEL_RECT_EQ(0, 0, kWidth, kHeight, GLColor::magenta);
}
// Test that texture storage created from VkImage memory is considered pre-initialized in GL.
TEST_P(VulkanImageTest, PreInitializedOnGLImport)
{
ANGLE_SKIP_TEST_IF(!EnsureGLExtensionEnabled("GL_EXT_memory_object"));
// http://anglebug.com/5381
ANGLE_SKIP_TEST_IF(IsLinux() && IsAMD() && IsDesktopOpenGL());
EXPECT_TRUE(EnsureGLExtensionEnabled("GL_ANGLE_robust_resource_initialization"));
EGLWindow *window = getEGLWindow();
EGLDisplay display = window->getDisplay();
ANGLE_SKIP_TEST_IF(!IsEGLDisplayExtensionEnabled(display, "EGL_ANGLE_vulkan_image"));
VulkanHelper helper;
helper.initializeFromANGLE();
constexpr VkImageUsageFlags kDefaultImageUsageFlags =
VK_IMAGE_USAGE_TRANSFER_SRC_BIT | VK_IMAGE_USAGE_TRANSFER_DST_BIT |
VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT |
VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT;
ANGLE_SKIP_TEST_IF(!helper.canCreateImageOpaqueFd(VK_FORMAT_R8G8B8A8_UNORM, VK_IMAGE_TYPE_2D,
VK_IMAGE_TILING_OPTIMAL, 0,
kDefaultImageUsageFlags) ||
!helper.canCreateSemaphoreOpaqueFd());
VkImage vkImage = VK_NULL_HANDLE;
VkDeviceMemory vkDeviceMemory = VK_NULL_HANDLE;
VkDeviceSize vkDeviceMemorySize = 0u;
VkResult result = VK_SUCCESS;
result = helper.createImage2DOpaqueFd(VK_FORMAT_R8G8B8A8_UNORM, 0, kDefaultImageUsageFlags,
nullptr, {kWidth, kHeight, 1}, &vkImage, &vkDeviceMemory,
&vkDeviceMemorySize);
EXPECT_EQ(result, VK_SUCCESS);
constexpr uint32_t kPixel = 0x12345678;
helper.writePixels(vkImage, VK_IMAGE_LAYOUT_UNDEFINED, VK_FORMAT_R8G8B8A8_UNORM, {0, 0, 0},
{1, 1, 1}, static_cast<const void *>(&kPixel), sizeof(kPixel));
VkSemaphore vkSemaphore = VK_NULL_HANDLE;
result = helper.createSemaphoreOpaqueFd(&vkSemaphore);
EXPECT_EQ(result, VK_SUCCESS);
// Note: writePixels leaves the image in TRANSFER_DST_OPTIMAL layout.
helper.releaseImageAndSignalSemaphore(vkImage, VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, vkSemaphore);
int semfd = -1;
result = helper.exportSemaphoreOpaqueFd(vkSemaphore, &semfd);
EXPECT_EQ(result, VK_SUCCESS);
int memfd = -1;
result = helper.exportMemoryOpaqueFd(vkDeviceMemory, &memfd);
EXPECT_EQ(result, VK_SUCCESS);
GLuint semaphoreObject = 0u;
glGenSemaphoresEXT(1u, &semaphoreObject);
EXPECT_TRUE(glIsSemaphoreEXT(semaphoreObject));
glImportSemaphoreFdEXT(semaphoreObject, GL_HANDLE_TYPE_OPAQUE_FD_EXT, semfd);
EXPECT_GL_NO_ERROR();
GLuint memoryObject = 0u;
glCreateMemoryObjectsEXT(1u, &memoryObject);
EXPECT_TRUE(glIsMemoryObjectEXT(memoryObject));
glImportMemoryFdEXT(memoryObject, vkDeviceMemorySize, GL_HANDLE_TYPE_OPAQUE_FD_EXT, memfd);
EXPECT_GL_NO_ERROR();
GLuint texture = 0u;
glGenTextures(1u, &texture);
glBindTexture(GL_TEXTURE_2D, texture);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);
glTexStorageMem2DEXT(GL_TEXTURE_2D, 1, GL_RGBA8_OES, 1, 1, memoryObject, 0);
EXPECT_GL_NO_ERROR();
GLenum glLayout = GL_LAYOUT_COLOR_ATTACHMENT_EXT;
glWaitSemaphoreEXT(semaphoreObject, 0, nullptr, 1, &texture, &glLayout);
EXPECT_GL_NO_ERROR();
GLuint fbo = 0u;
glGenFramebuffers(1u, &fbo);
glBindFramebuffer(GL_FRAMEBUFFER, fbo);
glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D, texture, 0);
EXPECT_GL_NO_ERROR();
uint32_t pixel = 0u;
glReadPixels(0, 0, 1, 1, GL_RGBA, GL_UNSIGNED_BYTE, &pixel);
EXPECT_GL_NO_ERROR();
EXPECT_EQ(pixel, kPixel);
vkDestroySemaphore(helper.getDevice(), vkSemaphore, nullptr);
vkDestroyImage(helper.getDevice(), vkImage, nullptr);
vkFreeMemory(helper.getDevice(), vkDeviceMemory, nullptr);
}
// Use this to select which configurations (e.g. which renderer, which GLES major version) these
// tests should be run against.
ANGLE_INSTANTIATE_TEST_ES2_AND_ES3(VulkanImageTest);
} // namespace angle