-
Show log
Commit
-
Hash : 9d9ca90b
Author :
Date : 2023-06-30T15:31:03
Properly validate _ADJACENCY primitive modes. After a refactoring in Issue angleproject:5483 and Issue chromium:1185267, the _ADJACENCY primitive modes were being validated as legal in context versions where they were not supported. Thanks to lehoangquyen@ for an initial version of this CL and one of the two new tests. Verified locally on an ASAN build on macOS (by manually disabling SwiftShader, where ASAN does not work) that the new tests pass cleanly. Test: SimpleOperationTest.PrimitiveModeLinesAdjacentNegativeTest Test: SimpleOperationTest.DrawsWithNoAttributeData Bug: chromium:1457840 Change-Id: Icb0945e0081ca6f97355dc60f75d60c3f4f68565 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4661672 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
-
Files
- AttributeMap.cpp
- AttributeMap.h
- BlendStateExt_unittest.cpp
- BlobCache.cpp
- BlobCache.h
- BlobCache_unittest.cpp
- Buffer.cpp
- Buffer.h
- CLBitField.h
- CLBuffer.cpp
- CLBuffer.h
- CLCommandQueue.cpp
- CLCommandQueue.h
- CLContext.cpp
- CLContext.h
- CLDevice.cpp
- CLDevice.h
- CLEvent.cpp
- CLEvent.h
- CLImage.cpp
- CLImage.h
- CLKernel.cpp
- CLKernel.h
- CLMemory.cpp
- CLMemory.h
- CLObject.cpp
- CLObject.h
- CLPlatform.cpp
- CLPlatform.h
- CLProgram.cpp
- CLProgram.h
- CLRefPointer.h
- CLSampler.cpp
- CLSampler.h
- CLtypes.h
- Caps.cpp
- Caps.h
- Compiler.cpp
- Compiler.h
- Config.cpp
- Config.h
- Config_unittest.cpp
- Constants.h
- Context.cpp
- Context.h
- Context.inl.h
- Context_gl.cpp
- Context_gl_1_autogen.h
- Context_gl_2_autogen.h
- Context_gl_3_autogen.h
- Context_gl_4_autogen.h
- Context_gles_1_0.cpp
- Context_gles_1_0_autogen.h
- Context_gles_2_0_autogen.h
- Context_gles_3_0_autogen.h
- Context_gles_3_1_autogen.h
- Context_gles_3_2_autogen.h
- Context_gles_ext_autogen.h
- Debug.cpp
- Debug.h
- Device.cpp
- Device.h
- Display.cpp
- Display.h
- EGLSync.cpp
- EGLSync.h
- Error.cpp
- Error.h
- Error.inc
- ErrorStrings.h
- Fence.cpp
- Fence.h
- Fence_unittest.cpp
- Framebuffer.cpp
- Framebuffer.h
- FramebufferAttachment.cpp
- FramebufferAttachment.h
- GLES1Renderer.cpp
- GLES1Renderer.h
- GLES1Shaders.inc
- GLES1State.cpp
- GLES1State.h
- GlobalMutex.cpp
- GlobalMutex.h
- GlobalMutex_unittest.cpp
- HandleAllocator.cpp
- HandleAllocator.h
- HandleAllocator_unittest.cpp
- Image.cpp
- Image.h
- ImageIndex.cpp
- ImageIndex.h
- ImageIndexIterator_unittest.cpp
- Image_unittest.cpp
- IndexRangeCache.cpp
- IndexRangeCache.h
- InfoLog.h
- LoggingAnnotator.cpp
- LoggingAnnotator.h
- MemoryObject.cpp
- MemoryObject.h
- MemoryProgramCache.cpp
- MemoryProgramCache.h
- MemoryShaderCache.cpp
- MemoryShaderCache.h
- Observer.cpp
- Observer.h
- Observer_unittest.cpp
- Overlay.cpp
- Overlay.h
- OverlayWidgets.cpp
- OverlayWidgets.h
- Overlay_autogen.cpp
- Overlay_autogen.h
- Overlay_font_autogen.cpp
- Overlay_font_autogen.h
- PixelLocalStorage.cpp
- PixelLocalStorage.h
- Platform.cpp
- Program.cpp
- Program.h
- ProgramExecutable.cpp
- ProgramExecutable.h
- ProgramLinkedResources.cpp
- ProgramLinkedResources.h
- ProgramPipeline.cpp
- ProgramPipeline.h
- Program_unittest.cpp
- Query.cpp
- Query.h
- RefCountObject.h
- Renderbuffer.cpp
- Renderbuffer.h
- ResourceManager.cpp
- ResourceManager.h
- ResourceManager_unittest.cpp
- ResourceMap.h
- ResourceMap_unittest.cpp
- Sampler.cpp
- Sampler.h
- Semaphore.cpp
- Semaphore.h
- Shader.cpp
- Shader.h
- SharedContextMutex.cpp
- SharedContextMutex.h
- SizedMRUCache.h
- SizedMRUCache_unittest.cpp
- State.cpp
- State.h
- Stream.cpp
- Stream.h
- Surface.cpp
- Surface.h
- Surface_unittest.cpp
- Texture.cpp
- Texture.h
- Thread.cpp
- Thread.h
- TransformFeedback.cpp
- TransformFeedback.h
- TransformFeedback_unittest.cpp
- Uniform.cpp
- Uniform.h
- UnlockedTailCall_unittest.cpp
- VaryingPacking.cpp
- VaryingPacking.h
- VaryingPacking_unittest.cpp
- Version.h
- Version.inc
- VertexArray.cpp
- VertexArray.h
- VertexArray_unittest.cpp
- VertexAttribute.cpp
- VertexAttribute.h
- VertexAttribute.inc
- angletypes.cpp
- angletypes.h
- angletypes.inc
- capture/
- cl_utils.cpp
- cl_utils.h
- context_local_call.cpp
- context_local_call_autogen.h
- entry_points_utils.cpp
- entry_points_utils.h
- es3_copy_conversion_formats.json
- es3_copy_conversion_table_autogen.cpp
- es3_format_type_combinations.json
- features.h
- format_map_autogen.cpp
- format_map_data.json
- format_map_desktop.cpp
- formatutils.cpp
- formatutils.h
- gen_copy_conversion_table.py
- gen_extensions.py
- gen_format_map.py
- gen_overlay_fonts.py
- gen_overlay_widgets.py
- gles_extensions_autogen.cpp
- gles_extensions_autogen.h
- histogram_macros.h
- overlay/
- overlay_widgets.json
- queryconversions.cpp
- queryconversions.h
- queryutils.cpp
- queryutils.h
- renderer/
- trace.h
- validationCL.cpp
- validationCL.h
- validationCL_autogen.h
- validationEGL.cpp
- validationEGL.h
- validationEGL_autogen.h
- validationES.cpp
- validationES.h
- validationES1.cpp
- validationES1.h
- validationES1_autogen.h
- validationES2.cpp
- validationES2.h
- validationES2_autogen.h
- validationES3.cpp
- validationES3.h
- validationES31.cpp
- validationES31.h
- validationES31_autogen.h
- validationES32.cpp
- validationES32.h
- validationES32_autogen.h
- validationES3_autogen.h
- validationESEXT.cpp
- validationESEXT.h
- validationESEXT_autogen.h
- validationGL1.cpp
- validationGL11_autogen.h
- validationGL12_autogen.h
- validationGL13_autogen.h
- validationGL14_autogen.h
- validationGL15_autogen.h
- validationGL1_autogen.h
- validationGL2.cpp
- validationGL21_autogen.h
- validationGL2_autogen.h
- validationGL3.cpp
- validationGL31_autogen.h
- validationGL32_autogen.h
- validationGL33_autogen.h
- validationGL3_autogen.h
- validationGL4.cpp
- validationGL41_autogen.h
- validationGL42_autogen.h
- validationGL43_autogen.h
- validationGL44_autogen.h
- validationGL45_autogen.h
- validationGL46_autogen.h
- validationGL4_autogen.h
