Branch : - branch - main - tag -

• Show log

  Commit

• Author : Yuly Novikov
  Date : 2024-08-27 10:07:26
  Hash : 5a8eab96
  Message : Revert "Vulkan: Expose float control properties as angle features" This reverts commit 027cbe1a071f41a09d596c4baa243a0abc3d1a86. Reason for revert: removes needed suppressions, breaking bots: https://ci.chromium.org/ui/p/angle/builders/ci/win-exp-test/569/overview https://ci.chromium.org/ui/p/angle/builders/ci/linux-exp-test/810/overview https://ci.chromium.org/ui/p/angle/builders/ci/android-arm64-exp-s22-test/1060/overview Original change's description: > Vulkan: Expose float control properties as angle features > > The different fp configuration that a vulkan backend supports are > exposed through `VkPhysicalDeviceFloatControlsProperties`. Expose these > as angle features that api's implementations can query. > > The autogen files are changes as reported by running `python3 > scripts/run_code_generation.py` script. > > Bug: angleproject:360031000 > Change-Id: I038cbf2c9e2b10916697994782ef73b35a1caf12 > Signed-off-by: Gowtham Tammana <g.tammana@samsung.com> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5798053 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Charlie Lao <cclao@google.com> Bug: angleproject:360031000 Change-Id: I88c0a083725320b5e1a8302a50f67d41cbf5c089 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5816829 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

• Files
• AllocatorHelperPool.cpp
• AllocatorHelperPool.h
• AllocatorHelperRing.cpp
• AllocatorHelperRing.h
• BUILD.gn
• BufferVk.cpp
• BufferVk.h
• CLCommandQueueVk.cpp
• CLCommandQueueVk.h
• CLContextVk.cpp
• CLContextVk.h
• CLDeviceVk.cpp
• CLDeviceVk.h
• CLEventVk.cpp
• CLEventVk.h
• CLKernelVk.cpp
• CLKernelVk.h
• CLMemoryVk.cpp
• CLMemoryVk.h
• CLPlatformVk.cpp
• CLPlatformVk.h
• CLProgramVk.cpp
• CLProgramVk.h
• CLSamplerVk.cpp
• CLSamplerVk.h
• CommandProcessor.cpp
• CommandProcessor.h
• CompilerVk.cpp
• CompilerVk.h
• ContextVk.cpp
• ContextVk.h
• DebugAnnotatorVk.cpp
• DebugAnnotatorVk.h
• DeviceVk.cpp
• DeviceVk.h
• DisplayVk.cpp
• DisplayVk.h
• DisplayVk_api.h
• FenceNVVk.cpp
• FenceNVVk.h
• FramebufferVk.cpp
• FramebufferVk.h
• ImageVk.cpp
• ImageVk.h
• MemoryObjectVk.cpp
• MemoryObjectVk.h
• MemoryTracking.cpp
• MemoryTracking.h
• OWNERS
• OverlayVk.cpp
• OverlayVk.h
• PersistentCommandPool.cpp
• PersistentCommandPool.h
• ProgramExecutableVk.cpp
• ProgramExecutableVk.h
• ProgramPipelineVk.cpp
• ProgramPipelineVk.h
• ProgramVk.cpp
• ProgramVk.h
• QueryVk.cpp
• QueryVk.h
• README.md
• RenderTargetVk.cpp
• RenderTargetVk.h
• RenderbufferVk.cpp
• RenderbufferVk.h
• SamplerVk.cpp
• SamplerVk.h
• SecondaryCommandBuffer.cpp
• SecondaryCommandBuffer.h
• SecondaryCommandPool.cpp
• SecondaryCommandPool.h
• SemaphoreVk.cpp
• SemaphoreVk.h
• ShaderInterfaceVariableInfoMap.cpp
• ShaderInterfaceVariableInfoMap.h
• ShaderVk.cpp
• ShaderVk.h
• ShareGroupVk.cpp
• ShareGroupVk.h
• Suballocation.cpp
• Suballocation.h
• SurfaceVk.cpp
• SurfaceVk.h
• SyncVk.cpp
• SyncVk.h
• TextureVk.cpp
• TextureVk.h
• TransformFeedbackVk.cpp
• TransformFeedbackVk.h
• UtilsVk.cpp
• UtilsVk.h
• VertexArrayVk.cpp
• VertexArrayVk.h
• VkImageImageSiblingVk.cpp
• VkImageImageSiblingVk.h
• VulkanSecondaryCommandBuffer.cpp
• VulkanSecondaryCommandBuffer.h
• android
• cl_types.h
• doc
• fuchsia
• gen_vk_format_table.py
• gen_vk_internal_shaders.py
• gen_vk_mandatory_format_support_table.py
• ggp
• linux
• mac
• null
• shaders
• spv_utils.cpp
• spv_utils.h
• vk_cache_utils.cpp
• vk_cache_utils.h
• vk_caps_utils.cpp
• vk_caps_utils.h
• vk_command_buffer_utils.h
• vk_format_map.json
• vk_format_table_autogen.cpp
• vk_format_utils.cpp
• vk_format_utils.h
• vk_helpers.cpp
• vk_helpers.h
• vk_internal_shaders_autogen.cpp
• vk_internal_shaders_autogen.gni
• vk_internal_shaders_autogen.h
• vk_mandatory_format_support_data.json
• vk_mandatory_format_support_table_autogen.cpp
• vk_mem_alloc_wrapper.cpp
• vk_mem_alloc_wrapper.h
• vk_ref_counted_event.cpp
• vk_ref_counted_event.h
• vk_renderer.cpp
• vk_renderer.h
• vk_resource.cpp
• vk_resource.h
• vk_utils.cpp
• vk_utils.h
• vk_wrapper.h
• vulkan_backend.gni
• win32

• README.md

• ANGLE: Vulkan Back-end

  ANGLE's Vulkan back-end implementation lives in this folder.

  Vulkan is an explicit graphics API. It has a lot in common with other explicit APIs such as Microsoft's D3D12 and Apple's Metal. Compared to APIs like OpenGL or D3D11 explicit APIs can offer a number of significant benefits:

  • Lower API call CPU overhead.
  • A smaller API surface with more direct hardware control.
  • Better support for multi-core programming.
  • Vulkan in particular has open-source tooling and tests.

  Back-end Design

  The vk::Renderer class represents an EGLDisplay. vk::Renderer owns shared global resources like the VkDevice, VkQueue, the Vulkan format tables and internal Vulkan shaders. The ContextVk class implements the back-end of a front-end OpenGL Context. ContextVk processes state changes and handles action commands like glDrawArrays and glDrawElements.

  Command recording

  A render pass has three states: unstarted, started and active (we call it active in short), started but inactive (we call it inactive in short). The back-end records commands into command buffers via the following ContextVk APIs:

  • beginNewRenderPass: Writes out (aka flushes) prior pending commands into a primary command buffer, then starts a new render pass. Returns a secondary command buffer inside a render pass instance.
  • getOutsideRenderPassCommandBuffer: May flush prior command buffers and close the render pass if necessary, in addition to issuing the appropriate barriers. Returns a secondary command buffer outside a render pass instance.
  • getStartedRenderPassCommands: Returns a reference to the currently open render pass' commands buffer.
  • onRenderPassFinished: Puts render pass into inactive state where you can not record more commands into secondary command buffer, except in some special cases where ANGLE does some optimization internally.
  • flushCommandsAndEndRenderPassWithoutSubmit: Marks the end of render pass. It flushes secondary command buffer into vulkan's primary command buffer, puts secondary command buffer back to unstarted state and then goes into recycler for reuse.

  The back-end (mostly) records Image and Buffer barriers through additional CommandBufferAccess APIs, the result of which is passed to getOutsideRenderPassCommandBuffer. Note that the barriers are not actually recorded until getOutsideRenderPassCommandBuffer is called:

  • onBufferTransferRead and onBufferComputeShaderRead accumulate VkBuffer read barriers.
  • onBufferTransferWrite and onBufferComputeShaderWrite accumulate VkBuffer write barriers.
  • onBuffferSelfCopy is a special case for VkBuffer self copies. It behaves the same as write.
  • onImageTransferRead and onImageComputerShadeRead accumulate VkImage read barriers.
  • onImageTransferWrite and onImageComputerShadeWrite accumulate VkImage write barriers.
  • onImageRenderPassRead and onImageRenderPassWrite accumulate VkImage barriers inside a started RenderPass.

  After the back-end records commands to the primary buffer and we flush (e.g. on swap) or when we call vk::Renderer::finishQueueSerial, ANGLE submits the primary command buffer to a VkQueue.

  See the code for more details.

  Simple command recording example

  In this example we'll be recording a buffer copy command:

      // Ensure that ANGLE sets proper read and write barriers for the Buffers.
      vk::CommandBufferAccess access;
      access.onBufferTransferWrite(dstBuffer);
      access.onBufferTransferRead(srcBuffer);
  
      // Get a pointer to a secondary command buffer for command recording.
      vk::OutsideRenderPassCommandBuffer *commandBuffer;
      ANGLE_TRY(contextVk->getOutsideRenderPassCommandBuffer(access, &commandBuffer));
  
      // Record the copy command into the secondary buffer. We're done!
      commandBuffer->copyBuffer(srcBuffer->getBuffer(), dstBuffer->getBuffer(), copyCount, copies);
  

  Additional Reading

  More implementation details can be found in the doc directory:

  • Fast OpenGL State Transitions
  • Shader Module Compilation
  • OpenGL Line Segment Rasterization
  • Format Tables and Emulation
  • Deferred Clears
  • Queries