-
Show log
Commit
-
Hash : 2cacb778
Author :
Date : 2016-09-26T08:50:40
Fix folding shifts when operands have different signedness The code used to incorrectly assert that the right-hand side of shift should have the same signedness as the left-hand side. Instead simply assert that both the lhs and rhs are integer typed, and also don't rely on aliasing via union when accessing bit shift operands. Also disallow constant folded bit shifts where the right hand side is greater than 31. Shifting with values greater than the width of the type has undefined results in both ESSL and C++. BUG=chromium:648135 TEST=angle_unittests Change-Id: I84a99abc55f0eeda549b4781e954d17ba7b87552 Reviewed-on: https://chromium-review.googlesource.com/389351 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
-
Files
- API_test.cpp
- CollectVariables_test.cpp
- ConstantFolding_test.cpp
- DebugShaderPrecision_test.cpp
- EXT_blend_func_extended_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- IntermNode_test.cpp
- MalformedShader_test.cpp
- NV_draw_buffers_test.cpp
- Pack_Unpack_test.cpp
- PruneEmptyDeclarations_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RemovePow_test.cpp
- ShCompile_test.cpp
- ShaderExtension_test.cpp
- ShaderVariable_test.cpp
- TypeTracking_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- WorkGroupSize_test.cpp
