Surface_unittest.cpp

Branch :

Show log
Commit
Author : Corentin Wallez
Date : 2015-08-17 11:24:37
Hash : f0435bc8
Message : Surface_unittest: fix a gmock warning getSwapBehavior was being called in Surface's constructor but masn't expected, causing a warning. Add it as an expect call. BUG=angleproject:1126 Change-Id: Idf4a7e0ff66ba5741d3773e09ade4a1335b355ae Reviewed-on: https://chromium-review.googlesource.com/293902 Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Corentin Wallez <cwallez@chromium.org>

src/libANGLE/Surface_unittest.cpp

//
// Copyright (c) 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//

#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include "libANGLE/AttributeMap.h"
#include "libANGLE/Config.h"
#include "libANGLE/Surface.h"
#include "libANGLE/renderer/SurfaceImpl.h"

namespace
{

class MockSurfaceImpl : public rx::SurfaceImpl
{
  public:
    virtual ~MockSurfaceImpl() { destroy(); }

    MOCK_METHOD0(initialize, egl::Error());
    MOCK_METHOD0(swap, egl::Error());
    MOCK_METHOD4(postSubBuffer, egl::Error(EGLint, EGLint, EGLint, EGLint));
    MOCK_METHOD2(querySurfacePointerANGLE, egl::Error(EGLint, void**));
    MOCK_METHOD1(bindTexImage, egl::Error(EGLint));
    MOCK_METHOD1(releaseTexImage, egl::Error(EGLint));
    MOCK_METHOD1(setSwapInterval, void(EGLint));
    MOCK_CONST_METHOD0(getWidth, EGLint());
    MOCK_CONST_METHOD0(getHeight, EGLint());
    MOCK_CONST_METHOD0(isPostSubBufferSupported, EGLint(void));
    MOCK_CONST_METHOD0(getSwapBehavior, EGLint(void));
    MOCK_METHOD2(getAttachmentRenderTarget, gl::Error(const gl::FramebufferAttachment::Target &, rx::FramebufferAttachmentRenderTarget **));

    MOCK_METHOD0(destroy, void());
};

class SurfaceTest : public testing::Test
{
  protected:
    virtual void SetUp()
    {
        mImpl = new MockSurfaceImpl;
        EXPECT_CALL(*mImpl, getSwapBehavior());
        EXPECT_CALL(*mImpl, destroy());
        mSurface = new egl::Surface(mImpl, EGL_WINDOW_BIT, &mConfig, egl::AttributeMap());
    }

    virtual void TearDown()
    {
        mSurface->release();
    }

    MockSurfaceImpl *mImpl;
    egl::Surface *mSurface;
    egl::Config mConfig;
};

TEST_F(SurfaceTest, DestructionDeletesImpl)
{
    MockSurfaceImpl *impl = new MockSurfaceImpl;
    EXPECT_CALL(*impl, getSwapBehavior());
    EXPECT_CALL(*impl, destroy()).Times(1).RetiresOnSaturation();

    egl::Surface *surface = new egl::Surface(impl, EGL_WINDOW_BIT, &mConfig, egl::AttributeMap());
    surface->release();

    // Only needed because the mock is leaked if bugs are present,
    // which logs an error, but does not cause the test to fail.
    // Ordinarily mocks are verified when destroyed.
    testing::Mock::VerifyAndClear(impl);
}

} // namespace

kc3-lang/angle/src/libANGLE/Surface_unittest.cpp

Commit

kc3-lang/angle /src/libANGLE/Surface_unittest.cpp