Hash :
ad18dc93
Author :
Date :
2025-04-02T16:23:50
D3D11: Remove the message from Buffer11 to gl::Buffer This CL removes the D3D back end's usage of Subject/Observer from Buffer11 to gl::Buffer. BufferFeedback argument has been added to various functions and directly applied to gl::Buffer object (which will propagate to VertexArray and texture/XFB if needed). gl::Buffer::mImplObserver is removed in this CL, and no longer a Observer. Bug: angleproject:400711938 Change-Id: Idf4d423904d057ab3a1e52acf8e2496df606cb89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6514288 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195
//
// Copyright 2014 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// BufferD3D.cpp Defines common functionality between the Buffer9 and Buffer11 classes.
#include "libANGLE/renderer/d3d/BufferD3D.h"
#include "common/mathutil.h"
#include "common/utilities.h"
#include "libANGLE/renderer/d3d/IndexBuffer.h"
#include "libANGLE/renderer/d3d/RendererD3D.h"
#include "libANGLE/renderer/d3d/VertexBuffer.h"
namespace rx
{
unsigned int BufferD3D::mNextSerial = 1;
BufferD3D::BufferD3D(const gl::BufferState &state, BufferFactoryD3D *factory)
: BufferImpl(state),
mFactory(factory),
mStaticIndexBuffer(nullptr),
mStaticBufferCacheTotalSize(0),
mStaticVertexBufferOutOfDate(false),
mUnmodifiedDataUse(0),
mUsage(D3DBufferUsage::STATIC)
{
updateSerial();
}
BufferD3D::~BufferD3D()
{
SafeDelete(mStaticIndexBuffer);
}
void BufferD3D::emptyStaticBufferCache()
{
mStaticVertexBuffers.clear();
mStaticBufferCacheTotalSize = 0;
}
void BufferD3D::updateSerial()
{
mSerial = mNextSerial++;
}
void BufferD3D::updateD3DBufferUsage(const gl::Context *context,
gl::BufferUsage usage,
BufferFeedback *feedback)
{
switch (usage)
{
case gl::BufferUsage::StaticCopy:
case gl::BufferUsage::StaticDraw:
case gl::BufferUsage::StaticRead:
case gl::BufferUsage::DynamicCopy:
case gl::BufferUsage::DynamicRead:
case gl::BufferUsage::StreamCopy:
case gl::BufferUsage::StreamRead:
mUsage = D3DBufferUsage::STATIC;
initializeStaticData(context, feedback);
break;
case gl::BufferUsage::DynamicDraw:
case gl::BufferUsage::StreamDraw:
mUsage = D3DBufferUsage::DYNAMIC;
break;
default:
UNREACHABLE();
}
}
void BufferD3D::initializeStaticData(const gl::Context *context, BufferFeedback *feedback)
{
if (mStaticVertexBuffers.empty())
{
StaticVertexBufferInterface *newStaticBuffer = new StaticVertexBufferInterface(mFactory);
mStaticVertexBuffers.push_back(
std::unique_ptr<StaticVertexBufferInterface>(newStaticBuffer));
}
if (!mStaticIndexBuffer)
{
mStaticIndexBuffer = new StaticIndexBufferInterface(mFactory);
}
}
StaticIndexBufferInterface *BufferD3D::getStaticIndexBuffer()
{
return mStaticIndexBuffer;
}
StaticVertexBufferInterface *BufferD3D::getStaticVertexBuffer(const gl::VertexAttribute &attribute,
const gl::VertexBinding &binding)
{
if (mStaticVertexBuffers.empty())
{
// Early out if there aren't any static buffers at all
return nullptr;
}
// Early out, the attribute can be added to mStaticVertexBuffer.
if (mStaticVertexBuffers.size() == 1 && mStaticVertexBuffers[0]->empty())
{
return mStaticVertexBuffers[0].get();
}
// Cache size limiting: track the total allocated buffer sizes.
size_t currentTotalSize = 0;
// At this point, see if any of the existing static buffers contains the attribute data
// If there is a cached static buffer that already contains the attribute, then return it
for (const auto &staticBuffer : mStaticVertexBuffers)
{
if (staticBuffer->matchesAttribute(attribute, binding))
{
return staticBuffer.get();
}
currentTotalSize += staticBuffer->getBufferSize();
}
// Cache size limiting: Clean-up threshold is four times the base buffer size, with a minimum.
ASSERT(getSize() < std::numeric_limits<size_t>::max() / 4u);
size_t sizeThreshold = std::max(getSize() * 4u, static_cast<size_t>(0x1000u));
// If we're past the threshold, clear the buffer cache. Note that this will release buffers
// that are currenly bound, and in an edge case can even translate the same attribute twice
// in the same draw call. It will not delete currently bound buffers, however, because they
// are ref counted.
if (currentTotalSize > sizeThreshold)
{
emptyStaticBufferCache();
}
// At this point, we must create a new static buffer for the attribute data.
StaticVertexBufferInterface *newStaticBuffer = new StaticVertexBufferInterface(mFactory);
newStaticBuffer->setAttribute(attribute, binding);
mStaticVertexBuffers.push_back(std::unique_ptr<StaticVertexBufferInterface>(newStaticBuffer));
return newStaticBuffer;
}
void BufferD3D::invalidateStaticData(const gl::Context *context, BufferFeedback *feedback)
{
emptyStaticBufferCache();
if (mStaticIndexBuffer && mStaticIndexBuffer->getBufferSize() != 0)
{
SafeDelete(mStaticIndexBuffer);
}
// If the buffer was created with a static usage then we recreate the static
// buffers so that they are populated the next time we use this buffer.
if (mUsage == D3DBufferUsage::STATIC)
{
initializeStaticData(context, feedback);
}
mUnmodifiedDataUse = 0;
}
// Creates static buffers if sufficient used data has been left unmodified
void BufferD3D::promoteStaticUsage(const gl::Context *context,
size_t dataSize,
BufferFeedback *feedback)
{
if (mUsage == D3DBufferUsage::DYNAMIC)
{
// Note: This is not a safe math operation. 'dataSize' can come from the app.
mUnmodifiedDataUse += dataSize;
if (mUnmodifiedDataUse > 3 * getSize())
{
updateD3DBufferUsage(context, gl::BufferUsage::StaticDraw, feedback);
}
}
}
angle::Result BufferD3D::getIndexRange(const gl::Context *context,
gl::DrawElementsType type,
size_t offset,
size_t count,
bool primitiveRestartEnabled,
gl::IndexRange *outRange)
{
const uint8_t *data = nullptr;
ANGLE_TRY(getData(context, &data));
*outRange = gl::ComputeIndexRange(type, data + offset, count, primitiveRestartEnabled);
return angle::Result::Continue;
}
} // namespace rx