IntermNodePatternMatcher.h

Show log
Commit

Hash : a735ee2f
Author :
Date : 2018-05-18T13:29:09

ES31: Support shader storage block in D3D11 compiler - Part1

This patch is the first step to implement a basic skeleton to translate
shader storage block to HLSL RWByteAddressBuffer.

In GLSL each shader storage block is just one structured block and in API side
it corresponds to a buffer range where stores the whole structure.
RWStructuredBuffer is an array-like object and can have many structured
elements. The structured element doesn't support unsized array and also have
a small limitation on the element size. So we choose RWByteAddressBuffer as
the counterpart of shader storage block in HLSL.

Due to RWByteAddressBuffer does not support using an index to reference a
specific location, we must use Load and Store to process the read/write
operation of a buffer variable. Moreover, in the compiler tree, since we
can't use variable name to get the resource value in RWByteAddressBuffer,
we have to calculate the offset of buffer variable in a shader storage block,
then call the corresponding wrapper function to get the right value.

In this patch, we only process below situations:
    assign_to_ssbo := ssbo_access_chain = expr_no_ssbo;
    assign_from_ssbo := lvalue_no_ssbo = ssbo_access_chain;

The translation is like below:
    // GLSL
    #version 310 es
    layout(local_size_x=8) in;
    layout(std140, binding = 0) buffer blockA {
        float f[8];
    } instanceA;
    layout(std140, binding = 1) buffer blockB {
        float f[8];
    };
    void main()
    {
        float data = instanceA.f[gl_LocalInvocationIndex];
        f[gl_LocalInvocationIndex] = data;
    }

    // HLSL
    RWByteAddressBuffer _instanceA: register(u0);
    RWByteAddressBuffer _blockB: register(u1);
    float float_Load(RWByteAddressBuffer buffer, uint loc)
    {
        float result = asfloat(buffer.Load(loc));
        return result;
    }

    void float_Store(RWByteAddressBuffer buffer, uint loc, float value)
    {
        buffer.Store(loc, asuint(value));
    }

    void gl_main()
    {
    float _data = float_Load(_instanceA, 0 + 16 * gl_LocalInvocationIndex);
    float_Store(_blockB, 0 + 16 * gl_LocalInvocationIndex, _data);
    }

We will do below things in the following patches:
1. Modify the intermediate tree to flatten all ssbo usages to:
    assign_to_ssbo := ssbo_access_chain = expr_no_ssbo;
    assign_from_ssbo := lvalue_no_ssbo = ssbo_access_chain;
e.g.
    intanceA.a +=1;
  ->tmp = intanceA.a;
    intanceA.a = tmp + 1;

    while(++instanceA.a < 16) {
    }
  ->
    int PreIncrement(out int a)
    {
        a += 1;
        return a;
    }
    tmp = instanceA.a;
    while(PreIncrement(tmp) < 16) {
        instanceA.a = tmp
    }

2. Add offset calculation for structure and array of arrays.
TODOs have been marked in the corresponding places in this patch.

3. Improve helper functions so that they can process all possible types.
TODOs have been marked in the corresponding places in this patch.

4. Process the swizzle situation.
TODOs have been marked in the corresponding places in this patch.
A possible method is to extend current helper functions like below:
    *_Load(RWByteAddressBuffer buffer, uint loc, bool isSwizzle, uint4 swizzleOffset)

Bug: angleproject:1951
Test: angle_end2end_tests

Change-Id: I68ae68d5bb77d0d5627c8272627a7f689b8dc38b
Reviewed-on: https://chromium-review.googlesource.com/848215
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Download

src/compiler/translator/tree_util/IntermNodePatternMatcher.h

//
// Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// IntermNodePatternMatcher is a helper class for matching node trees to given patterns.
// It can be used whenever the same checks for certain node structures are common to multiple AST
// traversers.
//

#ifndef COMPILER_TRANSLATOR_TREEUTIL_INTERMNODEPATTERNMATCHER_H_
#define COMPILER_TRANSLATOR_TREEUTIL_INTERMNODEPATTERNMATCHER_H_

namespace sh
{

class TIntermAggregate;
class TIntermBinary;
class TIntermDeclaration;
class TIntermNode;
class TIntermTernary;
class TIntermUnary;

class IntermNodePatternMatcher
{
  public:
    static bool IsDynamicIndexingOfNonSSBOVectorOrMatrix(TIntermBinary *node);
    static bool IsDynamicIndexingOfVectorOrMatrix(TIntermBinary *node);

    enum PatternType
    {
        // Matches expressions that are unfolded to if statements by UnfoldShortCircuitToIf
        kUnfoldedShortCircuitExpression = 0x0001,

        // Matches expressions that return arrays with the exception of simple statements where a
        // constructor or function call result is assigned.
        kExpressionReturningArray = 0x0001 << 1,

        // Matches dynamic indexing of vectors or matrices in l-values.
        kDynamicIndexingOfVectorOrMatrixInLValue = 0x0001 << 2,

        // Matches declarations with more than one declared variables.
        kMultiDeclaration = 0x0001 << 3,

        // Matches declarations of arrays.
        kArrayDeclaration = 0x0001 << 4,

        // Matches declarations of structs where the struct type does not have a name.
        kNamelessStructDeclaration = 0x0001 << 5,

        // Matches array length() method.
        kArrayLengthMethod = 0x0001 << 6,

        // Matches a vector or matrix constructor whose arguments are scalarized by the
        // SH_SCALARIZE_VEC_OR_MAT_CONSTRUCTOR_ARGUMENTS workaround.
        kScalarizedVecOrMatConstructor = 0x0001 << 7
    };
    IntermNodePatternMatcher(const unsigned int mask);

    bool match(TIntermUnary *node);

    bool match(TIntermBinary *node, TIntermNode *parentNode);

    // Use this version for checking binary node matches in case you're using flag
    // kDynamicIndexingOfVectorOrMatrixInLValue.
    bool match(TIntermBinary *node, TIntermNode *parentNode, bool isLValueRequiredHere);

    bool match(TIntermAggregate *node, TIntermNode *parentNode);
    bool match(TIntermTernary *node);
    bool match(TIntermDeclaration *node);

  private:
    const unsigned int mMask;

    bool matchInternal(TIntermBinary *node, TIntermNode *parentNode);
};

}  // namespace sh

#endif  // COMPILER_TRANSLATOR_TREEUTIL_INTERMNODEPATTERNMATCHER_H_

Download