• Show log

    Commit

  • Hash : 7c69116f
    Author : Charlie Lao
    Date : 2023-08-08T10:14:47

    Vulkan: Fix data race with DynamicDescriptorPool
    
    Right now DynamicDescriptorPool::destroyCachedDescriptorSet can be
    called from garbage clean up thread, while simultaneously accessed from
    context main thread, and data race will happen and cause bugs. This can
    only happen when the buffer is not being suballocated. In this case,
    suballocation owns the bufferBlock and bufferBlock gets destroyed when
    suballocation is destroyed from garbage collection thread. If buffer is
    suballocated, the shared group owns pool which owns bufferBlocks and
    they gets destroyed from shared group with the share group lock. This CL
    avoids this race problem by release the shared cacheKey when the buffer
    is released, while we still had the shared group lock.
    
    Bug: chromium:1469542
    Change-Id: Ic1f99e6b6083d63e4efb9c3f408921da62c006ac
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4761365
    Commit-Queue: Charlie Lao <cclao@google.com>
    Reviewed-by: Yuxin Hu <yuxinhu@google.com>
    Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    thodg_m kc3_lang_org thodg_w www_kmx_io thodg thodg_l
    Tags