kc3-lang/angle/src/libANGLE/renderer

• Show log

  Commit

• Hash : 1f5eb6b8
  Author :
  Date : 2021-11-17T16:42:20
  

  Avoid Android vkEnumerateDeviceExtensionProperties() bug
  
  This works around a race-condition during Android start-up, when ANGLE
  is used as the default GLES driver and when render engine (RE) is
  using SkiaGL (which uses ANGLE, which uses Vulkan).  The race
  condition occassionally results in different numbers of extensions
  between ANGLE's first and second calls to
  vkEnumerateDeviceExtensionProperties().  In that case, the second call
  would return VK_INCOMPLETE instead of VK_SUCCESS.  That caused ANGLE
  to fail to initialize, causing RE to fail to initialize.
  
  This change works around this problem by increasing the number of
  extensions asked for in the second call to
  vkEnumerateDeviceExtensionProperties().
  
  Background: Surface Flinger uses Hardware Composer (HWC) for
  hardware-based composition (e.g. using overlays), and RE for GPU
  composition (e.g. rendering to combine multiple app and system windows
  together).  SF, RE, and HWC all start about the same time.  HWC sets a
  property if it can support display timing.  This gets passed through
  SF to RE's Vulkan loader.  The Vulkan loader uses that property to
  determine whether to enable the VK_GOOGLE_display_timing extension.
  
  The Vulkan loader used to make a synchronous call to SF in
  vkEnumerateDeviceExtensionProperties() in order to get this property.
  That took some number of milliseconds to complete and affected the
  start-up time of every Vulkan/ANGLE app.  To eliminate that
  performance problem, the property now propogates in an asynchronous
  manner.  At that time, it was thought that RE would always get the
  property in time.  However, a partner's experience is that
  VK_INCOMPLETE is happening 0.5% of the time.
  
  ANGLE doesn't need to use the VK_GOOGLE_display_timing extension.
  This is because the Android EGL loader provides the related
  EGL_ANDROID_get_frame_timestamps extension.  The issue that ANGLE is
  working around is that it shouldn't fail to initialize in this
  situation.
  
  Bug: angleproject:6715
  Bug: b/206733351
  Change-Id: I4eb2197cdcc9692518b1bf5984d06fc8a1a7d145
  Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3290506
  Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
  Reviewed-by: Tim Van Patten <timvp@google.com>
  Commit-Queue: Ian Elliott <ianelliott@google.com>
  

• Files

• BufferImpl.cpp
• BufferImpl.h
• BufferImpl_mock.h
• CLCommandQueueImpl.cpp
• CLCommandQueueImpl.h
• CLContextImpl.cpp
• CLContextImpl.h
• CLDeviceImpl.cpp
• CLDeviceImpl.h
• CLEventImpl.cpp
• CLEventImpl.h
• CLExtensions.cpp
• CLExtensions.h
• CLKernelImpl.cpp
• CLKernelImpl.h
• CLMemoryImpl.cpp
• CLMemoryImpl.h
• CLPlatformImpl.cpp
• CLPlatformImpl.h
• CLProgramImpl.cpp
• CLProgramImpl.h
• CLSamplerImpl.cpp
• CLSamplerImpl.h
• CLtypes.h
• CompilerImpl.h
• ContextImpl.cpp
• ContextImpl.h
• DeviceImpl.cpp
• DeviceImpl.h
• DisplayImpl.cpp
• DisplayImpl.h
• EGLImplFactory.h
• EGLReusableSync.cpp
• EGLReusableSync.h
• EGLSyncImpl.cpp
• EGLSyncImpl.h
• FenceNVImpl.h
• Format.h
• FormatID_autogen.h
• Format_table_autogen.cpp
• FramebufferAttachmentObjectImpl.h
• FramebufferImpl.h
• FramebufferImpl_mock.h
• GLImplFactory.h
• ImageImpl.h
• ImageImpl_mock.h
• MemoryObjectImpl.h
• OverlayImpl.h
• ProgramImpl.h
• ProgramImpl_mock.h
• ProgramPipelineImpl.cpp
• ProgramPipelineImpl.h
• QueryImpl.cpp
• QueryImpl.h
• README.md
• RenderTargetCache.h
• RenderbufferImpl.h
• RenderbufferImpl_mock.h
• SamplerImpl.h
• SemaphoreImpl.h
• ShaderImpl.cpp
• ShaderImpl.h
• StreamProducerImpl.h
• SurfaceImpl.cpp
• SurfaceImpl.h
• SyncImpl.h
• TextureImpl.cpp
• TextureImpl.h
• TextureImpl_mock.h
• TransformFeedbackImpl.h
• TransformFeedbackImpl_mock.h
• VertexArrayImpl.h
• angle_format.py
• angle_format_data.json
• angle_format_map.json
• cl/
• copyvertex.h
• copyvertex.inc.h
• d3d/
• d3d_format.cpp
• d3d_format.h
• driver_utils.cpp
• driver_utils.h
• driver_utils_ios.mm
• driver_utils_mac.mm
• dxgi_format_data.json
• dxgi_format_map.h
• dxgi_format_map_autogen.cpp
• dxgi_support_data.json
• dxgi_support_table.h
• dxgi_support_table_autogen.cpp
• gen_angle_format_table.py
• gen_dxgi_format_table.py
• gen_dxgi_support_tables.py
• gen_load_functions_table.py
• gen_load_texture_border_functions_table.py
• gl/
• glslang_wrapper_utils.cpp
• glslang_wrapper_utils.h
• load_functions_data.json
• load_functions_table.h
• load_functions_table_autogen.cpp
• load_texture_border_functions_data.json
• load_texture_border_functions_table.h
• load_texture_border_functions_table_autogen.cpp
• metal/
• null/
• renderer_utils.cpp
• renderer_utils.h
• serial_utils.h
• serial_utils_unittest.cpp
• vulkan/

• Properties

• Git HTTP	https://git.kmx.io/kc3-lang/angle.git
  Git SSH	git@git.kmx.io:kc3-lang/angle.git
  Public access ?	public
  Description	A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android. Homepage Github
  Users
  Tags