-
Show log
Commit
-
Hash : 38e28257
Author :
Date : 2019-03-13T16:11:15
Fix ASSERT macro not printing message ANGLE's ASSERT macro was often not printing the error message before crashing. The printing happens in the destructor of a temporary object, but the temporary object is not guaranteed to be destroyed before ASSERT calls __builtin_trap(). This change fixes it by introducing a new FATAL log severity that moves the __builtin_trap() call into the destructor after the message is printed. Bug: 780507, angleproject:2215 Change-Id: Ica91e00d67cc95d7b59c3d59e6925ac3a93c19c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1521839 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org>
-
Files
- Color.h
- Color.inl
- FastVector.h
- FastVector_unittest.cpp
- FixedVector.h
- FixedVector_unittest.cpp
- Float16ToFloat32.cpp
- Float16ToFloat32.py
- MemoryBuffer.cpp
- MemoryBuffer.h
- Optional.h
- Optional_unittest.cpp
- PackedEGLEnums_autogen.cpp
- PackedEGLEnums_autogen.h
- PackedEnums.cpp
- PackedEnums.h
- PackedGLEnums_autogen.cpp
- PackedGLEnums_autogen.h
- PoolAlloc.cpp
- PoolAlloc.h
- PoolAlloc_unittest.cpp
- aligned_memory.cpp
- aligned_memory.h
- aligned_memory_unittest.cpp
- android_util.cpp
- android_util.h
- angleutils.cpp
- angleutils.h
- angleutils_unittest.cpp
- bitset_utils.h
- bitset_utils_unittest.cpp
- debug.cpp
- debug.h
- event_tracer.cpp
- event_tracer.h
- fuchsia_egl/
- gen_packed_gl_enums.py
- gen_uniform_type_table.py
- hash_utils.h
- hash_utils_unittest.cpp
- mathutil.cpp
- mathutil.h
- mathutil_unittest.cpp
- matrix_utils.cpp
- matrix_utils.h
- matrix_utils_unittest.cpp
- packed_egl_enums.json
- packed_gl_enums.json
- platform.h
- string_utils.cpp
- string_utils.h
- string_utils_unittest.cpp
- system_utils.cpp
- system_utils.h
- system_utils_linux.cpp
- system_utils_mac.cpp
- system_utils_posix.cpp
- system_utils_unittest.cpp
- system_utils_unittest_helper.cpp
- system_utils_unittest_helper.h
- system_utils_win.cpp
- third_party/
- tls.cpp
- tls.h
- uniform_type_info_autogen.cpp
- utilities.cpp
- utilities.h
- utilities_unittest.cpp
- vector_utils.h
- vector_utils_unittest.cpp
- version.h
