Hash :
5ae26eaa
Author :
Date :
2019-03-15T16:12:21
Fix several small issues in angle_end2end_tests. Many TearDown calls were missing. Also a few tests had other small issues. Discovered while changing the test harness. Bug: angleproject:3261 Change-Id: I8915088a6ca82e6cc4d6c922d03dc447e6051518 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1524699 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191
//
// Copyright (c) 2018 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// EGLDebugTest.cpp:
// Tests of EGL_KHR_debug extension
#include <gtest/gtest.h>
#include "test_utils/ANGLETest.h"
#include "test_utils/angle_test_configs.h"
#include "util/EGLWindow.h"
namespace angle
{
class EGLDebugTest : public ANGLETest
{
protected:
void TearDown() override
{
eglDebugMessageControlKHR(nullptr, nullptr);
ANGLETest::TearDown();
}
bool hasExtension() const { return eglClientExtensionEnabled("EGL_KHR_debug"); }
static void EGLAPIENTRY StubCallback(EGLenum error,
const char *command,
EGLint messageType,
EGLLabelKHR threadLabel,
EGLLabelKHR objectLabel,
const char *message)
{}
static void EGLAPIENTRY CheckBadBindAPIError(EGLenum error,
const char *command,
EGLint messageType,
EGLLabelKHR threadLabel,
EGLLabelKHR objectLabel,
const char *message)
{
EXPECT_STREQ("eglBindAPI", command);
ASSERT_EGLENUM_EQ(EGL_BAD_PARAMETER, error);
EXPECT_STREQ("Thread", static_cast<const char *>(threadLabel));
}
static EGLDEBUGPROCKHR EGLAttribToDebugCallback(EGLAttrib attrib)
{
return reinterpret_cast<EGLDEBUGPROCKHR>(static_cast<uintptr_t>(attrib));
}
static EGLAttrib DebugCallbackToEGLAttrib(EGLDEBUGPROCKHR callback)
{
return static_cast<EGLAttrib>(reinterpret_cast<intptr_t>(callback));
}
};
// Test that the extension is always available (it is implemented in ANGLE's frontend).
TEST_P(EGLDebugTest, ExtensionAlwaysAvailable)
{
ASSERT_TRUE(hasExtension());
}
// Check that the default message filters and callbacks are correct
TEST_P(EGLDebugTest, DefaultParameters)
{
ANGLE_SKIP_TEST_IF(!hasExtension());
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS), eglDebugMessageControlKHR(nullptr, nullptr));
EGLAttrib result = 0;
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_ERROR_KHR, &result));
EXPECT_EGL_TRUE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_WARN_KHR, &result));
EXPECT_EGL_FALSE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_INFO_KHR, &result));
EXPECT_EGL_FALSE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_CALLBACK_KHR, &result));
EXPECT_EQ(nullptr, EGLAttribToDebugCallback(result));
}
// Check that the message control and callback parameters can be set and then queried back
TEST_P(EGLDebugTest, SetMessageControl)
{
ANGLE_SKIP_TEST_IF(!hasExtension());
EGLAttrib controls[] = {
EGL_DEBUG_MSG_CRITICAL_KHR,
EGL_FALSE,
// EGL_DEBUG_MSG_ERROR_KHR left unset
EGL_DEBUG_MSG_WARN_KHR,
EGL_TRUE,
EGL_DEBUG_MSG_INFO_KHR,
EGL_FALSE,
EGL_NONE,
EGL_NONE,
};
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS), eglDebugMessageControlKHR(&StubCallback, controls));
EGLAttrib result = 0;
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_CRITICAL_KHR, &result));
EXPECT_EGL_FALSE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_ERROR_KHR, &result));
EXPECT_EGL_TRUE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_WARN_KHR, &result));
EXPECT_EGL_TRUE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_MSG_INFO_KHR, &result));
EXPECT_EGL_FALSE(result);
EXPECT_EGL_TRUE(eglQueryDebugKHR(EGL_DEBUG_CALLBACK_KHR, &result));
EXPECT_EQ(DebugCallbackToEGLAttrib(&StubCallback), result);
}
// Set a thread label and then trigger a callback to verify the callback parameters are correct
TEST_P(EGLDebugTest, CorrectCallbackParameters)
{
ANGLE_SKIP_TEST_IF(!hasExtension());
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS), eglDebugMessageControlKHR(nullptr, nullptr));
EXPECT_EQ(EGL_SUCCESS, eglLabelObjectKHR(EGL_NO_DISPLAY, EGL_OBJECT_THREAD_KHR, nullptr,
const_cast<char *>("Thread")));
// Enable all messages
EGLAttrib controls[] = {
EGL_DEBUG_MSG_CRITICAL_KHR,
EGL_TRUE,
EGL_DEBUG_MSG_ERROR_KHR,
EGL_TRUE,
EGL_DEBUG_MSG_WARN_KHR,
EGL_TRUE,
EGL_DEBUG_MSG_INFO_KHR,
EGL_TRUE,
EGL_NONE,
EGL_NONE,
};
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS),
eglDebugMessageControlKHR(&CheckBadBindAPIError, controls));
// Generate an error and trigger the callback
EXPECT_EGL_FALSE(eglBindAPI(0xBADDBADD));
}
// Test that labels can be set and that errors are generated if the wrong object type is used
TEST_P(EGLDebugTest, SetLabel)
{
ANGLE_SKIP_TEST_IF(!hasExtension());
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS), eglDebugMessageControlKHR(nullptr, nullptr));
// Display display and object must be equal when setting a display label
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS),
eglLabelObjectKHR(getEGLWindow()->getDisplay(), EGL_OBJECT_DISPLAY_KHR,
getEGLWindow()->getDisplay(), const_cast<char *>("Display")));
EXPECT_NE(static_cast<EGLint>(EGL_SUCCESS),
eglLabelObjectKHR(nullptr, EGL_OBJECT_DISPLAY_KHR, getEGLWindow()->getDisplay(),
const_cast<char *>("Display")));
// Set a surface label
EXPECT_EQ(static_cast<EGLint>(EGL_SUCCESS),
eglLabelObjectKHR(getEGLWindow()->getDisplay(), EGL_OBJECT_SURFACE_KHR,
getEGLWindow()->getSurface(), const_cast<char *>("Surface")));
EXPECT_EGL_ERROR(EGL_SUCCESS);
// Provide a surface but use an image label type
EXPECT_EQ(static_cast<EGLint>(EGL_BAD_PARAMETER),
eglLabelObjectKHR(getEGLWindow()->getDisplay(), EGL_OBJECT_IMAGE_KHR,
getEGLWindow()->getSurface(), const_cast<char *>("Image")));
EXPECT_EGL_ERROR(EGL_BAD_PARAMETER);
}
ANGLE_INSTANTIATE_TEST(EGLDebugTest,
ES2_D3D9(),
ES2_D3D11(),
ES3_D3D11(),
ES2_OPENGL(),
ES3_OPENGL(),
ES2_VULKAN());
} // namespace angle