Hash :
2ca14a9f
Author :
Date :
2023-02-10T13:58:19
EGL: No-op dma_buf import modifiers on some Mali devices. Some of the vendor checks in the EGL_EXT_image_dma_buf_import_modifiers enablement logic disable the extension on older Mali devices while Chrome depends on the presence of this extension, even if the implementation is no-op'ed. Refactor the logic into DisplayEGL with a tri-state: * Extension exposed and forwarded to the driver * Extension exposed and no-op'ed (Mali) * Extension not exposed (ARM) Bug: angleproject:7664 Change-Id: Idca7bb609423366779a65cd65093c9d5a65f0c19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4241483 Reviewed-by: Brian Ho <hob@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188
//
// Copyright 2016 The ANGLE Project Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
// DisplayEGL.h: Common across EGL parts of platform specific egl::Display implementations
#ifndef LIBANGLE_RENDERER_GL_EGL_DISPLAYEGL_H_
#define LIBANGLE_RENDERER_GL_EGL_DISPLAYEGL_H_
#include <map>
#include <string>
#include <vector>
#include "libANGLE/renderer/gl/DisplayGL.h"
#include "libANGLE/renderer/gl/egl/egl_utils.h"
namespace rx
{
class FunctionsEGL;
class FunctionsEGLDL;
class RendererEGL;
class WorkerContext;
class DisplayEGL : public DisplayGL
{
public:
DisplayEGL(const egl::DisplayState &state);
~DisplayEGL() override;
ImageImpl *createImage(const egl::ImageState &state,
const gl::Context *context,
EGLenum target,
const egl::AttributeMap &attribs) override;
EGLSyncImpl *createSync(const egl::AttributeMap &attribs) override;
void setBlobCacheFuncs(EGLSetBlobFuncANDROID set, EGLGetBlobFuncANDROID get) override;
virtual void destroyNativeContext(EGLContext context);
virtual WorkerContext *createWorkerContext(std::string *infoLog,
EGLContext sharedContext,
const native_egl::AttributeVector workerAttribs);
egl::Error initialize(egl::Display *display) override;
void terminate() override;
SurfaceImpl *createWindowSurface(const egl::SurfaceState &state,
EGLNativeWindowType window,
const egl::AttributeMap &attribs) override;
SurfaceImpl *createPbufferSurface(const egl::SurfaceState &state,
const egl::AttributeMap &attribs) override;
SurfaceImpl *createPbufferFromClientBuffer(const egl::SurfaceState &state,
EGLenum buftype,
EGLClientBuffer clientBuffer,
const egl::AttributeMap &attribs) override;
SurfaceImpl *createPixmapSurface(const egl::SurfaceState &state,
NativePixmapType nativePixmap,
const egl::AttributeMap &attribs) override;
ContextImpl *createContext(const gl::State &state,
gl::ErrorSet *errorSet,
const egl::Config *configuration,
const gl::Context *shareContext,
const egl::AttributeMap &attribs) override;
egl::ConfigSet generateConfigs() override;
bool testDeviceLost() override;
egl::Error restoreLostDevice(const egl::Display *display) override;
bool isValidNativeWindow(EGLNativeWindowType window) const override;
egl::Error validateClientBuffer(const egl::Config *configuration,
EGLenum buftype,
EGLClientBuffer clientBuffer,
const egl::AttributeMap &attribs) const override;
egl::Error waitClient(const gl::Context *context) override;
egl::Error waitNative(const gl::Context *context, EGLint engine) override;
egl::Error makeCurrent(egl::Display *display,
egl::Surface *drawSurface,
egl::Surface *readSurface,
gl::Context *context) override;
gl::Version getMaxSupportedESVersion() const override;
void initializeFrontendFeatures(angle::FrontendFeatures *features) const override;
void populateFeatureList(angle::FeatureList *features) override;
RendererGL *getRenderer() const override;
egl::Error validateImageClientBuffer(const gl::Context *context,
EGLenum target,
EGLClientBuffer clientBuffer,
const egl::AttributeMap &attribs) const override;
ExternalImageSiblingImpl *createExternalImageSibling(const gl::Context *context,
EGLenum target,
EGLClientBuffer buffer,
const egl::AttributeMap &attribs) override;
const FunctionsEGL *getFunctionsEGL() const;
DeviceImpl *createDevice() override;
bool supportsDmaBufFormat(EGLint format) const override;
egl::Error queryDmaBufFormats(EGLint maxFormats, EGLint *formats, EGLint *numFormats) override;
egl::Error queryDmaBufModifiers(EGLint format,
EGLint maxModifiers,
EGLuint64KHR *modifiers,
EGLBoolean *externalOnly,
EGLint *numModifiers) override;
protected:
virtual EGLint fixSurfaceType(EGLint surfaceType) const;
private:
const char *getEGLPath() const;
egl::Error initializeContext(EGLContext shareContext,
const egl::AttributeMap &eglAttributes,
EGLContext *outContext,
native_egl::AttributeVector *outAttribs) const;
void generateExtensions(egl::DisplayExtensions *outExtensions) const override;
egl::Error createRenderer(EGLContext shareContext,
bool makeNewContextCurrent,
bool isExternalContext,
std::shared_ptr<RendererEGL> *outRenderer);
egl::Error makeCurrentSurfaceless(gl::Context *context) override;
template <typename T>
void getConfigAttrib(EGLConfig config, EGLint attribute, T *value) const;
template <typename T, typename U>
void getConfigAttribIfExtension(EGLConfig config,
EGLint attribute,
T *value,
const char *extension,
const U &defaultValue) const;
std::shared_ptr<RendererEGL> mRenderer;
std::map<EGLAttrib, std::weak_ptr<RendererEGL>> mVirtualizationGroups;
FunctionsEGLDL *mEGL = nullptr;
EGLConfig mConfig = EGL_NO_CONFIG_KHR;
egl::AttributeMap mDisplayAttributes;
std::vector<EGLint> mConfigAttribList;
struct CurrentNativeContext
{
EGLSurface surface = EGL_NO_SURFACE;
EGLContext context = EGL_NO_CONTEXT;
// True if the current context is an external context. and both surface and context will be
// unset when an external context is current.
bool isExternalContext = false;
};
angle::HashMap<uint64_t, CurrentNativeContext> mCurrentNativeContexts;
void generateCaps(egl::Caps *outCaps) const override;
std::map<EGLint, EGLint> mConfigIds;
bool mHasEXTCreateContextRobustness = false;
bool mHasNVRobustnessVideoMemoryPurge = false;
bool mSupportsSurfaceless = false;
bool mSupportsNoConfigContexts = false;
EGLSurface mMockPbuffer = EGL_NO_SURFACE;
// Supported DRM formats
bool mSupportsDmaBufImportModifiers = false;
bool mNoOpDmaBufImportModifiers = false;
std::vector<EGLint> mDrmFormats;
bool mDrmFormatsInitialized = false;
};
} // namespace rx
#endif // LIBANGLE_RENDERER_GL_EGL_DISPLAYEGL_H_