• Show log

    Commit

  • Hash : f5f3304a
    Author : Chris Forbes
    Date : 2024-02-02T16:27:38

    Vulkan: Simplify handling of YUV filtering support
    
    When the requested filtering mode changes, we need to consider whether
    it is actually supported by the Vulkan driver. Now that we support
    renderable YUV textures, there are now three interesting cases:
    
    1) The texture has a VkFormat, and so filtering support can be queried
       from GPDFP, as was already done.
    
    2) The texture is imported from an opaque AHB using an external format,
       that format is renderable, and so we have assigned one of the
       EXTERNALn angle formats. This was *not* covered properly, and would
       lead to VVL errors or UB.
    
    3) The texture is imported from an opaque AHB using an external format,
       and we have not assigned an EXTERNALn angle format to it, because the
       format is not renderable, or the Vulkan driver is missing the
       external format resolve functionality; In this case the angle format
       is NONE.
       This was similarly *not* covered properly, although the code did
       attempt to protect itself from querying the capabilities of format
       NONE. VVL errors and UB were still possible.
    
    To most simply cover all of these cases, capture whether the image has
    the VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_LINEAR_FILTER
    feature upfront, and forget about format lookups in the internals of the
    YcbcrConversionDesc.
    
    Bug: b/315387961
    Change-Id: Ie140293d52c2b88bf06ef19bc54bb1c95927b8ce
    Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5259719
    Reviewed-by: Charlie Lao <cclao@google.com>
    Reviewed-by: Cody Northrop <cnorthrop@google.com>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/angle.git
    Git SSH git@git.kmx.io:kc3-lang/angle.git
    Public access ? public
    Description

    A conformant OpenGL ES implementation for Windows, Mac, Linux, iOS and Android.

    Homepage

    Github

    Users
    kc3_lang_org thodg_w www_kmx_io thodg_l thodg thodg_m
    Tags