kc3-lang/angle/src/compiler/translator/SplitSequenceOperator.cpp

• Show log

  Commit

• Hash : 68981eb5
  Author :
  Date : 2018-01-23T17:46:12
  

  Track parameter qualifiers of functions in call nodes
  
  We now add a reference to TFunction to all TIntermAggregate nodes
  where it is possible, including built-in ops. We also make sure
  that internal TFunctions added in traversers have correct parameter
  qualifiers.
  
  This makes TLValueTrackingTraverser much simpler. Instead of storing
  traversed functions or looking up builtin functions from the symbol
  table, determining which function parameters are out parameters can
  now be done simply by looking it up from the function symbol
  associated with the aggregate node.
  
  Symbol instances are no longer deleted when a symbol table level goes
  out of scope, and TFunction destructor no longer clears the
  parameters. They're all either statically allocated or pool allocated,
  so this does not result in leaks.
  
  TEST=angle_unittests
  BUG=angleproject:2267
  
  Change-Id: I57e5570da5b5a69a98a8778da3c2dc82b6284738
  Reviewed-on: https://chromium-review.googlesource.com/881324
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  

Download

• src/compiler/translator/SplitSequenceOperator.cpp

• //
  // Copyright (c) 2016 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  // SplitSequenceOperator is an AST traverser that detects sequence operator expressions that
  // go through further AST transformations that generate statements, and splits them so that
  // possible side effects of earlier parts of the sequence operator expression are guaranteed to be
  // evaluated before the latter parts of the sequence operator expression are evaluated.
  //
  
  #include "compiler/translator/SplitSequenceOperator.h"
  
  #include "compiler/translator/IntermNodePatternMatcher.h"
  #include "compiler/translator/IntermTraverse.h"
  
  namespace sh
  {
  
  namespace
  {
  
  class SplitSequenceOperatorTraverser : public TLValueTrackingTraverser
  {
    public:
      SplitSequenceOperatorTraverser(unsigned int patternsToSplitMask, TSymbolTable *symbolTable);
  
      bool visitUnary(Visit visit, TIntermUnary *node) override;
      bool visitBinary(Visit visit, TIntermBinary *node) override;
      bool visitAggregate(Visit visit, TIntermAggregate *node) override;
      bool visitTernary(Visit visit, TIntermTernary *node) override;
  
      void nextIteration();
      bool foundExpressionToSplit() const { return mFoundExpressionToSplit; }
  
    protected:
      // Marked to true once an operation that needs to be hoisted out of the expression has been
      // found. After that, no more AST updates are performed on that traversal.
      bool mFoundExpressionToSplit;
      int mInsideSequenceOperator;
  
      IntermNodePatternMatcher mPatternToSplitMatcher;
  };
  
  SplitSequenceOperatorTraverser::SplitSequenceOperatorTraverser(unsigned int patternsToSplitMask,
                                                                 TSymbolTable *symbolTable)
      : TLValueTrackingTraverser(true, false, true, symbolTable),
        mFoundExpressionToSplit(false),
        mInsideSequenceOperator(0),
        mPatternToSplitMatcher(patternsToSplitMask)
  {
  }
  
  void SplitSequenceOperatorTraverser::nextIteration()
  {
      mFoundExpressionToSplit = false;
      mInsideSequenceOperator = 0;
  }
  
  bool SplitSequenceOperatorTraverser::visitAggregate(Visit visit, TIntermAggregate *node)
  {
      if (mFoundExpressionToSplit)
          return false;
  
      if (mInsideSequenceOperator > 0 && visit == PreVisit)
      {
          // Detect expressions that need to be simplified
          mFoundExpressionToSplit = mPatternToSplitMatcher.match(node, getParentNode());
          return !mFoundExpressionToSplit;
      }
  
      return true;
  }
  
  bool SplitSequenceOperatorTraverser::visitUnary(Visit visit, TIntermUnary *node)
  {
      if (mFoundExpressionToSplit)
          return false;
  
      if (mInsideSequenceOperator > 0 && visit == PreVisit)
      {
          // Detect expressions that need to be simplified
          mFoundExpressionToSplit = mPatternToSplitMatcher.match(node);
          return !mFoundExpressionToSplit;
      }
  
      return true;
  }
  
  bool SplitSequenceOperatorTraverser::visitBinary(Visit visit, TIntermBinary *node)
  {
      if (node->getOp() == EOpComma)
      {
          if (visit == PreVisit)
          {
              if (mFoundExpressionToSplit)
              {
                  return false;
              }
              mInsideSequenceOperator++;
          }
          else if (visit == PostVisit)
          {
              // Split sequence operators starting from the outermost one to preserve correct
              // execution order.
              if (mFoundExpressionToSplit && mInsideSequenceOperator == 1)
              {
                  // Move the left side operand into a separate statement in the parent block.
                  TIntermSequence insertions;
                  insertions.push_back(node->getLeft());
                  insertStatementsInParentBlock(insertions);
                  // Replace the comma node with its right side operand.
                  queueReplacement(node->getRight(), OriginalNode::IS_DROPPED);
              }
              mInsideSequenceOperator--;
          }
          return true;
      }
  
      if (mFoundExpressionToSplit)
          return false;
  
      if (mInsideSequenceOperator > 0 && visit == PreVisit)
      {
          // Detect expressions that need to be simplified
          mFoundExpressionToSplit =
              mPatternToSplitMatcher.match(node, getParentNode(), isLValueRequiredHere());
          return !mFoundExpressionToSplit;
      }
  
      return true;
  }
  
  bool SplitSequenceOperatorTraverser::visitTernary(Visit visit, TIntermTernary *node)
  {
      if (mFoundExpressionToSplit)
          return false;
  
      if (mInsideSequenceOperator > 0 && visit == PreVisit)
      {
          // Detect expressions that need to be simplified
          mFoundExpressionToSplit = mPatternToSplitMatcher.match(node);
          return !mFoundExpressionToSplit;
      }
  
      return true;
  }
  
  }  // namespace
  
  void SplitSequenceOperator(TIntermNode *root, int patternsToSplitMask, TSymbolTable *symbolTable)
  {
      SplitSequenceOperatorTraverser traverser(patternsToSplitMask, symbolTable);
      // Separate one expression at a time, and reset the traverser between iterations.
      do
      {
          traverser.nextIteration();
          root->traverse(&traverser);
          if (traverser.foundExpressionToSplit())
              traverser.updateTree();
      } while (traverser.foundExpressionToSplit());
  }
  
  }  // namespace sh
  

Download