kc3-lang/angle/src/compiler/translator/UnfoldShortCircuitAST.cpp

• Show log

  Commit

• Hash : 1776fd08
  Author :
  Date : 2018-01-31T11:46:52
  

  Make use of CreateBoolNode in traversers
  
  This is just refactoring to clean up some duplicate code. A new test
  is added to make sure this doesn't break UnfoldShortCircuitAST.
  
  BUG=angleproject:1490
  TEST=angle_unittests
  
  Change-Id: I108e646f71ba631cbd5dad2055b64e6a30159742
  Reviewed-on: https://chromium-review.googlesource.com/894207
  Reviewed-by: Corentin Wallez <cwallez@chromium.org>
  Reviewed-by: Jamie Madill <jmadill@chromium.org>
  Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  

Download

• src/compiler/translator/UnfoldShortCircuitAST.cpp

• //
  // Copyright (c) 2002-2013 The ANGLE Project Authors. All rights reserved.
  // Use of this source code is governed by a BSD-style license that can be
  // found in the LICENSE file.
  //
  
  #include "compiler/translator/UnfoldShortCircuitAST.h"
  
  #include "compiler/translator/IntermNode.h"
  #include "compiler/translator/IntermNode_util.h"
  #include "compiler/translator/IntermTraverse.h"
  
  namespace sh
  {
  
  namespace
  {
  
  // "x || y" is equivalent to "x ? true : y".
  TIntermTernary *UnfoldOR(TIntermTyped *x, TIntermTyped *y)
  {
      return new TIntermTernary(x, CreateBoolNode(true), y);
  }
  
  // "x && y" is equivalent to "x ? y : false".
  TIntermTernary *UnfoldAND(TIntermTyped *x, TIntermTyped *y)
  {
      return new TIntermTernary(x, y, CreateBoolNode(false));
  }
  
  // This traverser identifies all the short circuit binary  nodes that need to
  // be replaced, and creates the corresponding replacement nodes. However,
  // the actual replacements happen after the traverse through updateTree().
  
  class UnfoldShortCircuitASTTraverser : public TIntermTraverser
  {
    public:
      UnfoldShortCircuitASTTraverser() : TIntermTraverser(true, false, false) {}
  
      bool visitBinary(Visit visit, TIntermBinary *) override;
  };
  
  bool UnfoldShortCircuitASTTraverser::visitBinary(Visit visit, TIntermBinary *node)
  {
      TIntermTernary *replacement = nullptr;
  
      switch (node->getOp())
      {
          case EOpLogicalOr:
              replacement = UnfoldOR(node->getLeft(), node->getRight());
              break;
          case EOpLogicalAnd:
              replacement = UnfoldAND(node->getLeft(), node->getRight());
              break;
          default:
              break;
      }
      if (replacement)
      {
          queueReplacement(replacement, OriginalNode::IS_DROPPED);
      }
      return true;
  }
  
  }  // anonymous namespace
  
  void UnfoldShortCircuitAST(TIntermBlock *root)
  {
      UnfoldShortCircuitASTTraverser traverser;
      root->traverse(&traverser);
      traverser.updateTree();
  }
  
  }  // namespace sh
  

Download