-
Show log
Commit
-
Hash : 4002e92a
Author :
Date : 2018-04-04T16:55:34
Guard traversers used during parsing against stack overflow Traversers used during parsing can be vulnerable to stack overflow since the AST has not yet been validated for max depth. Make sure to check for traversal depth in traversers used during parsing. We set the maximum traversal depth in ValidateGlobalInitializer and ValidateSwitchStatementList to 256, which matches the default value for validating general AST complexity. The depth check is on regardless of compiler options. In case the traversers go over the maximum traversal depth, they fail validation. BUG=angleproject:2453 TEST=angle_unittests Change-Id: I89ba576e8ef69663ba35d7b9050a6da319f1757c Reviewed-on: https://chromium-review.googlesource.com/995795 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
-
Files
- API_test.cpp
- ARB_texture_rectangle_test.cpp
- AppendixALimitations_test.cpp
- AtomicCounter_test.cpp
- BufferVariables_test.cpp
- CollectVariables_test.cpp
- ConstantFoldingNaN_test.cpp
- ConstantFoldingOverflow_test.cpp
- ConstantFolding_test.cpp
- ConstructCompiler_test.cpp
- DebugShaderPrecision_test.cpp
- EXT_YUV_target_test.cpp
- EXT_blend_func_extended_test.cpp
- EXT_frag_depth_test.cpp
- EXT_shader_texture_lod_test.cpp
- EmulateGLFragColorBroadcast_test.cpp
- ExpressionLimit_test.cpp
- ExtensionDirective_test.cpp
- FloatLex_test.cpp
- FragDepth_test.cpp
- GLSLCompatibilityOutput_test.cpp
- GeometryShader_test.cpp
- GlFragDataNotModified_test.cpp
- HLSLOutput_test.cpp
- ImmutableString_test_autogen.cpp
- InitOutputVariables_test.cpp
- IntermNode_test.cpp
- NV_draw_buffers_test.cpp
- OES_standard_derivatives_test.cpp
- Pack_Unpack_test.cpp
- PruneEmptyCases_test.cpp
- PruneEmptyDeclarations_test.cpp
- PrunePureLiteralStatements_test.cpp
- PruneUnusedFunctions_test.cpp
- QualificationOrderESSL31_test.cpp
- QualificationOrder_test.cpp
- RecordConstantPrecision_test.cpp
- RegenerateStructNames_test.cpp
- RemovePow_test.cpp
- RemoveUnreferencedVariables_test.cpp
- RewriteDoWhile_test.cpp
- SamplerMultisample_test.cpp
- ScalarizeVecAndMatConstructorArgs_test.cpp
- ShCompile_test.cpp
- ShaderImage_test.cpp
- ShaderValidation_test.cpp
- ShaderVariable_test.cpp
- TextureFunction_test.cpp
- TypeTracking_test.cpp
- Type_test.cpp
- UnfoldShortCircuitAST_test.cpp
- UnrollFlatten_test.cpp
- VariablePacker_test.cpp
- VectorizeVectorScalarArithmetic_test.cpp
- WEBGL_multiview_test.cpp
- WorkGroupSize_test.cpp
